From: Keith Busch <keith.busch@intel.com>
To: "Matias Bjørling" <mb@lightnvm.io>
Cc: Wei Xu <wxu@cnexlabs.com>,
linux-nvme@lists.infradead.org, javier@cnexlabs.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: lightnvm: add granby support
Date: Tue, 17 Apr 2018 16:09:01 -0600 [thread overview]
Message-ID: <20180417220901.GG11513@localhost.localdomain> (raw)
In-Reply-To: <6e50972d-f806-52ac-7983-2642bd211afa@lightnvm.io>
On Tue, Apr 17, 2018 at 08:16:25AM +0200, Matias Bjørling wrote:
> On 4/17/18 3:55 AM, Wei Xu wrote:
> > Add a new lightnvm quirk to identify CNEX’s Granby controller.
> >
> > Signed-off-by: Wei Xu <wxu@cnexlabs.com>
> > ---
> > drivers/nvme/host/pci.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> > index cb73bc8..9419e88 100644
> > --- a/drivers/nvme/host/pci.c
> > +++ b/drivers/nvme/host/pci.c
> > @@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
> > .driver_data = NVME_QUIRK_LIGHTNVM, },
> > { PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
> > .driver_data = NVME_QUIRK_LIGHTNVM, },
> > + { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
> > + .driver_data = NVME_QUIRK_LIGHTNVM, },
> > { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
> > { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
> > { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
> >
>
> Looks good to me.
>
> Reviewed-by: Matias Bjørling <mb@lightnvm.io>
>
> Keith, when convenient can you pick this up for 4.18?
This looks safe for 4.17-rc2, no? Unless you want to wait for the next
release.
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme: lightnvm: add granby support
Date: Tue, 17 Apr 2018 16:09:01 -0600 [thread overview]
Message-ID: <20180417220901.GG11513@localhost.localdomain> (raw)
In-Reply-To: <6e50972d-f806-52ac-7983-2642bd211afa@lightnvm.io>
On Tue, Apr 17, 2018@08:16:25AM +0200, Matias Bj?rling wrote:
> On 4/17/18 3:55 AM, Wei Xu wrote:
> > Add a new lightnvm quirk to identify CNEX?s Granby controller.
> >
> > Signed-off-by: Wei Xu <wxu at cnexlabs.com>
> > ---
> > drivers/nvme/host/pci.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> > index cb73bc8..9419e88 100644
> > --- a/drivers/nvme/host/pci.c
> > +++ b/drivers/nvme/host/pci.c
> > @@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
> > .driver_data = NVME_QUIRK_LIGHTNVM, },
> > { PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
> > .driver_data = NVME_QUIRK_LIGHTNVM, },
> > + { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
> > + .driver_data = NVME_QUIRK_LIGHTNVM, },
> > { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
> > { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
> > { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
> >
>
> Looks good to me.
>
> Reviewed-by: Matias Bj?rling <mb at lightnvm.io>
>
> Keith, when convenient can you pick this up for 4.18?
This looks safe for 4.17-rc2, no? Unless you want to wait for the next
release.
next prev parent reply other threads:[~2018-04-17 22:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 1:55 [PATCH] nvme: lightnvm: add granby support Wei Xu
2018-04-17 1:55 ` Wei Xu
2018-04-17 6:16 ` Matias Bjørling
2018-04-17 6:16 ` Matias Bjørling
2018-04-17 22:09 ` Keith Busch [this message]
2018-04-17 22:09 ` Keith Busch
2018-04-17 22:15 ` Jens Axboe
2018-04-17 22:15 ` Jens Axboe
2018-04-17 22:19 ` Keith Busch
2018-04-17 22:19 ` Keith Busch
2018-04-17 22:19 ` Keith Busch
2018-04-17 9:26 ` Javier Gonzalez
2018-04-17 9:26 ` Javier Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417220901.GG11513@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=javier@cnexlabs.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mb@lightnvm.io \
--cc=wxu@cnexlabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.