* [PATCH] nvme: lightnvm: add granby support
@ 2018-04-17 1:55 ` Wei Xu
0 siblings, 0 replies; 13+ messages in thread
From: Wei Xu @ 2018-04-17 1:55 UTC (permalink / raw)
Add a new lightnvm quirk to identify CNEX?s Granby controller.
Signed-off-by: Wei Xu <wxu at cnexlabs.com>
---
drivers/nvme/host/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index cb73bc8..9419e88 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_LIGHTNVM, },
{ PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
.driver_data = NVME_QUIRK_LIGHTNVM, },
+ { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
+ .driver_data = NVME_QUIRK_LIGHTNVM, },
{ PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] nvme: lightnvm: add granby support
2018-04-17 1:55 ` Wei Xu
@ 2018-04-17 6:16 ` Matias Bjørling
-1 siblings, 0 replies; 13+ messages in thread
From: Matias Bjørling @ 2018-04-17 6:16 UTC (permalink / raw)
To: Wei Xu, linux-nvme; +Cc: javier, keith.busch, linux-block, linux-kernel
On 4/17/18 3:55 AM, Wei Xu wrote:
> Add a new lightnvm quirk to identify CNEX’s Granby controller.
>
> Signed-off-by: Wei Xu <wxu@cnexlabs.com>
> ---
> drivers/nvme/host/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index cb73bc8..9419e88 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> + { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
> + .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
>
Looks good to me.
Reviewed-by: Matias Bjørling <mb@lightnvm.io>
Keith, when convenient can you pick this up for 4.18?
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] nvme: lightnvm: add granby support
@ 2018-04-17 6:16 ` Matias Bjørling
0 siblings, 0 replies; 13+ messages in thread
From: Matias Bjørling @ 2018-04-17 6:16 UTC (permalink / raw)
On 4/17/18 3:55 AM, Wei Xu wrote:
> Add a new lightnvm quirk to identify CNEX?s Granby controller.
>
> Signed-off-by: Wei Xu <wxu at cnexlabs.com>
> ---
> drivers/nvme/host/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index cb73bc8..9419e88 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> + { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
> + .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
>
Looks good to me.
Reviewed-by: Matias Bj?rling <mb at lightnvm.io>
Keith, when convenient can you pick this up for 4.18?
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] nvme: lightnvm: add granby support
2018-04-17 6:16 ` Matias Bjørling
@ 2018-04-17 22:09 ` Keith Busch
-1 siblings, 0 replies; 13+ messages in thread
From: Keith Busch @ 2018-04-17 22:09 UTC (permalink / raw)
To: Matias Bjørling
Cc: Wei Xu, linux-nvme, javier, linux-block, linux-kernel
On Tue, Apr 17, 2018 at 08:16:25AM +0200, Matias Bjørling wrote:
> On 4/17/18 3:55 AM, Wei Xu wrote:
> > Add a new lightnvm quirk to identify CNEX’s Granby controller.
> >
> > Signed-off-by: Wei Xu <wxu@cnexlabs.com>
> > ---
> > drivers/nvme/host/pci.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> > index cb73bc8..9419e88 100644
> > --- a/drivers/nvme/host/pci.c
> > +++ b/drivers/nvme/host/pci.c
> > @@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
> > .driver_data = NVME_QUIRK_LIGHTNVM, },
> > { PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
> > .driver_data = NVME_QUIRK_LIGHTNVM, },
> > + { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
> > + .driver_data = NVME_QUIRK_LIGHTNVM, },
> > { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
> > { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
> > { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
> >
>
> Looks good to me.
>
> Reviewed-by: Matias Bjørling <mb@lightnvm.io>
>
> Keith, when convenient can you pick this up for 4.18?
This looks safe for 4.17-rc2, no? Unless you want to wait for the next
release.
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] nvme: lightnvm: add granby support
@ 2018-04-17 22:09 ` Keith Busch
0 siblings, 0 replies; 13+ messages in thread
From: Keith Busch @ 2018-04-17 22:09 UTC (permalink / raw)
On Tue, Apr 17, 2018@08:16:25AM +0200, Matias Bj?rling wrote:
> On 4/17/18 3:55 AM, Wei Xu wrote:
> > Add a new lightnvm quirk to identify CNEX?s Granby controller.
> >
> > Signed-off-by: Wei Xu <wxu at cnexlabs.com>
> > ---
> > drivers/nvme/host/pci.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> > index cb73bc8..9419e88 100644
> > --- a/drivers/nvme/host/pci.c
> > +++ b/drivers/nvme/host/pci.c
> > @@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
> > .driver_data = NVME_QUIRK_LIGHTNVM, },
> > { PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
> > .driver_data = NVME_QUIRK_LIGHTNVM, },
> > + { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
> > + .driver_data = NVME_QUIRK_LIGHTNVM, },
> > { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
> > { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
> > { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
> >
>
> Looks good to me.
>
> Reviewed-by: Matias Bj?rling <mb at lightnvm.io>
>
> Keith, when convenient can you pick this up for 4.18?
This looks safe for 4.17-rc2, no? Unless you want to wait for the next
release.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] nvme: lightnvm: add granby support
2018-04-17 22:09 ` Keith Busch
@ 2018-04-17 22:15 ` Jens Axboe
-1 siblings, 0 replies; 13+ messages in thread
From: Jens Axboe @ 2018-04-17 22:15 UTC (permalink / raw)
To: Keith Busch, Matias Bjørling
Cc: Wei Xu, linux-nvme, javier, linux-block, linux-kernel
On 4/17/18 4:09 PM, Keith Busch wrote:
> On Tue, Apr 17, 2018 at 08:16:25AM +0200, Matias Bjørling wrote:
>> On 4/17/18 3:55 AM, Wei Xu wrote:
>>> Add a new lightnvm quirk to identify CNEX’s Granby controller.
>>>
>>> Signed-off-by: Wei Xu <wxu@cnexlabs.com>
>>> ---
>>> drivers/nvme/host/pci.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
>>> index cb73bc8..9419e88 100644
>>> --- a/drivers/nvme/host/pci.c
>>> +++ b/drivers/nvme/host/pci.c
>>> @@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
>>> .driver_data = NVME_QUIRK_LIGHTNVM, },
>>> { PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
>>> .driver_data = NVME_QUIRK_LIGHTNVM, },
>>> + { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
>>> + .driver_data = NVME_QUIRK_LIGHTNVM, },
>>> { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
>>> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
>>> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
>>>
>>
>> Looks good to me.
>>
>> Reviewed-by: Matias Bjørling <mb@lightnvm.io>
>>
>> Keith, when convenient can you pick this up for 4.18?
>
> This looks safe for 4.17-rc2, no? Unless you want to wait for the next
> release.
It should wait for the next release, it's not a fix.
--
Jens Axboe
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] nvme: lightnvm: add granby support
@ 2018-04-17 22:15 ` Jens Axboe
0 siblings, 0 replies; 13+ messages in thread
From: Jens Axboe @ 2018-04-17 22:15 UTC (permalink / raw)
On 4/17/18 4:09 PM, Keith Busch wrote:
> On Tue, Apr 17, 2018@08:16:25AM +0200, Matias Bj?rling wrote:
>> On 4/17/18 3:55 AM, Wei Xu wrote:
>>> Add a new lightnvm quirk to identify CNEX?s Granby controller.
>>>
>>> Signed-off-by: Wei Xu <wxu at cnexlabs.com>
>>> ---
>>> drivers/nvme/host/pci.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
>>> index cb73bc8..9419e88 100644
>>> --- a/drivers/nvme/host/pci.c
>>> +++ b/drivers/nvme/host/pci.c
>>> @@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
>>> .driver_data = NVME_QUIRK_LIGHTNVM, },
>>> { PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
>>> .driver_data = NVME_QUIRK_LIGHTNVM, },
>>> + { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
>>> + .driver_data = NVME_QUIRK_LIGHTNVM, },
>>> { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
>>> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
>>> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
>>>
>>
>> Looks good to me.
>>
>> Reviewed-by: Matias Bj?rling <mb at lightnvm.io>
>>
>> Keith, when convenient can you pick this up for 4.18?
>
> This looks safe for 4.17-rc2, no? Unless you want to wait for the next
> release.
It should wait for the next release, it's not a fix.
--
Jens Axboe
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] nvme: lightnvm: add granby support
2018-04-17 22:15 ` Jens Axboe
(?)
@ 2018-04-17 22:19 ` Keith Busch
-1 siblings, 0 replies; 13+ messages in thread
From: Keith Busch @ 2018-04-17 22:19 UTC (permalink / raw)
To: Jens Axboe
Cc: Matias Bjørling, Wei Xu, linux-nvme, javier, linux-block,
linux-kernel
On Tue, Apr 17, 2018 at 04:15:38PM -0600, Jens Axboe wrote:
> >> Looks good to me.
> >>
> >> Reviewed-by: Matias Bj�rling <mb@lightnvm.io>
> >>
> >> Keith, when convenient can you pick this up for 4.18?
> >
> > This looks safe for 4.17-rc2, no? Unless you want to wait for the next
> > release.
>
> It should wait for the next release, it's not a fix.
Okay, queued up for the next release. I'll wait a few more rc's before
posting the nvme-4.18 branch.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] nvme: lightnvm: add granby support
@ 2018-04-17 22:19 ` Keith Busch
0 siblings, 0 replies; 13+ messages in thread
From: Keith Busch @ 2018-04-17 22:19 UTC (permalink / raw)
To: Jens Axboe
Cc: Matias Bjørling, Wei Xu, linux-nvme, javier, linux-block,
linux-kernel
On Tue, Apr 17, 2018 at 04:15:38PM -0600, Jens Axboe wrote:
> >> Looks good to me.
> >>
> >> Reviewed-by: Matias Bjørling <mb@lightnvm.io>
> >>
> >> Keith, when convenient can you pick this up for 4.18?
> >
> > This looks safe for 4.17-rc2, no? Unless you want to wait for the next
> > release.
>
> It should wait for the next release, it's not a fix.
Okay, queued up for the next release. I'll wait a few more rc's before
posting the nvme-4.18 branch.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] nvme: lightnvm: add granby support
@ 2018-04-17 22:19 ` Keith Busch
0 siblings, 0 replies; 13+ messages in thread
From: Keith Busch @ 2018-04-17 22:19 UTC (permalink / raw)
On Tue, Apr 17, 2018@04:15:38PM -0600, Jens Axboe wrote:
> >> Looks good to me.
> >>
> >> Reviewed-by: Matias Bj?rling <mb at lightnvm.io>
> >>
> >> Keith, when convenient can you pick this up for 4.18?
> >
> > This looks safe for 4.17-rc2, no? Unless you want to wait for the next
> > release.
>
> It should wait for the next release, it's not a fix.
Okay, queued up for the next release. I'll wait a few more rc's before
posting the nvme-4.18 branch.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] nvme: lightnvm: add granby support
2018-04-17 1:55 ` Wei Xu
@ 2018-04-17 9:26 ` Javier Gonzalez
-1 siblings, 0 replies; 13+ messages in thread
From: Javier Gonzalez @ 2018-04-17 9:26 UTC (permalink / raw)
To: Wei Xu
Cc: linux-nvme@lists.infradead.org, Matias Bjørling, Keith Busch,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
> On 17 Apr 2018, at 03.55, Wei Xu <wxu@cnexlabs.com> wrote:
>
> Add a new lightnvm quirk to identify CNEX’s Granby controller.
>
> Signed-off-by: Wei Xu <wxu@cnexlabs.com>
> ---
> drivers/nvme/host/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index cb73bc8..9419e88 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> + { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
> + .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
> --
> 2.7.4
Reviewed-by: Javier González <javier@cnexlabs.com>
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] nvme: lightnvm: add granby support
@ 2018-04-17 9:26 ` Javier Gonzalez
0 siblings, 0 replies; 13+ messages in thread
From: Javier Gonzalez @ 2018-04-17 9:26 UTC (permalink / raw)
> On 17 Apr 2018,@03.55, Wei Xu <wxu@cnexlabs.com> wrote:
>
> Add a new lightnvm quirk to identify CNEX?s Granby controller.
>
> Signed-off-by: Wei Xu <wxu at cnexlabs.com>
> ---
> drivers/nvme/host/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index cb73bc8..9419e88 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> + { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
> + .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
> --
> 2.7.4
Reviewed-by: Javier Gonz?lez <javier at cnexlabs.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20180417/7e5ba093/attachment.sig>
^ permalink raw reply [flat|nested] 13+ messages in thread