All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
	ysato@users.sourceforge.jp, dalias@libc.org,
	thomas.petazzoni@free-electrons.com, robin.murphy@arm.com,
	geert@linux-m68k.org, linux-renesas-soc@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: mm: Fix unprotected access to struct device
Date: Fri, 20 Apr 2018 01:30:32 -0700	[thread overview]
Message-ID: <20180420083032.GB31275@infradead.org> (raw)
In-Reply-To: <20180417155407.49c981b3@windsurf.numericable.fr>

On Tue, Apr 17, 2018 at 03:54:07PM +0200, Thomas Petazzoni wrote:
> 
>   dma_alloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
> 
> and one to switch to the WARN_ON + if(dev) model. But I don't really
> care either way, so:
> 
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Yes, these should be separate patches.  And I actually hope we can
do with the NULL dev check, but that is a different sub-thread.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
	ysato@users.sourceforge.jp, dalias@libc.org,
	thomas.petazzoni@free-electrons.com, robin.murphy@arm.com,
	geert@linux-m68k.org, linux-renesas-soc@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: mm: Fix unprotected access to struct device
Date: Fri, 20 Apr 2018 08:30:32 +0000	[thread overview]
Message-ID: <20180420083032.GB31275@infradead.org> (raw)
In-Reply-To: <20180417155407.49c981b3@windsurf.numericable.fr>

On Tue, Apr 17, 2018 at 03:54:07PM +0200, Thomas Petazzoni wrote:
> 
>   dma_alloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
> 
> and one to switch to the WARN_ON + if(dev) model. But I don't really
> care either way, so:
> 
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Yes, these should be separate patches.  And I actually hope we can
do with the NULL dev check, but that is a different sub-thread.

  parent reply	other threads:[~2018-04-20  8:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17 13:35 [PATCH] sh: mm: Fix unprotected access to struct device Jacopo Mondi
2018-04-17 13:35 ` Jacopo Mondi
2018-04-17 13:54 ` Thomas Petazzoni
2018-04-17 13:54   ` Thomas Petazzoni
2018-04-17 13:59   ` jacopo mondi
2018-04-17 13:59     ` jacopo mondi
2018-04-20  8:30   ` Christoph Hellwig [this message]
2018-04-20  8:30     ` Christoph Hellwig
2018-04-17 14:04 ` Geert Uytterhoeven
2018-04-17 14:04   ` Geert Uytterhoeven
2018-04-17 14:20   ` jacopo mondi
2018-04-17 14:20     ` jacopo mondi
2018-04-18  9:13 ` Sergei Shtylyov
2018-04-18  9:13   ` Sergei Shtylyov
2018-04-18 10:47 ` Christoph Hellwig
2018-04-18 10:47   ` Christoph Hellwig
2018-04-18 13:13   ` jacopo mondi
2018-04-18 13:13     ` jacopo mondi
2018-04-20  8:31     ` Christoph Hellwig
2018-04-20  8:31       ` Christoph Hellwig
2018-04-20  9:59       ` Geert Uytterhoeven
2018-04-20  9:59         ` Geert Uytterhoeven
2018-04-20 14:56         ` Rich Felker
2018-04-20 14:56           ` Rich Felker
2018-05-02  7:41         ` jacopo mondi
2018-05-02  7:41           ` jacopo mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180420083032.GB31275@infradead.org \
    --to=hch@infradead.org \
    --cc=dalias@libc.org \
    --cc=geert@linux-m68k.org \
    --cc=jacopo+renesas@jmondi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.