From: Christoph Hellwig <hch@infradead.org>
To: jacopo mondi <jacopo@jmondi.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
ysato@users.sourceforge.jp, dalias@libc.org,
thomas.petazzoni@free-electrons.com, robin.murphy@arm.com,
geert@linux-m68k.org, linux-renesas-soc@vger.kernel.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: mm: Fix unprotected access to struct device
Date: Fri, 20 Apr 2018 01:31:47 -0700 [thread overview]
Message-ID: <20180420083147.GC31275@infradead.org> (raw)
In-Reply-To: <20180418131314.GC3999@w540>
On Wed, Apr 18, 2018 at 03:13:14PM +0200, jacopo mondi wrote:
> As long as it goes for arch/sh, the only user of dma_alloc_coherent()
> is platform_resource_setup_memory(), and it has been fixed by this
> patch.
Great!
>
> Unfortunately, as Thomas pointed out, there are drivers which calls
> into this with the wrong 'struct device' as the sh_eth one he had fixed.
Yes, we'll need fixes there. Other DMA ops implementations also look
at struct device, so they generally are buggy.
> I would then say that as long as it goes for the NULL case, we should be
> fine now.
Then I'd say skil that part, please.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: jacopo mondi <jacopo@jmondi.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
ysato@users.sourceforge.jp, dalias@libc.org,
thomas.petazzoni@free-electrons.com, robin.murphy@arm.com,
geert@linux-m68k.org, linux-renesas-soc@vger.kernel.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: mm: Fix unprotected access to struct device
Date: Fri, 20 Apr 2018 08:31:47 +0000 [thread overview]
Message-ID: <20180420083147.GC31275@infradead.org> (raw)
In-Reply-To: <20180418131314.GC3999@w540>
On Wed, Apr 18, 2018 at 03:13:14PM +0200, jacopo mondi wrote:
> As long as it goes for arch/sh, the only user of dma_alloc_coherent()
> is platform_resource_setup_memory(), and it has been fixed by this
> patch.
Great!
>
> Unfortunately, as Thomas pointed out, there are drivers which calls
> into this with the wrong 'struct device' as the sh_eth one he had fixed.
Yes, we'll need fixes there. Other DMA ops implementations also look
at struct device, so they generally are buggy.
> I would then say that as long as it goes for the NULL case, we should be
> fine now.
Then I'd say skil that part, please.
next prev parent reply other threads:[~2018-04-20 8:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 13:35 [PATCH] sh: mm: Fix unprotected access to struct device Jacopo Mondi
2018-04-17 13:35 ` Jacopo Mondi
2018-04-17 13:54 ` Thomas Petazzoni
2018-04-17 13:54 ` Thomas Petazzoni
2018-04-17 13:59 ` jacopo mondi
2018-04-17 13:59 ` jacopo mondi
2018-04-20 8:30 ` Christoph Hellwig
2018-04-20 8:30 ` Christoph Hellwig
2018-04-17 14:04 ` Geert Uytterhoeven
2018-04-17 14:04 ` Geert Uytterhoeven
2018-04-17 14:20 ` jacopo mondi
2018-04-17 14:20 ` jacopo mondi
2018-04-18 9:13 ` Sergei Shtylyov
2018-04-18 9:13 ` Sergei Shtylyov
2018-04-18 10:47 ` Christoph Hellwig
2018-04-18 10:47 ` Christoph Hellwig
2018-04-18 13:13 ` jacopo mondi
2018-04-18 13:13 ` jacopo mondi
2018-04-20 8:31 ` Christoph Hellwig [this message]
2018-04-20 8:31 ` Christoph Hellwig
2018-04-20 9:59 ` Geert Uytterhoeven
2018-04-20 9:59 ` Geert Uytterhoeven
2018-04-20 14:56 ` Rich Felker
2018-04-20 14:56 ` Rich Felker
2018-05-02 7:41 ` jacopo mondi
2018-05-02 7:41 ` jacopo mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420083147.GC31275@infradead.org \
--to=hch@infradead.org \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=jacopo+renesas@jmondi.org \
--cc=jacopo@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.