All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Robert Tarasov <tutankhamen@chromium.org>,
	Keith Packard <keithp@keithp.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Alex Deucher <alexander.deucher@amd.com>,
	Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] drm/udl: fix mode_valid's return type
Date: Wed, 25 Apr 2018 09:08:58 +0200	[thread overview]
Message-ID: <20180425070858.GL25142@phenom.ffwll.local> (raw)
In-Reply-To: <20180424131520.2409-1-luc.vanoostenryck@gmail.com>

On Tue, Apr 24, 2018 at 03:15:17PM +0200, Luc Van Oostenryck wrote:
> The method struct drm_connector_helper_funcs::mode_valid is defined
> as returning an 'enum drm_mode_status' but the driver implementation
> for this method uses an 'int' for it.
> 
> Fix this by using 'enum drm_mode_status' in the driver too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

hisilicon, mgag200 and udl patches also merged to drm-misc-next.
-Daniel

> ---
>  drivers/gpu/drm/udl/udl_connector.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c
> index c3dc1fd20..09dc585aa 100644
> --- a/drivers/gpu/drm/udl/udl_connector.c
> +++ b/drivers/gpu/drm/udl/udl_connector.c
> @@ -105,7 +105,7 @@ static int udl_get_modes(struct drm_connector *connector)
>  	return 0;
>  }
>  
> -static int udl_mode_valid(struct drm_connector *connector,
> +static enum drm_mode_status udl_mode_valid(struct drm_connector *connector,
>  			  struct drm_display_mode *mode)
>  {
>  	struct udl_device *udl = connector->dev->dev_private;
> -- 
> 2.17.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: linux-kernel@vger.kernel.org, Dave Airlie <airlied@redhat.com>,
	David Airlie <airlied@linux.ie>,
	Alex Deucher <alexander.deucher@amd.com>,
	Robert Tarasov <tutankhamen@chromium.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Keith Packard <keithp@keithp.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/udl: fix mode_valid's return type
Date: Wed, 25 Apr 2018 09:08:58 +0200	[thread overview]
Message-ID: <20180425070858.GL25142@phenom.ffwll.local> (raw)
In-Reply-To: <20180424131520.2409-1-luc.vanoostenryck@gmail.com>

On Tue, Apr 24, 2018 at 03:15:17PM +0200, Luc Van Oostenryck wrote:
> The method struct drm_connector_helper_funcs::mode_valid is defined
> as returning an 'enum drm_mode_status' but the driver implementation
> for this method uses an 'int' for it.
> 
> Fix this by using 'enum drm_mode_status' in the driver too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

hisilicon, mgag200 and udl patches also merged to drm-misc-next.
-Daniel

> ---
>  drivers/gpu/drm/udl/udl_connector.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c
> index c3dc1fd20..09dc585aa 100644
> --- a/drivers/gpu/drm/udl/udl_connector.c
> +++ b/drivers/gpu/drm/udl/udl_connector.c
> @@ -105,7 +105,7 @@ static int udl_get_modes(struct drm_connector *connector)
>  	return 0;
>  }
>  
> -static int udl_mode_valid(struct drm_connector *connector,
> +static enum drm_mode_status udl_mode_valid(struct drm_connector *connector,
>  			  struct drm_display_mode *mode)
>  {
>  	struct udl_device *udl = connector->dev->dev_private;
> -- 
> 2.17.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

  reply	other threads:[~2018-04-25  7:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 13:15 [PATCH] drm/udl: fix mode_valid's return type Luc Van Oostenryck
2018-04-25  7:08 ` Daniel Vetter [this message]
2018-04-25  7:08   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425070858.GL25142@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=alexander.deucher@amd.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=keithp@keithp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=tutankhamen@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.