From: Simon Guo <wei.guo.simon@gmail.com>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 09/11] KVM: PPC: reconstruct LOAD_FP/STORE_FP instruction mmio emulation with analyse_int
Date: Thu, 03 May 2018 09:25:15 +0000 [thread overview]
Message-ID: <20180503092515.GI6755@simonLocalRHEL7.x64> (raw)
In-Reply-To: <20180503061049.GJ6795@fergus.ozlabs.ibm.com>
On Thu, May 03, 2018 at 04:10:49PM +1000, Paul Mackerras wrote:
> On Wed, Apr 25, 2018 at 07:54:42PM +0800, wei.guo.simon@gmail.com wrote:
> > From: Simon Guo <wei.guo.simon@gmail.com>
> >
> > This patch reconstructs LOAD_FP/STORE_FP instruction MMIO emulation with
> > analyse_intr() input. It utilizes the FPCONV/UPDATE properties exported by
> > analyse_instr() and invokes kvmppc_handle_load(s)/kvmppc_handle_store()
> > accordingly.
> >
> > The FP regs need to be flushed so that the right FP reg vals can be read
> > from vcpu->arch.fpr.
>
> This only applies for store instructions; it would be clearer if you
> said that explicitly.
I will correct this message.
>
> >
> > Suggested-by: Paul Mackerras <paulus@ozlabs.org>
> > Signed-off-by: Simon Guo <wei.guo.simon@gmail.com>
>
> Same comment about updating RA as for the other patches. Otherwise
> this looks fine.
>
> Paul.
Thanks,
- Simon
WARNING: multiple messages have this Message-ID (diff)
From: Simon Guo <wei.guo.simon@gmail.com>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 09/11] KVM: PPC: reconstruct LOAD_FP/STORE_FP instruction mmio emulation with analyse_intr() input
Date: Thu, 3 May 2018 17:25:15 +0800 [thread overview]
Message-ID: <20180503092515.GI6755@simonLocalRHEL7.x64> (raw)
In-Reply-To: <20180503061049.GJ6795@fergus.ozlabs.ibm.com>
On Thu, May 03, 2018 at 04:10:49PM +1000, Paul Mackerras wrote:
> On Wed, Apr 25, 2018 at 07:54:42PM +0800, wei.guo.simon@gmail.com wrote:
> > From: Simon Guo <wei.guo.simon@gmail.com>
> >
> > This patch reconstructs LOAD_FP/STORE_FP instruction MMIO emulation with
> > analyse_intr() input. It utilizes the FPCONV/UPDATE properties exported by
> > analyse_instr() and invokes kvmppc_handle_load(s)/kvmppc_handle_store()
> > accordingly.
> >
> > The FP regs need to be flushed so that the right FP reg vals can be read
> > from vcpu->arch.fpr.
>
> This only applies for store instructions; it would be clearer if you
> said that explicitly.
I will correct this message.
>
> >
> > Suggested-by: Paul Mackerras <paulus@ozlabs.org>
> > Signed-off-by: Simon Guo <wei.guo.simon@gmail.com>
>
> Same comment about updating RA as for the other patches. Otherwise
> this looks fine.
>
> Paul.
Thanks,
- Simon
WARNING: multiple messages have this Message-ID (diff)
From: Simon Guo <wei.guo.simon@gmail.com>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 09/11] KVM: PPC: reconstruct LOAD_FP/STORE_FP instruction mmio emulation with analyse_intr() input
Date: Thu, 3 May 2018 17:25:15 +0800 [thread overview]
Message-ID: <20180503092515.GI6755@simonLocalRHEL7.x64> (raw)
In-Reply-To: <20180503061049.GJ6795@fergus.ozlabs.ibm.com>
On Thu, May 03, 2018 at 04:10:49PM +1000, Paul Mackerras wrote:
> On Wed, Apr 25, 2018 at 07:54:42PM +0800, wei.guo.simon@gmail.com wrote:
> > From: Simon Guo <wei.guo.simon@gmail.com>
> >
> > This patch reconstructs LOAD_FP/STORE_FP instruction MMIO emulation with
> > analyse_intr() input. It utilizes the FPCONV/UPDATE properties exported by
> > analyse_instr() and invokes kvmppc_handle_load(s)/kvmppc_handle_store()
> > accordingly.
> >
> > The FP regs need to be flushed so that the right FP reg vals can be read
> > from vcpu->arch.fpr.
>
> This only applies for store instructions; it would be clearer if you
> said that explicitly.
I will correct this message.
>
> >
> > Suggested-by: Paul Mackerras <paulus@ozlabs.org>
> > Signed-off-by: Simon Guo <wei.guo.simon@gmail.com>
>
> Same comment about updating RA as for the other patches. Otherwise
> this looks fine.
>
> Paul.
Thanks,
- Simon
next prev parent reply other threads:[~2018-05-03 9:25 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 11:54 [PATCH 00/11] KVM: PPC: reconstruct mmio emulation with analyse_instr() wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-04-25 11:54 ` [PATCH 01/11] KVM: PPC: add pt_regs into kvm_vcpu_arch and move vcpu->arch.gpr[] into it wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-04-27 3:47 ` kbuild test robot
2018-04-27 3:47 ` kbuild test robot
2018-04-27 3:47 ` kbuild test robot
2018-04-27 10:21 ` Simon Guo
2018-04-27 10:21 ` Simon Guo
2018-04-27 10:21 ` Simon Guo
2018-05-03 5:34 ` Paul Mackerras
2018-05-03 5:34 ` Paul Mackerras
2018-05-03 5:34 ` Paul Mackerras
2018-05-03 7:43 ` Simon Guo
2018-05-03 7:43 ` Simon Guo
2018-05-03 7:43 ` Simon Guo
2018-04-25 11:54 ` [PATCH 02/11] KVM: PPC: mov nip/ctr/lr/xer registers to pt_regs in kvm_vcpu_arch wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-05-03 5:46 ` Paul Mackerras
2018-05-03 5:46 ` Paul Mackerras
2018-05-03 5:46 ` Paul Mackerras
2018-05-03 7:51 ` Simon Guo
2018-05-03 7:51 ` Simon Guo
2018-05-03 7:51 ` Simon Guo
2018-04-25 11:54 ` [PATCH 03/11] KVM: PPC: Fix a mmio_host_swabbed uninitialized usage issue when VMX store wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-05-03 5:48 ` Paul Mackerras
2018-05-03 5:48 ` Paul Mackerras
2018-05-03 5:48 ` Paul Mackerras
2018-05-03 7:52 ` Simon Guo
2018-05-03 7:52 ` Simon Guo
2018-05-03 7:52 ` Simon Guo
2018-04-25 11:54 ` [PATCH 04/11] KVM: PPC: fix incorrect element_size for stxsiwx in analyse_instr wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-05-03 5:50 ` Paul Mackerras
2018-05-03 5:50 ` Paul Mackerras
2018-05-03 5:50 ` Paul Mackerras
2018-05-03 9:05 ` Simon Guo
2018-05-03 9:05 ` Simon Guo
2018-05-03 9:05 ` Simon Guo
2018-04-25 11:54 ` [PATCH 05/11] KVM: PPC: add GPR RA update skeleton for MMIO emulation wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-05-03 5:58 ` Paul Mackerras
2018-05-03 5:58 ` Paul Mackerras
2018-05-03 5:58 ` Paul Mackerras
2018-05-03 8:37 ` Simon Guo
2018-05-03 8:37 ` Simon Guo
2018-05-03 8:37 ` Simon Guo
2018-04-25 11:54 ` [PATCH 06/11] KVM: PPC: add KVMPPC_VSX_COPY_WORD_LOAD_DUMP type support for mmio emulation wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-05-03 5:59 ` Paul Mackerras
2018-05-03 5:59 ` Paul Mackerras
2018-05-03 5:59 ` Paul Mackerras
2018-04-25 11:54 ` [PATCH 07/11] KVM: PPC: reconstruct non-SIMD LOAD/STORE instruction mmio emulation with analyse_intr wei.guo.simon
2018-04-25 11:54 ` [PATCH 07/11] KVM: PPC: reconstruct non-SIMD LOAD/STORE instruction mmio emulation with analyse_intr() input wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-05-03 6:03 ` [PATCH 07/11] KVM: PPC: reconstruct non-SIMD LOAD/STORE instruction mmio emulation with analyse_ Paul Mackerras
2018-05-03 6:03 ` [PATCH 07/11] KVM: PPC: reconstruct non-SIMD LOAD/STORE instruction mmio emulation with analyse_intr() input Paul Mackerras
2018-05-03 6:03 ` Paul Mackerras
2018-05-03 9:07 ` [PATCH 07/11] KVM: PPC: reconstruct non-SIMD LOAD/STORE instruction mmio emulation with analyse_ Simon Guo
2018-05-03 9:07 ` [PATCH 07/11] KVM: PPC: reconstruct non-SIMD LOAD/STORE instruction mmio emulation with analyse_intr() input Simon Guo
2018-05-03 9:07 ` Simon Guo
2018-04-25 11:54 ` [PATCH 08/11] KVM: PPC: add giveup_ext() hook for PPC KVM ops wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-05-03 6:08 ` Paul Mackerras
2018-05-03 6:08 ` Paul Mackerras
2018-05-03 6:08 ` Paul Mackerras
2018-05-03 9:21 ` Simon Guo
2018-05-03 9:21 ` Simon Guo
2018-05-03 9:21 ` Simon Guo
2018-04-25 11:54 ` [PATCH 09/11] KVM: PPC: reconstruct LOAD_FP/STORE_FP instruction mmio emulation with analyse_intr() wei.guo.simon
2018-04-25 11:54 ` [PATCH 09/11] KVM: PPC: reconstruct LOAD_FP/STORE_FP instruction mmio emulation with analyse_intr() input wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-05-03 6:10 ` [PATCH 09/11] KVM: PPC: reconstruct LOAD_FP/STORE_FP instruction mmio emulation with analyse_int Paul Mackerras
2018-05-03 6:10 ` [PATCH 09/11] KVM: PPC: reconstruct LOAD_FP/STORE_FP instruction mmio emulation with analyse_intr() input Paul Mackerras
2018-05-03 6:10 ` Paul Mackerras
2018-05-03 9:25 ` Simon Guo [this message]
2018-05-03 9:25 ` Simon Guo
2018-05-03 9:25 ` Simon Guo
2018-04-25 11:54 ` [PATCH 10/11] KVM: PPC: reconstruct LOAD_VMX/STORE_VMX instruction mmio emulation with analyse_intr( wei.guo.simon
2018-04-25 11:54 ` [PATCH 10/11] KVM: PPC: reconstruct LOAD_VMX/STORE_VMX instruction mmio emulation with analyse_intr() input wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-05-03 6:17 ` [PATCH 10/11] KVM: PPC: reconstruct LOAD_VMX/STORE_VMX instruction mmio emulation with analyse_i Paul Mackerras
2018-05-03 6:17 ` [PATCH 10/11] KVM: PPC: reconstruct LOAD_VMX/STORE_VMX instruction mmio emulation with analyse_intr() input Paul Mackerras
2018-05-03 6:17 ` Paul Mackerras
2018-05-03 9:43 ` [PATCH 10/11] KVM: PPC: reconstruct LOAD_VMX/STORE_VMX instruction mmio emulation with analyse_i Simon Guo
2018-05-03 9:43 ` [PATCH 10/11] KVM: PPC: reconstruct LOAD_VMX/STORE_VMX instruction mmio emulation with analyse_intr() input Simon Guo
2018-05-03 9:43 ` Simon Guo
2018-04-25 11:54 ` [PATCH 11/11] KVM: PPC: reconstruct LOAD_VSX/STORE_VSX instruction mmio emulation with analyse_intr( wei.guo.simon
2018-04-25 11:54 ` [PATCH 11/11] KVM: PPC: reconstruct LOAD_VSX/STORE_VSX instruction mmio emulation with analyse_intr() input wei.guo.simon
2018-04-25 11:54 ` wei.guo.simon
2018-05-03 6:26 ` [PATCH 11/11] KVM: PPC: reconstruct LOAD_VSX/STORE_VSX instruction mmio emulation with analyse_i Paul Mackerras
2018-05-03 6:26 ` [PATCH 11/11] KVM: PPC: reconstruct LOAD_VSX/STORE_VSX instruction mmio emulation with analyse_intr() input Paul Mackerras
2018-05-03 6:26 ` Paul Mackerras
2018-05-03 9:46 ` [PATCH 11/11] KVM: PPC: reconstruct LOAD_VSX/STORE_VSX instruction mmio emulation with analyse_i Simon Guo
2018-05-03 9:46 ` [PATCH 11/11] KVM: PPC: reconstruct LOAD_VSX/STORE_VSX instruction mmio emulation with analyse_intr() input Simon Guo
2018-05-03 9:46 ` Simon Guo
2018-05-03 5:31 ` [PATCH 00/11] KVM: PPC: reconstruct mmio emulation with analyse_instr() Paul Mackerras
2018-05-03 5:31 ` Paul Mackerras
2018-05-03 5:31 ` Paul Mackerras
2018-05-03 7:41 ` Simon Guo
2018-05-03 7:41 ` Simon Guo
2018-05-03 7:41 ` Simon Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503092515.GI6755@simonLocalRHEL7.x64 \
--to=wei.guo.simon@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.