All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 3/6] ARM: dts: imx6sx-sabreauto: add IO expander max7310 support
Date: Fri, 4 May 2018 15:50:28 +0800	[thread overview]
Message-ID: <20180504075027.GY3443@dragon> (raw)
In-Reply-To: <1524725898-27974-3-git-send-email-Anson.Huang@nxp.com>

On Thu, Apr 26, 2018 at 02:58:15PM +0800, Anson Huang wrote:
> i.MX6SX Sabre Auto board has two max7310 IO expander
> on I2C3 bus, add support for them.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> no changes since V4.
>  arch/arm/boot/dts/imx6sx-sabreauto.dts | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index d59084f..812f40b 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -82,6 +82,13 @@
>  			>;
>  		};
>  
> +		pinctrl_i2c3_2: i2c3grp-2 {

Drop suffix number '2'.

Shawn

> +			fsl,pins = <
> +				MX6SX_PAD_KEY_ROW4__I2C3_SDA            0x4001b8b1
> +				MX6SX_PAD_KEY_COL4__I2C3_SCL            0x4001b8b1
> +			>;
> +		};
> +
>  		pinctrl_uart1: uart1grp {
>  			fsl,pins = <
>  				MX6SX_PAD_GPIO1_IO04__UART1_TX		0x1b0b1
> @@ -272,3 +279,24 @@
>  		};
>  	};
>  };
> +
> +&i2c3 {
> +	clock-frequency = <100000>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c3_2>;
> +	status = "okay";
> +
> +	max7310_a: gpio at 30 {
> +		compatible = "maxim,max7310";
> +		reg = <0x30>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +
> +	max7310_b: gpio at 32 {
> +		compatible = "maxim,max7310";
> +		reg = <0x32>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +};
> -- 
> 2.7.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: kernel@pengutronix.de, fabio.estevam@nxp.com, robh+dt@kernel.org,
	mark.rutland@arm.com, linux@armlinux.org.uk, Linux-imx@nxp.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 3/6] ARM: dts: imx6sx-sabreauto: add IO expander max7310 support
Date: Fri, 4 May 2018 15:50:28 +0800	[thread overview]
Message-ID: <20180504075027.GY3443@dragon> (raw)
In-Reply-To: <1524725898-27974-3-git-send-email-Anson.Huang@nxp.com>

On Thu, Apr 26, 2018 at 02:58:15PM +0800, Anson Huang wrote:
> i.MX6SX Sabre Auto board has two max7310 IO expander
> on I2C3 bus, add support for them.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> no changes since V4.
>  arch/arm/boot/dts/imx6sx-sabreauto.dts | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index d59084f..812f40b 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -82,6 +82,13 @@
>  			>;
>  		};
>  
> +		pinctrl_i2c3_2: i2c3grp-2 {

Drop suffix number '2'.

Shawn

> +			fsl,pins = <
> +				MX6SX_PAD_KEY_ROW4__I2C3_SDA            0x4001b8b1
> +				MX6SX_PAD_KEY_COL4__I2C3_SCL            0x4001b8b1
> +			>;
> +		};
> +
>  		pinctrl_uart1: uart1grp {
>  			fsl,pins = <
>  				MX6SX_PAD_GPIO1_IO04__UART1_TX		0x1b0b1
> @@ -272,3 +279,24 @@
>  		};
>  	};
>  };
> +
> +&i2c3 {
> +	clock-frequency = <100000>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c3_2>;
> +	status = "okay";
> +
> +	max7310_a: gpio@30 {
> +		compatible = "maxim,max7310";
> +		reg = <0x30>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +
> +	max7310_b: gpio@32 {
> +		compatible = "maxim,max7310";
> +		reg = <0x32>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +};
> -- 
> 2.7.4
> 

  reply	other threads:[~2018-05-04  7:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26  6:58 [PATCH V5 1/6] ARM: dts: imx6sx-sabreauto: add PMIC support Anson Huang
2018-04-26  6:58 ` Anson Huang
2018-04-26  6:58 ` [PATCH V5 2/6] ARM: dts: imx6sx-sabreauto: add max7322 IO expander support Anson Huang
2018-04-26  6:58   ` Anson Huang
2018-05-04  7:48   ` Shawn Guo
2018-05-04  7:48     ` Shawn Guo
2018-04-26  6:58 ` [PATCH V5 3/6] ARM: dts: imx6sx-sabreauto: add IO expander max7310 support Anson Huang
2018-04-26  6:58   ` Anson Huang
2018-05-04  7:50   ` Shawn Guo [this message]
2018-05-04  7:50     ` Shawn Guo
2018-04-26  6:58 ` [PATCH V5 4/6] ARM: dts: imx6sx-sabreauto: add fec support Anson Huang
2018-04-26  6:58   ` Anson Huang
2018-04-26  6:58 ` [PATCH V5 5/6] ARM: dts: imx6sx-sabreauto: add wdog external reset support Anson Huang
2018-04-26  6:58   ` Anson Huang
2018-04-26  6:58 ` [PATCH V5 6/6] ARM: imx_v6_v7_defconfig: Select CONFIG_GPIO_MAX732X by default Anson Huang
2018-04-26  6:58   ` Anson Huang
2018-05-04  9:05   ` Shawn Guo
2018-05-04  9:05     ` Shawn Guo
2018-05-04  7:46 ` [PATCH V5 1/6] ARM: dts: imx6sx-sabreauto: add PMIC support Shawn Guo
2018-05-04  7:46   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180504075027.GY3443@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.