All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tursulin@ursulin.net>
To: igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH i-g-t 3/9] trace.pl: Remove context squashing option
Date: Thu, 10 May 2018 11:19:18 +0100	[thread overview]
Message-ID: <20180510101924.20814-3-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20180510101924.20814-1-tvrtko.ursulin@linux.intel.com>

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Timeline id allocation order is not tied with engine ids any more.

Remove the option which assumed that was the case in attempt to provide
more readable timeline.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 scripts/media-bench.pl |  2 +-
 scripts/trace.pl       | 18 ------------------
 2 files changed, 1 insertion(+), 19 deletions(-)

diff --git a/scripts/media-bench.pl b/scripts/media-bench.pl
index c07555b0dc74..375844d9cdf6 100755
--- a/scripts/media-bench.pl
+++ b/scripts/media-bench.pl
@@ -207,7 +207,7 @@ sub trace_workload
 	show_cmd($cmd);
 	system($cmd);
 
-	$cmd = "perf script | $tracepl --html -x ctxsave -s -c --squash-ctx-id ";
+	$cmd = "perf script | $tracepl --html -x ctxsave -s -c ";
 	$cmd .= join ' ', map("-i $_", @skip_engine);
 	$cmd .= " > ${file}.html";
 	show_cmd($cmd);
diff --git a/scripts/trace.pl b/scripts/trace.pl
index 7f181a3fa2f5..fae94d5044ef 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -38,7 +38,6 @@ my %skip_box;
 my $html = 0;
 my $trace = 0;
 my $avg_delay_stats = 0;
-my $squash_context_id = 0;
 my $gpu_timeline = 0;
 my $colour_contexts = 0;
 
@@ -108,8 +107,6 @@ Usage:
       --html				Generate HTML output.
       --trace cmd			Trace the following command.
       --avg-delay-stats			Print average delay stats.
-      --squash-ctx-id			Squash context id by substracting engine
-					id from ctx id.
       --gpu-timeline			Draw overall GPU busy timeline.
       --colour-contexts / -c		Use different colours for different
 					context execution boxes.
@@ -145,18 +142,6 @@ sub arg_avg_delay_stats
 	return @_;
 }
 
-sub arg_squash_ctx_id
-{
-	return unless scalar(@_);
-
-	if ($_[0] eq '--squash-ctx-id') {
-		shift @_;
-		$squash_context_id = 1;
-	}
-
-	return @_;
-}
-
 sub arg_gpu_timeline
 {
 	return unless scalar(@_);
@@ -303,7 +288,6 @@ while (@args) {
 	@args = arg_help(@args);
 	@args = arg_html(@args);
 	@args = arg_avg_delay_stats(@args);
-	@args = arg_squash_ctx_id(@args);
 	@args = arg_gpu_timeline(@args);
 	@args = arg_trace(@args);
 	@args = arg_max_items(@args);
@@ -338,8 +322,6 @@ sub sanitize_ctx
 {
 	my ($ctx, $ring) = @_;
 
-	$ctx = $ctx - $ring if $squash_context_id;
-
 	if (exists $ctxdb{$ctx}) {
 		return $ctx . '.' . $ctxdb{$ctx};
 	} else {
-- 
2.14.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tursulin@ursulin.net>
To: igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t 3/9] trace.pl: Remove context squashing option
Date: Thu, 10 May 2018 11:19:18 +0100	[thread overview]
Message-ID: <20180510101924.20814-3-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20180510101924.20814-1-tvrtko.ursulin@linux.intel.com>

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Timeline id allocation order is not tied with engine ids any more.

Remove the option which assumed that was the case in attempt to provide
more readable timeline.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 scripts/media-bench.pl |  2 +-
 scripts/trace.pl       | 18 ------------------
 2 files changed, 1 insertion(+), 19 deletions(-)

diff --git a/scripts/media-bench.pl b/scripts/media-bench.pl
index c07555b0dc74..375844d9cdf6 100755
--- a/scripts/media-bench.pl
+++ b/scripts/media-bench.pl
@@ -207,7 +207,7 @@ sub trace_workload
 	show_cmd($cmd);
 	system($cmd);
 
-	$cmd = "perf script | $tracepl --html -x ctxsave -s -c --squash-ctx-id ";
+	$cmd = "perf script | $tracepl --html -x ctxsave -s -c ";
 	$cmd .= join ' ', map("-i $_", @skip_engine);
 	$cmd .= " > ${file}.html";
 	show_cmd($cmd);
diff --git a/scripts/trace.pl b/scripts/trace.pl
index 7f181a3fa2f5..fae94d5044ef 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -38,7 +38,6 @@ my %skip_box;
 my $html = 0;
 my $trace = 0;
 my $avg_delay_stats = 0;
-my $squash_context_id = 0;
 my $gpu_timeline = 0;
 my $colour_contexts = 0;
 
@@ -108,8 +107,6 @@ Usage:
       --html				Generate HTML output.
       --trace cmd			Trace the following command.
       --avg-delay-stats			Print average delay stats.
-      --squash-ctx-id			Squash context id by substracting engine
-					id from ctx id.
       --gpu-timeline			Draw overall GPU busy timeline.
       --colour-contexts / -c		Use different colours for different
 					context execution boxes.
@@ -145,18 +142,6 @@ sub arg_avg_delay_stats
 	return @_;
 }
 
-sub arg_squash_ctx_id
-{
-	return unless scalar(@_);
-
-	if ($_[0] eq '--squash-ctx-id') {
-		shift @_;
-		$squash_context_id = 1;
-	}
-
-	return @_;
-}
-
 sub arg_gpu_timeline
 {
 	return unless scalar(@_);
@@ -303,7 +288,6 @@ while (@args) {
 	@args = arg_help(@args);
 	@args = arg_html(@args);
 	@args = arg_avg_delay_stats(@args);
-	@args = arg_squash_ctx_id(@args);
 	@args = arg_gpu_timeline(@args);
 	@args = arg_trace(@args);
 	@args = arg_max_items(@args);
@@ -338,8 +322,6 @@ sub sanitize_ctx
 {
 	my ($ctx, $ring) = @_;
 
-	$ctx = $ctx - $ring if $squash_context_id;
-
 	if (exists $ctxdb{$ctx}) {
 		return $ctx . '.' . $ctxdb{$ctx};
 	} else {
-- 
2.14.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-05-10 10:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 10:19 [igt-dev] [PATCH i-g-t 1/9] trace.pl: Add support for colouring context execution Tvrtko Ursulin
2018-05-10 10:19 ` Tvrtko Ursulin
2018-05-10 10:19 ` [igt-dev] [PATCH i-g-t 2/9] trace.pl: Improve readability of graphical timeline representation Tvrtko Ursulin
2018-05-10 10:19   ` Tvrtko Ursulin
2018-05-18 18:14   ` [igt-dev] " John Harrison
2018-05-22 11:14     ` [Intel-gfx] [PATCH i-g-t v2 " Tvrtko Ursulin
2018-05-22 11:14       ` Tvrtko Ursulin
2018-05-10 10:19 ` Tvrtko Ursulin [this message]
2018-05-10 10:19   ` [PATCH i-g-t 3/9] trace.pl: Remove context squashing option Tvrtko Ursulin
2018-05-18 18:41   ` [igt-dev] " John Harrison
2018-05-10 10:19 ` [igt-dev] [PATCH i-g-t 4/9] trace.pl: Fix engine busy accounting in split mode Tvrtko Ursulin
2018-05-10 10:19   ` Tvrtko Ursulin
2018-05-10 10:19 ` [igt-dev] [PATCH i-g-t 5/9] trace.pl: Skip drawing very short boxes Tvrtko Ursulin
2018-05-10 10:19   ` Tvrtko Ursulin
2018-05-10 10:19 ` [igt-dev] [PATCH i-g-t 6/9] trace.pl: Context save only applies to last request of a bunch Tvrtko Ursulin
2018-05-10 10:19   ` Tvrtko Ursulin
2018-05-10 10:19 ` [igt-dev] [PATCH i-g-t 7/9] trace.pl: Fix incomplete request handling Tvrtko Ursulin
2018-05-10 10:19   ` Tvrtko Ursulin
2018-05-10 10:19 ` [igt-dev] [PATCH i-g-t 8/9] trace.pl: Basic preemption support Tvrtko Ursulin
2018-05-10 10:19   ` Tvrtko Ursulin
2018-05-10 10:19 ` [igt-dev] [PATCH i-g-t 9/9] trace.pl: Fix request split mode Tvrtko Ursulin
2018-05-10 10:19   ` Tvrtko Ursulin
2018-05-10 10:46 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] trace.pl: Add support for colouring context execution Patchwork
2018-05-10 11:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-05-18 18:22 ` [igt-dev] [PATCH i-g-t 1/9] " John Harrison
2018-05-22 16:51 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] trace.pl: Add support for colouring context execution (rev2) Patchwork
2018-05-22 21:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180510101924.20814-3-tvrtko.ursulin@linux.intel.com \
    --to=tursulin@ursulin.net \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.