From: Tvrtko Ursulin <tursulin@ursulin.net>
To: igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [igt-dev] [PATCH i-g-t 6/9] trace.pl: Context save only applies to last request of a bunch
Date: Thu, 10 May 2018 11:19:21 +0100 [thread overview]
Message-ID: <20180510101924.20814-6-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20180510101924.20814-1-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Skip accounting the context save time for anything but the last request of
the coalesced bunch, and also skip drawing those boxes on the timeline.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
scripts/trace.pl | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/scripts/trace.pl b/scripts/trace.pl
index d92b338ba507..a10de11de01a 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -597,7 +597,11 @@ foreach my $key (@sorted_keys) {
$max_ctx = $db{$key}->{'ctx'} if not defined $max_ctx or
$db{$key}->{'ctx'} > $max_ctx;
- $db{$key}->{'context-complete-delay'} = $end - $notify;
+ unless (exists $db{$key}->{'no-end'}) {
+ $db{$key}->{'context-complete-delay'} = $end - $notify;
+ } else {
+ $db{$key}->{'context-complete-delay'} = 0;
+ }
$db{$key}->{'execute-delay'} = $start - $db{$key}->{'submit'};
$db{$key}->{'submit-delay'} = $db{$key}->{'submit'} - $db{$key}->{'queue'};
$db{$key}->{'duration'} = $notify - $start;
@@ -614,7 +618,7 @@ foreach my $key (@sorted_keys) {
$submit_avg{$ring} += $db{$key}->{'submit-delay'};
$execute_avg{$ring} += $db{$key}->{'execute-delay'};
- $ctxsave_avg{$ring} += $end - $notify;
+ $ctxsave_avg{$ring} += $db{$key}->{'context-complete-delay'};
}
foreach my $ring (sort keys %batch_avg) {
@@ -949,7 +953,8 @@ foreach my $key (sort sortQueue keys %db) {
# user interrupt to context complete
$duration = $end - $notify;
- unless (exists $skip_box{'ctxsave'} or $duration < $min_duration) {
+ unless (exists $skip_box{'ctxsave'} or $duration < $min_duration or
+ exists $db{$key}->{'no-end'}) {
$skey = -2 * $max_seqno * $ctx - 2 * $seqno;
$style = 'color: black; background-color: orange;';
my $ctxsave = $db{$key}->{'end'} - $db{$key}->{'notify'};
--
2.14.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tursulin@ursulin.net>
To: igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t 6/9] trace.pl: Context save only applies to last request of a bunch
Date: Thu, 10 May 2018 11:19:21 +0100 [thread overview]
Message-ID: <20180510101924.20814-6-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20180510101924.20814-1-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Skip accounting the context save time for anything but the last request of
the coalesced bunch, and also skip drawing those boxes on the timeline.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
scripts/trace.pl | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/scripts/trace.pl b/scripts/trace.pl
index d92b338ba507..a10de11de01a 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -597,7 +597,11 @@ foreach my $key (@sorted_keys) {
$max_ctx = $db{$key}->{'ctx'} if not defined $max_ctx or
$db{$key}->{'ctx'} > $max_ctx;
- $db{$key}->{'context-complete-delay'} = $end - $notify;
+ unless (exists $db{$key}->{'no-end'}) {
+ $db{$key}->{'context-complete-delay'} = $end - $notify;
+ } else {
+ $db{$key}->{'context-complete-delay'} = 0;
+ }
$db{$key}->{'execute-delay'} = $start - $db{$key}->{'submit'};
$db{$key}->{'submit-delay'} = $db{$key}->{'submit'} - $db{$key}->{'queue'};
$db{$key}->{'duration'} = $notify - $start;
@@ -614,7 +618,7 @@ foreach my $key (@sorted_keys) {
$submit_avg{$ring} += $db{$key}->{'submit-delay'};
$execute_avg{$ring} += $db{$key}->{'execute-delay'};
- $ctxsave_avg{$ring} += $end - $notify;
+ $ctxsave_avg{$ring} += $db{$key}->{'context-complete-delay'};
}
foreach my $ring (sort keys %batch_avg) {
@@ -949,7 +953,8 @@ foreach my $key (sort sortQueue keys %db) {
# user interrupt to context complete
$duration = $end - $notify;
- unless (exists $skip_box{'ctxsave'} or $duration < $min_duration) {
+ unless (exists $skip_box{'ctxsave'} or $duration < $min_duration or
+ exists $db{$key}->{'no-end'}) {
$skey = -2 * $max_seqno * $ctx - 2 * $seqno;
$style = 'color: black; background-color: orange;';
my $ctxsave = $db{$key}->{'end'} - $db{$key}->{'notify'};
--
2.14.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-10 10:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 10:19 [igt-dev] [PATCH i-g-t 1/9] trace.pl: Add support for colouring context execution Tvrtko Ursulin
2018-05-10 10:19 ` Tvrtko Ursulin
2018-05-10 10:19 ` [igt-dev] [PATCH i-g-t 2/9] trace.pl: Improve readability of graphical timeline representation Tvrtko Ursulin
2018-05-10 10:19 ` Tvrtko Ursulin
2018-05-18 18:14 ` [igt-dev] " John Harrison
2018-05-22 11:14 ` [Intel-gfx] [PATCH i-g-t v2 " Tvrtko Ursulin
2018-05-22 11:14 ` Tvrtko Ursulin
2018-05-10 10:19 ` [Intel-gfx] [PATCH i-g-t 3/9] trace.pl: Remove context squashing option Tvrtko Ursulin
2018-05-10 10:19 ` Tvrtko Ursulin
2018-05-18 18:41 ` [igt-dev] " John Harrison
2018-05-10 10:19 ` [igt-dev] [PATCH i-g-t 4/9] trace.pl: Fix engine busy accounting in split mode Tvrtko Ursulin
2018-05-10 10:19 ` Tvrtko Ursulin
2018-05-10 10:19 ` [igt-dev] [PATCH i-g-t 5/9] trace.pl: Skip drawing very short boxes Tvrtko Ursulin
2018-05-10 10:19 ` Tvrtko Ursulin
2018-05-10 10:19 ` Tvrtko Ursulin [this message]
2018-05-10 10:19 ` [PATCH i-g-t 6/9] trace.pl: Context save only applies to last request of a bunch Tvrtko Ursulin
2018-05-10 10:19 ` [igt-dev] [PATCH i-g-t 7/9] trace.pl: Fix incomplete request handling Tvrtko Ursulin
2018-05-10 10:19 ` Tvrtko Ursulin
2018-05-10 10:19 ` [igt-dev] [PATCH i-g-t 8/9] trace.pl: Basic preemption support Tvrtko Ursulin
2018-05-10 10:19 ` Tvrtko Ursulin
2018-05-10 10:19 ` [igt-dev] [PATCH i-g-t 9/9] trace.pl: Fix request split mode Tvrtko Ursulin
2018-05-10 10:19 ` Tvrtko Ursulin
2018-05-10 10:46 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] trace.pl: Add support for colouring context execution Patchwork
2018-05-10 11:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-05-18 18:22 ` [igt-dev] [PATCH i-g-t 1/9] " John Harrison
2018-05-22 16:51 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] trace.pl: Add support for colouring context execution (rev2) Patchwork
2018-05-22 21:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2018-07-12 10:59 [igt-dev] [PATCH i-g-t 0/9] trace.pl fixes and improvements Tvrtko Ursulin
2018-07-12 10:59 ` [igt-dev] [PATCH i-g-t 6/9] trace.pl: Context save only applies to last request of a bunch Tvrtko Ursulin
2018-07-13 6:55 ` John Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510101924.20814-6-tvrtko.ursulin@linux.intel.com \
--to=tursulin@ursulin.net \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.