From: Eduardo Habkost <ehabkost@redhat.com>
To: Babu Moger <babu.moger@amd.com>
Cc: geoff@hostfission.com, kvm@vger.kernel.org, mst@redhat.com,
kash@tripleback.net, mtosatti@redhat.com, qemu-devel@nongnu.org,
pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [PATCH v8 1/8] i386: Helpers to encode cache information consistently
Date: Fri, 11 May 2018 16:12:11 -0300 [thread overview]
Message-ID: <20180511191211.GU25013@localhost.localdomain> (raw)
In-Reply-To: <20180510204148.11687-2-babu.moger@amd.com>
On Thu, May 10, 2018 at 03:41:41PM -0500, Babu Moger wrote:
> From: Eduardo Habkost <ehabkost@redhat.com>
>
> Instead of having a collection of macros that need to be used in
> complex expressions to build CPUID data, define a CPUCacheInfo
> struct that can hold information about a given cache. Helper
> functions will take a CPUCacheInfo struct as input to encode
> CPUID leaves for a cache.
>
> This will help us ensure consistency between cache information
> CPUID leaves, and make the existing inconsistencies in CPUID info
> more visible.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> Tested-by: Geoffrey McRae <geoff@hostfission.com>
CPUID compatibility is now being kept.
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Queued, thanks.
--
Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Babu Moger <babu.moger@amd.com>
Cc: mst@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com,
rth@twiddle.net, mtosatti@redhat.com, qemu-devel@nongnu.org,
kvm@vger.kernel.org, geoff@hostfission.com, kash@tripleback.net
Subject: Re: [Qemu-devel] [PATCH v8 1/8] i386: Helpers to encode cache information consistently
Date: Fri, 11 May 2018 16:12:11 -0300 [thread overview]
Message-ID: <20180511191211.GU25013@localhost.localdomain> (raw)
In-Reply-To: <20180510204148.11687-2-babu.moger@amd.com>
On Thu, May 10, 2018 at 03:41:41PM -0500, Babu Moger wrote:
> From: Eduardo Habkost <ehabkost@redhat.com>
>
> Instead of having a collection of macros that need to be used in
> complex expressions to build CPUID data, define a CPUCacheInfo
> struct that can hold information about a given cache. Helper
> functions will take a CPUCacheInfo struct as input to encode
> CPUID leaves for a cache.
>
> This will help us ensure consistency between cache information
> CPUID leaves, and make the existing inconsistencies in CPUID info
> more visible.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> Tested-by: Geoffrey McRae <geoff@hostfission.com>
CPUID compatibility is now being kept.
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Queued, thanks.
--
Eduardo
next prev parent reply other threads:[~2018-05-11 19:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 20:41 [PATCH v8 0/8] i386: Enable TOPOEXT to support hyperthreading on AMD CPU Babu Moger
2018-05-10 20:41 ` [Qemu-devel] " Babu Moger
2018-05-10 20:41 ` [PATCH v8 1/8] i386: Helpers to encode cache information consistently Babu Moger
2018-05-10 20:41 ` [Qemu-devel] " Babu Moger
2018-05-11 19:12 ` Eduardo Habkost [this message]
2018-05-11 19:12 ` Eduardo Habkost
2018-07-16 13:20 ` Philippe Mathieu-Daudé
2018-07-16 19:52 ` Eduardo Habkost
2018-07-17 15:42 ` Philippe Mathieu-Daudé
2018-05-10 20:41 ` [PATCH v8 2/8] i386: Add cache information in X86CPUDefinition Babu Moger
2018-05-10 20:41 ` [Qemu-devel] " Babu Moger
2018-05-10 20:41 ` [PATCH v8 3/8] i386: Add new property to control cache info Babu Moger
2018-05-10 20:41 ` [Qemu-devel] " Babu Moger
2018-05-11 19:21 ` Eduardo Habkost
2018-05-11 19:21 ` [Qemu-devel] " Eduardo Habkost
2018-05-11 20:21 ` Moger, Babu
2018-05-11 20:21 ` [Qemu-devel] " Moger, Babu
2018-05-11 20:40 ` Eduardo Habkost
2018-05-11 20:40 ` [Qemu-devel] " Eduardo Habkost
2018-05-11 20:47 ` Eduardo Habkost
2018-05-11 20:47 ` [Qemu-devel] " Eduardo Habkost
2018-05-14 16:44 ` Moger, Babu
2018-05-14 16:44 ` [Qemu-devel] " Moger, Babu
2018-05-10 20:41 ` [PATCH v8 4/8] i386: Initialize cache information for EPYC family processors Babu Moger
2018-05-10 20:41 ` [Qemu-devel] " Babu Moger
2018-05-10 20:41 ` [PATCH v8 5/8] i386: Populate AMD Processor Cache Information for cpuid 0x8000001D Babu Moger
2018-05-10 20:41 ` [Qemu-devel] " Babu Moger
2018-05-10 20:41 ` [PATCH v8 6/8] i386: Add support for CPUID_8000_001E for AMD Babu Moger
2018-05-10 20:41 ` [Qemu-devel] " Babu Moger
2018-05-10 20:41 ` [PATCH v8 7/8] i386: Enable TOPOEXT feature on AMD EPYC CPU Babu Moger
2018-05-10 20:41 ` [Qemu-devel] " Babu Moger
2018-05-11 20:46 ` Eduardo Habkost
2018-05-11 20:46 ` [Qemu-devel] " Eduardo Habkost
2018-05-11 22:16 ` Moger, Babu
2018-05-11 22:16 ` [Qemu-devel] " Moger, Babu
2018-05-10 20:41 ` [PATCH v8 8/8] i386: Remove generic SMT thread check Babu Moger
2018-05-10 20:41 ` [Qemu-devel] " Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511191211.GU25013@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=babu.moger@amd.com \
--cc=geoff@hostfission.com \
--cc=kash@tripleback.net \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.