All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v6 2/9] iomap: Mark newly allocated buffer heads as new
Date: Sat, 2 Jun 2018 18:58:05 +0200	[thread overview]
Message-ID: <20180602165805.GA15847@lst.de> (raw)
In-Reply-To: <20180602095717.31641-3-agruenba@redhat.com>

>  	case IOMAP_MAPPED:
> -		if (offset >= i_size_read(inode))
> +		if ((iomap->flags & IOMAP_F_NEW) || offset >= i_size_read(inode))

Please split the line to stay withing 80 characters.

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>



WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel@redhat.com, Christoph Hellwig <hch@lst.de>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v6 2/9] iomap: Mark newly allocated buffer heads as new
Date: Sat, 2 Jun 2018 18:58:05 +0200	[thread overview]
Message-ID: <20180602165805.GA15847@lst.de> (raw)
In-Reply-To: <20180602095717.31641-3-agruenba@redhat.com>

>  	case IOMAP_MAPPED:
> -		if (offset >= i_size_read(inode))
> +		if ((iomap->flags & IOMAP_F_NEW) || offset >= i_size_read(inode))

Please split the line to stay withing 80 characters.

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2018-06-02 16:58 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-02  9:57 [Cluster-devel] [PATCH v6 0/9] gfs2 iomap write support Andreas Gruenbacher
2018-06-02  9:57 ` Andreas Gruenbacher
2018-06-02  9:57 ` [Cluster-devel] [PATCH v6 1/9] iomap: inline data should be an iomap type, not a flag Andreas Gruenbacher
2018-06-02  9:57   ` Andreas Gruenbacher
2018-06-02  9:57 ` [Cluster-devel] [PATCH v6 2/9] iomap: Mark newly allocated buffer heads as new Andreas Gruenbacher
2018-06-02  9:57   ` Andreas Gruenbacher
2018-06-02 16:58   ` Christoph Hellwig [this message]
2018-06-02 16:58     ` Christoph Hellwig
2018-06-02  9:57 ` [Cluster-devel] [PATCH v6 3/9] iomap: Complete partial direct I/O writes synchronously Andreas Gruenbacher
2018-06-02  9:57   ` Andreas Gruenbacher
2018-06-02 16:58   ` [Cluster-devel] " Christoph Hellwig
2018-06-02 16:58     ` Christoph Hellwig
2018-06-02  9:57 ` [Cluster-devel] [PATCH v6 4/9] iomap: Generic inline data handling Andreas Gruenbacher
2018-06-02  9:57   ` Andreas Gruenbacher
2018-06-02 17:04   ` [Cluster-devel] " Christoph Hellwig
2018-06-02 17:04     ` Christoph Hellwig
2018-06-04 12:02     ` [Cluster-devel] " Andreas Grünbacher
2018-06-04 12:02       ` Andreas Grünbacher
2018-06-04 12:12       ` [Cluster-devel] " Christoph Hellwig
2018-06-04 12:12         ` Christoph Hellwig
2018-06-04 17:01         ` [Cluster-devel] " Andreas Grünbacher
2018-06-04 17:01           ` Andreas Grünbacher
2018-06-02  9:57 ` [Cluster-devel] [PATCH v6 5/9] iomap: Add write_end iomap operation Andreas Gruenbacher
2018-06-02  9:57   ` Andreas Gruenbacher
2018-06-02 17:06   ` [Cluster-devel] " Christoph Hellwig
2018-06-02 17:06     ` Christoph Hellwig
2018-06-04 12:03     ` [Cluster-devel] " Andreas Grünbacher
2018-06-04 12:03       ` Andreas Grünbacher
2018-06-02  9:57 ` [Cluster-devel] [PATCH v6 6/9] gfs2: iomap buffered write support Andreas Gruenbacher
2018-06-02  9:57   ` Andreas Gruenbacher
2018-06-02  9:57 ` [Cluster-devel] [PATCH v6 7/9] gfs2: gfs2_extent_length cleanup Andreas Gruenbacher
2018-06-02  9:57   ` Andreas Gruenbacher
2018-06-02  9:57 ` [Cluster-devel] [PATCH v6 8/9] gfs2: iomap direct I/O support Andreas Gruenbacher
2018-06-02  9:57   ` Andreas Gruenbacher
2018-06-02  9:57 ` [Cluster-devel] [PATCH v6 9/9] gfs2: Remove gfs2_write_{begin, end} Andreas Gruenbacher
2018-06-02  9:57   ` [PATCH v6 9/9] gfs2: Remove gfs2_write_{begin,end} Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180602165805.GA15847@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.