Re: [RFC PATCH 2/2] mtd: m25p80: Use the SPI mem direct API to possibly improve performances

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org, Mark Brown <broonie@kernel.org>,
	linux-spi@vger.kernel.org,
	Cyrille Pitchen <cyrille.pitchen@microchip.com>,
	Vignesh R <vigneshr@ti.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [RFC PATCH 2/2] mtd: m25p80: Use the SPI mem direct API to possibly improve performances
Date: Thu, 7 Jun 2018 17:23:45 +0200	[thread overview]
Message-ID: <20180607172345.507e028e@xps13> (raw)
In-Reply-To: <20180607171846.462e6639@bbrezillon>

Hi Boris,

On Thu, 7 Jun 2018 17:18:46 +0200, Boris Brezillon
<boris.brezillon@bootlin.com> wrote:

> On Thu, 7 Jun 2018 17:08:24 +0200
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> 
> > Hi Boris,
> > 
> > On Fri,  1 Jun 2018 16:36:03 +0200, Boris Brezillon
> > <boris.brezillon@bootlin.com> wrote:
> >   
> > > Make use of the SPI mem direct mapping API.
> > > 
> > > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> > > ---
> > >  drivers/mtd/devices/m25p80.c | 149 ++++++++++++++++++++++++++-----------------
> > >  1 file changed, 89 insertions(+), 60 deletions(-)
> > > 
> > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> > > index 1dd5f0420b5a..285fc94118ae 100644
> > > --- a/drivers/mtd/devices/m25p80.c
> > > +++ b/drivers/mtd/devices/m25p80.c
> > > @@ -31,6 +31,10 @@
> > >  struct m25p {
> > >  	struct spi_mem		*spimem;
> > >  	struct spi_nor		spi_nor;
> > > +	struct {
> > > +		struct spi_mem_dirmap_desc *write;
> > > +		struct spi_mem_dirmap_desc *read;
> > > +	} dirmap;
> > >  };    
> > 
> > While reading this patch I was a bit confused with this naming. You
> > refer these descriptors as 'flash->dirmap->read/write' which is
> > confusing as this is not a function but a descriptor. Passing such
> > variable to a function called spi_meme_dirmap_read/write() is also
> > confusing IMHO (see below).
> > 
> > Would you mind renaming them with something like "read/write_desc"?  
> 
> Sure. How about rdesc and wdesc to keep the names short?
> 

Sure, it's just to avoid having descriptors named after actions .

Miquèl