From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] phy: mapphone-mdm6600: Fix wrong enum used for status lines
Date: Fri, 8 Jun 2018 16:50:55 +0200 [thread overview]
Message-ID: <20180608145055.GA11958@amd> (raw)
In-Reply-To: <20180531170538.32264-1-tony@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]
On Thu 2018-05-31 10:05:38, Tony Lindgren wrote:
> Kbuilt test robot reported:
>
> drivers/phy/motorola/phy-mapphone-mdm6600.c:188:16: warning: is used
> uninitialized in this function [-Wuninitialized]
> val |= values[i] << i;
> ~~~~~~^~~
>
> Looking at the phy_mdm6600_status() values does get initialized by
> gpiod_get_array_value_cansleep(), but we are using wrong enum
> in that function. Let's fix the use, both end up being three though
> so urgent rush on this one AFAIK.
>
> Fixes: 5d1ebbda0318 ("phy: mapphone-mdm6600: Add USB PHY driver for
> MDM6600 on Droid 4")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: phy: mapphone-mdm6600: Fix wrong enum used for status lines
Date: Fri, 8 Jun 2018 16:50:55 +0200 [thread overview]
Message-ID: <20180608145055.GA11958@amd> (raw)
On Thu 2018-05-31 10:05:38, Tony Lindgren wrote:
> Kbuilt test robot reported:
>
> drivers/phy/motorola/phy-mapphone-mdm6600.c:188:16: warning: is used
> uninitialized in this function [-Wuninitialized]
> val |= values[i] << i;
> ~~~~~~^~~
>
> Looking at the phy_mdm6600_status() values does get initialized by
> gpiod_get_array_value_cansleep(), but we are using wrong enum
> in that function. Let's fix the use, both end up being three though
> so urgent rush on this one AFAIK.
>
> Fixes: 5d1ebbda0318 ("phy: mapphone-mdm6600: Add USB PHY driver for
> MDM6600 on Droid 4")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
next prev parent reply other threads:[~2018-06-08 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 17:05 [PATCH] phy: mapphone-mdm6600: Fix wrong enum used for status lines Tony Lindgren
2018-05-31 17:05 ` Tony Lindgren
2018-06-08 14:50 ` Pavel Machek [this message]
2018-06-08 14:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608145055.GA11958@amd \
--to=pavel@ucw.cz \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.