* [virtio-dev] [PATCH] content: enhance device requirements for feature bits
@ 2018-06-08 6:59 Tiwei Bie
2018-06-08 7:36 ` [virtio-dev] " Cornelia Huck
0 siblings, 1 reply; 6+ messages in thread
From: Tiwei Bie @ 2018-06-08 6:59 UTC (permalink / raw)
To: mst, cohuck, stefanha, pbonzini, virtio-dev
Cc: dan.daly, cunming.liang, zhihong.wang
Suggested-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14
---
content.tex | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/content.tex b/content.tex
index f996fad..8374d3f 100644
--- a/content.tex
+++ b/content.tex
@@ -125,6 +125,13 @@ which was not offered. The device SHOULD accept any valid subset
of features the driver accepts, otherwise it MUST fail to set the
FEATURES_OK \field{device status} bit when the driver writes it.
+If a device has successfully negotiated a set of features
+at least once (by setting the FEATURES_OK \field{device
+status} bit when the driver writes it), then it SHOULD NOT
+fail re-negotiation of the same set of features after a
+device or system reset. Failure to do so would interfere
+with the resuming from suspend and error recovery.
+
\subsection{Legacy Interface: A Note on Feature
Bits}\label{sec:Basic Facilities of a Virtio Device / Feature
Bits / Legacy Interface: A Note on Feature Bits}
--
2.17.0
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply related [flat|nested] 6+ messages in thread* [virtio-dev] Re: [PATCH] content: enhance device requirements for feature bits
2018-06-08 6:59 [virtio-dev] [PATCH] content: enhance device requirements for feature bits Tiwei Bie
@ 2018-06-08 7:36 ` Cornelia Huck
2018-06-08 8:00 ` Tiwei Bie
2018-06-08 16:05 ` Michael S. Tsirkin
0 siblings, 2 replies; 6+ messages in thread
From: Cornelia Huck @ 2018-06-08 7:36 UTC (permalink / raw)
To: Tiwei Bie
Cc: mst, stefanha, pbonzini, virtio-dev, dan.daly, cunming.liang,
zhihong.wang
On Fri, 8 Jun 2018 14:59:28 +0800
Tiwei Bie <tiwei.bie@intel.com> wrote:
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14
> ---
> content.tex | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/content.tex b/content.tex
> index f996fad..8374d3f 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -125,6 +125,13 @@ which was not offered. The device SHOULD accept any valid subset
> of features the driver accepts, otherwise it MUST fail to set the
> FEATURES_OK \field{device status} bit when the driver writes it.
>
> +If a device has successfully negotiated a set of features
> +at least once (by setting the FEATURES_OK \field{device
> +status} bit when the driver writes it), then it SHOULD NOT
Hm, it's the driver that sets FEATURES_OK, not the device. What about
"by succeeding to set"?
> +fail re-negotiation of the same set of features after a
> +device or system reset. Failure to do so would interfere
> +with the resuming from suspend and error recovery.
s/the resuming/resuming/
> +
> \subsection{Legacy Interface: A Note on Feature
> Bits}\label{sec:Basic Facilities of a Virtio Device / Feature
> Bits / Legacy Interface: A Note on Feature Bits}
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread* [virtio-dev] Re: [PATCH] content: enhance device requirements for feature bits
2018-06-08 7:36 ` [virtio-dev] " Cornelia Huck
@ 2018-06-08 8:00 ` Tiwei Bie
2018-06-08 16:05 ` Michael S. Tsirkin
1 sibling, 0 replies; 6+ messages in thread
From: Tiwei Bie @ 2018-06-08 8:00 UTC (permalink / raw)
To: Cornelia Huck
Cc: mst, stefanha, pbonzini, virtio-dev, dan.daly, cunming.liang,
zhihong.wang
On Fri, Jun 08, 2018 at 09:36:17AM +0200, Cornelia Huck wrote:
> On Fri, 8 Jun 2018 14:59:28 +0800
> Tiwei Bie <tiwei.bie@intel.com> wrote:
>
> > Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14
> > ---
> > content.tex | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/content.tex b/content.tex
> > index f996fad..8374d3f 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -125,6 +125,13 @@ which was not offered. The device SHOULD accept any valid subset
> > of features the driver accepts, otherwise it MUST fail to set the
> > FEATURES_OK \field{device status} bit when the driver writes it.
> >
> > +If a device has successfully negotiated a set of features
> > +at least once (by setting the FEATURES_OK \field{device
> > +status} bit when the driver writes it), then it SHOULD NOT
>
> Hm, it's the driver that sets FEATURES_OK, not the device. What about
> "by succeeding to set"?
Cool. It's much better!
>
> > +fail re-negotiation of the same set of features after a
> > +device or system reset. Failure to do so would interfere
> > +with the resuming from suspend and error recovery.
>
> s/the resuming/resuming/
Got it.
Thank you for the review and suggestions!
Best regards,
Tiwei Bie
>
> > +
> > \subsection{Legacy Interface: A Note on Feature
> > Bits}\label{sec:Basic Facilities of a Virtio Device / Feature
> > Bits / Legacy Interface: A Note on Feature Bits}
>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread* [virtio-dev] Re: [PATCH] content: enhance device requirements for feature bits
2018-06-08 7:36 ` [virtio-dev] " Cornelia Huck
2018-06-08 8:00 ` Tiwei Bie
@ 2018-06-08 16:05 ` Michael S. Tsirkin
2018-06-11 7:11 ` Cornelia Huck
1 sibling, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2018-06-08 16:05 UTC (permalink / raw)
To: Cornelia Huck
Cc: Tiwei Bie, stefanha, pbonzini, virtio-dev, dan.daly,
cunming.liang, zhihong.wang
On Fri, Jun 08, 2018 at 09:36:17AM +0200, Cornelia Huck wrote:
> On Fri, 8 Jun 2018 14:59:28 +0800
> Tiwei Bie <tiwei.bie@intel.com> wrote:
>
> > Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14
> > ---
> > content.tex | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/content.tex b/content.tex
> > index f996fad..8374d3f 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -125,6 +125,13 @@ which was not offered. The device SHOULD accept any valid subset
> > of features the driver accepts, otherwise it MUST fail to set the
> > FEATURES_OK \field{device status} bit when the driver writes it.
> >
> > +If a device has successfully negotiated a set of features
> > +at least once (by setting the FEATURES_OK \field{device
> > +status} bit when the driver writes it), then it SHOULD NOT
>
> Hm, it's the driver that sets FEATURES_OK, not the device. What about
> "by succeeding to set"?
I think the best terminology we have is
"accept the FEATURES_OK status bit during device initialization"
that's from the mmio chapter.
> > +fail re-negotiation of the same set of features after a
> > +device or system reset. Failure to do so would interfere
> > +with the resuming from suspend and error recovery.
>
> s/the resuming/resuming/
>
> > +
> > \subsection{Legacy Interface: A Note on Feature
> > Bits}\label{sec:Basic Facilities of a Virtio Device / Feature
> > Bits / Legacy Interface: A Note on Feature Bits}
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread* [virtio-dev] Re: [PATCH] content: enhance device requirements for feature bits
2018-06-08 16:05 ` Michael S. Tsirkin
@ 2018-06-11 7:11 ` Cornelia Huck
2018-06-11 7:50 ` Tiwei Bie
0 siblings, 1 reply; 6+ messages in thread
From: Cornelia Huck @ 2018-06-11 7:11 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Tiwei Bie, stefanha, pbonzini, virtio-dev, dan.daly,
cunming.liang, zhihong.wang
On Fri, 8 Jun 2018 19:05:30 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Fri, Jun 08, 2018 at 09:36:17AM +0200, Cornelia Huck wrote:
> > On Fri, 8 Jun 2018 14:59:28 +0800
> > Tiwei Bie <tiwei.bie@intel.com> wrote:
> >
> > > Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> > > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14
> > > ---
> > > content.tex | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/content.tex b/content.tex
> > > index f996fad..8374d3f 100644
> > > --- a/content.tex
> > > +++ b/content.tex
> > > @@ -125,6 +125,13 @@ which was not offered. The device SHOULD accept any valid subset
> > > of features the driver accepts, otherwise it MUST fail to set the
> > > FEATURES_OK \field{device status} bit when the driver writes it.
> > >
> > > +If a device has successfully negotiated a set of features
> > > +at least once (by setting the FEATURES_OK \field{device
> > > +status} bit when the driver writes it), then it SHOULD NOT
> >
> > Hm, it's the driver that sets FEATURES_OK, not the device. What about
> > "by succeeding to set"?
>
> I think the best terminology we have is
> "accept the FEATURES_OK status bit during device initialization"
> that's from the mmio chapter.
Yes, that sounds better.
>
> > > +fail re-negotiation of the same set of features after a
> > > +device or system reset. Failure to do so would interfere
> > > +with the resuming from suspend and error recovery.
> >
> > s/the resuming/resuming/
> >
> > > +
> > > \subsection{Legacy Interface: A Note on Feature
> > > Bits}\label{sec:Basic Facilities of a Virtio Device / Feature
> > > Bits / Legacy Interface: A Note on Feature Bits}
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread* [virtio-dev] Re: [PATCH] content: enhance device requirements for feature bits
2018-06-11 7:11 ` Cornelia Huck
@ 2018-06-11 7:50 ` Tiwei Bie
0 siblings, 0 replies; 6+ messages in thread
From: Tiwei Bie @ 2018-06-11 7:50 UTC (permalink / raw)
To: Cornelia Huck, Michael S. Tsirkin
Cc: stefanha, pbonzini, virtio-dev, dan.daly, cunming.liang,
zhihong.wang
On Mon, Jun 11, 2018 at 09:11:00AM +0200, Cornelia Huck wrote:
> On Fri, 8 Jun 2018 19:05:30 +0300
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Fri, Jun 08, 2018 at 09:36:17AM +0200, Cornelia Huck wrote:
> > > On Fri, 8 Jun 2018 14:59:28 +0800
> > > Tiwei Bie <tiwei.bie@intel.com> wrote:
> > >
> > > > Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> > > > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14
> > > > ---
> > > > content.tex | 7 +++++++
> > > > 1 file changed, 7 insertions(+)
> > > >
> > > > diff --git a/content.tex b/content.tex
> > > > index f996fad..8374d3f 100644
> > > > --- a/content.tex
> > > > +++ b/content.tex
> > > > @@ -125,6 +125,13 @@ which was not offered. The device SHOULD accept any valid subset
> > > > of features the driver accepts, otherwise it MUST fail to set the
> > > > FEATURES_OK \field{device status} bit when the driver writes it.
> > > >
> > > > +If a device has successfully negotiated a set of features
> > > > +at least once (by setting the FEATURES_OK \field{device
> > > > +status} bit when the driver writes it), then it SHOULD NOT
> > >
> > > Hm, it's the driver that sets FEATURES_OK, not the device. What about
> > > "by succeeding to set"?
> >
> > I think the best terminology we have is
> > "accept the FEATURES_OK status bit during device initialization"
> > that's from the mmio chapter.
>
> Yes, that sounds better.
I'll send a new version!
Best regards,
Tiwei Bie
>
> >
> > > > +fail re-negotiation of the same set of features after a
> > > > +device or system reset. Failure to do so would interfere
> > > > +with the resuming from suspend and error recovery.
> > >
> > > s/the resuming/resuming/
> > >
> > > > +
> > > > \subsection{Legacy Interface: A Note on Feature
> > > > Bits}\label{sec:Basic Facilities of a Virtio Device / Feature
> > > > Bits / Legacy Interface: A Note on Feature Bits}
>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-11 7:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-08 6:59 [virtio-dev] [PATCH] content: enhance device requirements for feature bits Tiwei Bie
2018-06-08 7:36 ` [virtio-dev] " Cornelia Huck
2018-06-08 8:00 ` Tiwei Bie
2018-06-08 16:05 ` Michael S. Tsirkin
2018-06-11 7:11 ` Cornelia Huck
2018-06-11 7:50 ` Tiwei Bie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.