From: Cornelia Huck <cohuck@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
patches@linaro.org, "Richard Henderson" <rth@twiddle.net>,
"John Snow" <jsnow@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments
Date: Mon, 11 Jun 2018 16:57:55 +0200 [thread overview]
Message-ID: <20180611165755.64b684c8.cohuck@redhat.com> (raw)
In-Reply-To: <20180611141716.3813-1-peter.maydell@linaro.org>
On Mon, 11 Jun 2018 15:17:16 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:
> The codebase has a bit of a mix of different multiline
> comment styles. State a preference for the Linux kernel
> style:
> /*
> * Star on the left for each line.
> * Leading slash-star and trailing star-slash
> * each go on a line of their own.
> */
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This is not my personal favourite, but seemed to be the
> closest we had to consensus in the mail thread for v1;
> I can live with it in order to avoid getting patches which
> use the styles I like even less :-)
> ---
> CODING_STYLE | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
patches@linaro.org, "Richard Henderson" <rth@twiddle.net>,
"John Snow" <jsnow@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments
Date: Mon, 11 Jun 2018 16:57:55 +0200 [thread overview]
Message-ID: <20180611165755.64b684c8.cohuck@redhat.com> (raw)
In-Reply-To: <20180611141716.3813-1-peter.maydell@linaro.org>
On Mon, 11 Jun 2018 15:17:16 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:
> The codebase has a bit of a mix of different multiline
> comment styles. State a preference for the Linux kernel
> style:
> /*
> * Star on the left for each line.
> * Leading slash-star and trailing star-slash
> * each go on a line of their own.
> */
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This is not my personal favourite, but seemed to be the
> closest we had to consensus in the mail thread for v1;
> I can live with it in order to avoid getting patches which
> use the styles I like even less :-)
> ---
> CODING_STYLE | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2018-06-11 14:58 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 14:17 [Qemu-trivial] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments Peter Maydell
2018-06-11 14:17 ` [Qemu-devel] " Peter Maydell
2018-06-11 14:21 ` [Qemu-trivial] " Eric Blake
2018-06-11 14:21 ` Eric Blake
2018-06-11 14:57 ` Cornelia Huck [this message]
2018-06-11 14:57 ` Cornelia Huck
2018-06-11 16:02 ` [Qemu-trivial] " Markus Armbruster
2018-06-11 16:02 ` Markus Armbruster
2018-06-11 16:15 ` [Qemu-trivial] " Alex Williamson
2018-06-11 16:15 ` [Qemu-devel] " Alex Williamson
2018-06-11 16:40 ` [Qemu-trivial] " Peter Maydell
2018-06-11 16:40 ` [Qemu-devel] " Peter Maydell
2018-06-11 16:49 ` [Qemu-trivial] " Alex Williamson
2018-06-11 16:49 ` [Qemu-devel] " Alex Williamson
2018-06-11 16:24 ` [Qemu-trivial] " Thomas Huth
2018-06-11 16:24 ` [Qemu-devel] " Thomas Huth
2018-06-11 16:31 ` [Qemu-trivial] " John Snow
2018-06-11 16:31 ` John Snow
2018-06-12 17:30 ` [Qemu-trivial] " Richard Henderson
2018-06-12 17:30 ` Richard Henderson
2018-06-12 17:41 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-06-12 17:41 ` Philippe Mathieu-Daudé
2018-06-12 18:12 ` [Qemu-trivial] " Thomas Huth
2018-06-12 18:12 ` Thomas Huth
2018-06-12 18:47 ` [Qemu-trivial] " Alex Williamson
2018-06-12 18:47 ` Alex Williamson
2018-06-13 7:05 ` [Qemu-trivial] " Cornelia Huck
2018-06-13 7:05 ` Cornelia Huck
2018-06-13 12:30 ` [Qemu-trivial] " Peter Maydell
2018-06-13 12:30 ` Peter Maydell
2018-06-13 16:55 ` [Qemu-trivial] " John Snow
2018-06-13 16:55 ` John Snow
2018-06-14 10:46 ` [Qemu-trivial] " Peter Maydell
2018-06-14 10:46 ` Peter Maydell
2018-06-14 20:11 ` [Qemu-trivial] " John Snow
2018-06-14 20:11 ` John Snow
2018-06-15 2:52 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-06-15 2:52 ` Philippe Mathieu-Daudé
2018-06-15 4:43 ` [Qemu-trivial] " Thomas Huth
2018-06-15 4:43 ` Thomas Huth
2018-06-15 8:48 ` [Qemu-trivial] " Peter Maydell
2018-06-15 8:48 ` Peter Maydell
2018-06-15 12:45 ` [Qemu-trivial] " Markus Armbruster
2018-06-15 12:45 ` Markus Armbruster
2018-06-13 13:31 ` [Qemu-trivial] " Stefan Hajnoczi
2018-06-13 13:31 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611165755.64b684c8.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.