From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Daniel Stone <daniels@collabora.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/gma500: Fix compile warning
Date: Tue, 26 Jun 2018 16:28:28 +0300 [thread overview]
Message-ID: <20180626132828.GY20518@intel.com> (raw)
In-Reply-To: <20180625123355.GA16757@embeddedor.com>
On Mon, Jun 25, 2018 at 07:33:55AM -0500, Gustavo A. R. Silva wrote:
> Fix the following compile warning:
>
> warning: unused variable ‘psbfb’ [-Wunused-variable]
> struct psb_framebuffer *psbfb = to_psb_fb(fb);
>
> Fixes: c7cbed560ce2 ("drm/gma500: Fix Medfield for drm_framebuffer move")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
I sent the same patch a few days ago. Instead of hunting for an r-b
I just went ahead and pushed your version. Thanks for the patch.
> ---
> drivers/gpu/drm/gma500/mdfld_intel_display.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> index 881d613..2b9fa01 100644
> --- a/drivers/gpu/drm/gma500/mdfld_intel_display.c
> +++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> @@ -167,7 +167,6 @@ static int mdfld__intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
> struct drm_psb_private *dev_priv = dev->dev_private;
> struct drm_framebuffer *fb = crtc->primary->fb;
> struct gma_crtc *gma_crtc = to_gma_crtc(crtc);
> - struct psb_framebuffer *psbfb = to_psb_fb(fb);
> int pipe = gma_crtc->pipe;
> const struct psb_offset *map = &dev_priv->regmap[pipe];
> unsigned long start, offset;
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
David Airlie <airlied@linux.ie>,
Daniel Stone <daniels@collabora.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/gma500: Fix compile warning
Date: Tue, 26 Jun 2018 16:28:28 +0300 [thread overview]
Message-ID: <20180626132828.GY20518@intel.com> (raw)
In-Reply-To: <20180625123355.GA16757@embeddedor.com>
On Mon, Jun 25, 2018 at 07:33:55AM -0500, Gustavo A. R. Silva wrote:
> Fix the following compile warning:
>
> warning: unused variable ‘psbfb’ [-Wunused-variable]
> struct psb_framebuffer *psbfb = to_psb_fb(fb);
>
> Fixes: c7cbed560ce2 ("drm/gma500: Fix Medfield for drm_framebuffer move")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
I sent the same patch a few days ago. Instead of hunting for an r-b
I just went ahead and pushed your version. Thanks for the patch.
> ---
> drivers/gpu/drm/gma500/mdfld_intel_display.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> index 881d613..2b9fa01 100644
> --- a/drivers/gpu/drm/gma500/mdfld_intel_display.c
> +++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> @@ -167,7 +167,6 @@ static int mdfld__intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
> struct drm_psb_private *dev_priv = dev->dev_private;
> struct drm_framebuffer *fb = crtc->primary->fb;
> struct gma_crtc *gma_crtc = to_gma_crtc(crtc);
> - struct psb_framebuffer *psbfb = to_psb_fb(fb);
> int pipe = gma_crtc->pipe;
> const struct psb_offset *map = &dev_priv->regmap[pipe];
> unsigned long start, offset;
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2018-06-26 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 12:33 [PATCH] drm/gma500: Fix compile warning Gustavo A. R. Silva
2018-06-26 13:28 ` Ville Syrjälä [this message]
2018-06-26 13:28 ` Ville Syrjälä
2018-06-26 13:37 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626132828.GY20518@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.