All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Miguel Rodríguez Pérez" <miguel@det.uvigo.gal>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: [v2,1/4] Simplify usbnet_cdc_update_filter
Date: Sun, 1 Jul 2018 10:15:50 +0200	[thread overview]
Message-ID: <20180701081550.GA7048@kroah.com> (raw)

On Sat, Jun 30, 2018 at 07:32:23PM +0200, Miguel Rodríguez Pérez wrote:
> Remove some unneeded varibles to make the code easier to read
> and, replace the generic usb_control_msg function for the
> more specific usbnet_write_cmd.
> ---
>  drivers/net/usb/cdc_ether.c | 15 +++++----------
>  1 file changed, 5 insertions(+), 10 deletions(-)

None of your patches have a signed-off-by line, and your subject needs
work as well (see other patches for how to do this with the correct
prefix.)

Also work on cc: the correct people, scripts/get_maintainer.pl on the
patch will tell you that, and also use 'git send-email' to properly
thread them.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: "Miguel Rodríguez Pérez" <miguel@det.uvigo.gal>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/4] Simplify usbnet_cdc_update_filter
Date: Sun, 1 Jul 2018 10:15:50 +0200	[thread overview]
Message-ID: <20180701081550.GA7048@kroah.com> (raw)
In-Reply-To: <634ae5d9-c969-15a6-1831-10bd0719fe59@det.uvigo.gal>

On Sat, Jun 30, 2018 at 07:32:23PM +0200, Miguel Rodríguez Pérez wrote:
> Remove some unneeded varibles to make the code easier to read
> and, replace the generic usb_control_msg function for the
> more specific usbnet_write_cmd.
> ---
>  drivers/net/usb/cdc_ether.c | 15 +++++----------
>  1 file changed, 5 insertions(+), 10 deletions(-)

None of your patches have a signed-off-by line, and your subject needs
work as well (see other patches for how to do this with the correct
prefix.)

Also work on cc: the correct people, scripts/get_maintainer.pl on the
patch will tell you that, and also use 'git send-email' to properly
thread them.

thanks,

greg k-h

             reply	other threads:[~2018-07-01  8:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-01  8:15 Greg Kroah-Hartman [this message]
2018-07-01  8:15 ` [PATCH v2 1/4] Simplify usbnet_cdc_update_filter Greg KH
2018-07-01  9:05 ` [v2,1/4] " Miguel Rodríguez Pérez
2018-07-01  9:05   ` [PATCH v3 0/4] usbnet: Admit multicast traffic in cdc ncm devices Miguel Rodríguez Pérez
2018-07-01  9:05   ` [v3,1/4] Simplify usbnet_cdc_update_filter Miguel Rodríguez Pérez
2018-07-01  9:05     ` [PATCH v3 1/4] " Miguel Rodríguez Pérez
2020-07-13 20:43     ` Wxcafé
2020-07-14  6:06       ` Greg KH
2020-07-14 15:13         ` Wxcafé
2020-07-14 16:13           ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2018-07-09  9:34 [v3,4/4] Hook into set_rx_mode to admit multicast traffic kbuild test robot
2018-07-09  9:34 ` [PATCH v3 4/4] " kbuild test robot
2018-07-04 14:41 [v4,3/4] Add .ndo_set_rx_mode to cdc_ncm_netdev_ops Miguel Rodríguez Pérez
2018-07-04 14:41 ` [PATCH v4 3/4] " Miguel Rodríguez Pérez
2018-07-04 14:32 [v4,3/4] " Miguel Rodríguez Pérez
2018-07-04 14:32 ` [PATCH v4 3/4] " Miguel Rodríguez Pérez
2018-07-02 17:13 [v3,1/4] Simplify usbnet_cdc_update_filter Bjørn Mork
2018-07-02 17:13 ` [PATCH v3 1/4] " Bjørn Mork
2018-07-02 11:28 [v4,1/4] Use dev->intf to get interface information Miguel Rodríguez Pérez
2018-07-02 11:28 ` [PATCH v4 1/4] " Miguel Rodríguez Pérez
2018-07-02 11:19 [v3,1/4] Simplify usbnet_cdc_update_filter Miguel Rodríguez Pérez
2018-07-02 11:19 ` [PATCH v3 1/4] " Miguel Rodríguez Pérez
2018-07-02  8:26 [v3,2/4] Export usbnet_cdc_update_filter Oliver Neukum
2018-07-02  8:26 ` [PATCH v3 2/4] " Oliver Neukum
2018-07-02  8:25 [v3,1/4] Simplify usbnet_cdc_update_filter Oliver Neukum
2018-07-02  8:25 ` [PATCH v3 1/4] " Oliver Neukum
2018-07-01  9:05 [v3,4/4] Hook into set_rx_mode to admit multicast traffic Miguel Rodríguez Pérez
2018-07-01  9:05 ` [PATCH v3 4/4] " Miguel Rodríguez Pérez
2018-07-01  9:05 [v3,3/4] Replace the way cdc_ncm hooks into usbnet_change_mtu Miguel Rodríguez Pérez
2018-07-01  9:05 ` [PATCH v3 3/4] " Miguel Rodríguez Pérez
2018-07-01  9:05 [v3,2/4] Export usbnet_cdc_update_filter Miguel Rodríguez Pérez
2018-07-01  9:05 ` [PATCH v3 2/4] " Miguel Rodríguez Pérez
2018-06-30 17:32 [v2,1/4] Simplify usbnet_cdc_update_filter Miguel Rodríguez Pérez
2018-06-30 17:32 ` [PATCH v2 1/4] " Miguel Rodríguez Pérez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180701081550.GA7048@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=miguel@det.uvigo.gal \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.