From: Igor Mammedov <imammedo@redhat.com>
To: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: <qemu-devel@nongnu.org>, <qemu-trivial@nongnu.org>,
<ehabkost@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() follow-up
Date: Tue, 10 Jul 2018 14:06:55 +0200 [thread overview]
Message-ID: <20180710140655.00742582@redhat.com> (raw)
In-Reply-To: <20180710105129.23296-1-douly.fnst@cn.fujitsu.com>
On Tue, 10 Jul 2018 18:51:29 +0800
Dou Liyang <douly.fnst@cn.fujitsu.com> wrote:
> This Commit 7747abf11487 misses the curly brackets. Follow Igor's and Eduardo's suggestion,
>
> Add a follow-up patch for it.
>
> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
> ---
> hw/core/machine.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index a9aeb22f03..6b68e1218f 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -793,8 +793,9 @@ void machine_run_board_init(MachineState *machine)
> MachineClass *machine_class = MACHINE_GET_CLASS(machine);
>
> numa_complete_configuration(machine);
> - if (nb_numa_nodes)
> + if (nb_numa_nodes) {
> machine_numa_finish_cpu_init(machine);
> + }
>
> /* If the machine supports the valid_cpu_types check and the user
> * specified a CPU with -cpu check here that the user CPU is supported.
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Igor Mammedov <imammedo@redhat.com>
To: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() follow-up
Date: Tue, 10 Jul 2018 14:06:55 +0200 [thread overview]
Message-ID: <20180710140655.00742582@redhat.com> (raw)
In-Reply-To: <20180710105129.23296-1-douly.fnst@cn.fujitsu.com>
On Tue, 10 Jul 2018 18:51:29 +0800
Dou Liyang <douly.fnst@cn.fujitsu.com> wrote:
> This Commit 7747abf11487 misses the curly brackets. Follow Igor's and Eduardo's suggestion,
>
> Add a follow-up patch for it.
>
> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
> ---
> hw/core/machine.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index a9aeb22f03..6b68e1218f 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -793,8 +793,9 @@ void machine_run_board_init(MachineState *machine)
> MachineClass *machine_class = MACHINE_GET_CLASS(machine);
>
> numa_complete_configuration(machine);
> - if (nb_numa_nodes)
> + if (nb_numa_nodes) {
> machine_numa_finish_cpu_init(machine);
> + }
>
> /* If the machine supports the valid_cpu_types check and the user
> * specified a CPU with -cpu check here that the user CPU is supported.
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
next prev parent reply other threads:[~2018-07-10 12:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 10:51 [Qemu-trivial] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() follow-up Dou Liyang
2018-07-10 10:51 ` [Qemu-devel] " Dou Liyang
2018-07-10 12:06 ` Igor Mammedov [this message]
2018-07-10 12:06 ` Igor Mammedov
2018-07-10 14:37 ` [Qemu-trivial] " Eduardo Habkost
2018-07-10 14:37 ` [Qemu-devel] " Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710140655.00742582@redhat.com \
--to=imammedo@redhat.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.