From: Eduardo Habkost <ehabkost@redhat.com>
To: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, imammedo@redhat.com
Subject: Re: [Qemu-trivial] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() follow-up
Date: Tue, 10 Jul 2018 11:37:51 -0300 [thread overview]
Message-ID: <20180710143751.GI7451@localhost.localdomain> (raw)
In-Reply-To: <20180710105129.23296-1-douly.fnst@cn.fujitsu.com>
On Tue, Jul 10, 2018 at 06:51:29PM +0800, Dou Liyang wrote:
> This Commit 7747abf11487 misses the curly brackets. Follow Igor's and Eduardo's suggestion,
>
> Add a follow-up patch for it.
>
> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
I'm queueing this for 3.1, but the subject line didn't make sense
(this patch doesn't remove zero check of nb_numa_nodes), so I
rewrote the commit message as:
machine: Fix coding style at machine_run_board_init()
Commit 7747abf11487 ("hw/machine: Remove the Zero check of
nb_numa_nodes for numa_complete_configuration()") removed the
curly brackets. Re-add them.
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Message-Id: <20180710105129.23296-1-douly.fnst@cn.fujitsu.com>
[ehabkost: rewrote commit message]
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() follow-up
Date: Tue, 10 Jul 2018 11:37:51 -0300 [thread overview]
Message-ID: <20180710143751.GI7451@localhost.localdomain> (raw)
In-Reply-To: <20180710105129.23296-1-douly.fnst@cn.fujitsu.com>
On Tue, Jul 10, 2018 at 06:51:29PM +0800, Dou Liyang wrote:
> This Commit 7747abf11487 misses the curly brackets. Follow Igor's and Eduardo's suggestion,
>
> Add a follow-up patch for it.
>
> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
I'm queueing this for 3.1, but the subject line didn't make sense
(this patch doesn't remove zero check of nb_numa_nodes), so I
rewrote the commit message as:
machine: Fix coding style at machine_run_board_init()
Commit 7747abf11487 ("hw/machine: Remove the Zero check of
nb_numa_nodes for numa_complete_configuration()") removed the
curly brackets. Re-add them.
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Message-Id: <20180710105129.23296-1-douly.fnst@cn.fujitsu.com>
[ehabkost: rewrote commit message]
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
next prev parent reply other threads:[~2018-07-10 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 10:51 [Qemu-trivial] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() follow-up Dou Liyang
2018-07-10 10:51 ` [Qemu-devel] " Dou Liyang
2018-07-10 12:06 ` [Qemu-trivial] " Igor Mammedov
2018-07-10 12:06 ` [Qemu-devel] " Igor Mammedov
2018-07-10 14:37 ` Eduardo Habkost [this message]
2018-07-10 14:37 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710143751.GI7451@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.