* [PATCH] arm64: dts: hikey960: Remove keep-power-in-suspend property
@ 2018-07-13 15:53 ` Ryan Grachek
0 siblings, 0 replies; 6+ messages in thread
From: Ryan Grachek @ 2018-07-13 15:53 UTC (permalink / raw)
Cc: john.stultz, Ryan Grachek, Wei Xu, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, linux-arm-kernel, devicetree,
linux-kernel
Remove the keep-power-in-suspend property because it keeps wifi power
on during suspend. This property is only required when enabling WoWLAN
and should only be enabled based on need. Also remove dupplicate property
Signed-off-by: Ryan Grachek <ryan@edited.us>
---
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 -
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
index 68c5a6c819ae..a927ce4ec40b 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
@@ -586,7 +586,6 @@
ti,non-removable;
non-removable;
cap-power-off-card;
- keep-power-in-suspend;
#address-cells = <0x1>;
#size-cells = <0x0>;
status = "ok";
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
index 8d477dcbfa58..4588fe4e00a8 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
@@ -1050,7 +1050,6 @@
reset-names = "reset";
card-detect-delay = <200>;
supports-highspeed;
- keep-power-in-suspend;
pinctrl-names = "default";
pinctrl-0 = <&sdio_pmx_func
&sdio_clk_cfg_func
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: hikey960: Remove keep-power-in-suspend property
@ 2018-07-13 15:53 ` Ryan Grachek
0 siblings, 0 replies; 6+ messages in thread
From: Ryan Grachek @ 2018-07-13 15:53 UTC (permalink / raw)
Cc: john.stultz, Ryan Grachek, Wei Xu, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, linux-arm-kernel, devicetree,
linux-kernel
Remove the keep-power-in-suspend property because it keeps wifi power
on during suspend. This property is only required when enabling WoWLAN
and should only be enabled based on need. Also remove dupplicate property
Signed-off-by: Ryan Grachek <ryan@edited.us>
---
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 -
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
index 68c5a6c819ae..a927ce4ec40b 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
@@ -586,7 +586,6 @@
ti,non-removable;
non-removable;
cap-power-off-card;
- keep-power-in-suspend;
#address-cells = <0x1>;
#size-cells = <0x0>;
status = "ok";
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
index 8d477dcbfa58..4588fe4e00a8 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
@@ -1050,7 +1050,6 @@
reset-names = "reset";
card-detect-delay = <200>;
supports-highspeed;
- keep-power-in-suspend;
pinctrl-names = "default";
pinctrl-0 = <&sdio_pmx_func
&sdio_clk_cfg_func
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: hikey960: Remove keep-power-in-suspend property
2018-07-13 15:53 ` Ryan Grachek
(?)
@ 2018-07-18 15:33 ` Wei Xu
-1 siblings, 0 replies; 6+ messages in thread
From: Wei Xu @ 2018-07-18 15:33 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ryan,
On 2018/7/13 16:53, Ryan Grachek wrote:
> Remove the keep-power-in-suspend property because it keeps wifi power
> on during suspend. This property is only required when enabling WoWLAN
> and should only be enabled based on need. Also remove dupplicate property
>
> Signed-off-by: Ryan Grachek <ryan@edited.us>
Thanks!
Applied to the hisilicon dt tree.
Best Regards,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 -
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> index 68c5a6c819ae..a927ce4ec40b 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> @@ -586,7 +586,6 @@
> ti,non-removable;
> non-removable;
> cap-power-off-card;
> - keep-power-in-suspend;
> #address-cells = <0x1>;
> #size-cells = <0x0>;
> status = "ok";
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index 8d477dcbfa58..4588fe4e00a8 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -1050,7 +1050,6 @@
> reset-names = "reset";
> card-detect-delay = <200>;
> supports-highspeed;
> - keep-power-in-suspend;
> pinctrl-names = "default";
> pinctrl-0 = <&sdio_pmx_func
> &sdio_clk_cfg_func
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: hikey960: Remove keep-power-in-suspend property
@ 2018-07-18 15:33 ` Wei Xu
0 siblings, 0 replies; 6+ messages in thread
From: Wei Xu @ 2018-07-18 15:33 UTC (permalink / raw)
To: Ryan Grachek
Cc: john.stultz, Rob Herring, Mark Rutland, Catalin Marinas,
Will Deacon, linux-arm-kernel, devicetree, linux-kernel
Hi Ryan,
On 2018/7/13 16:53, Ryan Grachek wrote:
> Remove the keep-power-in-suspend property because it keeps wifi power
> on during suspend. This property is only required when enabling WoWLAN
> and should only be enabled based on need. Also remove dupplicate property
>
> Signed-off-by: Ryan Grachek <ryan@edited.us>
Thanks!
Applied to the hisilicon dt tree.
Best Regards,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 -
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> index 68c5a6c819ae..a927ce4ec40b 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> @@ -586,7 +586,6 @@
> ti,non-removable;
> non-removable;
> cap-power-off-card;
> - keep-power-in-suspend;
> #address-cells = <0x1>;
> #size-cells = <0x0>;
> status = "ok";
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index 8d477dcbfa58..4588fe4e00a8 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -1050,7 +1050,6 @@
> reset-names = "reset";
> card-detect-delay = <200>;
> supports-highspeed;
> - keep-power-in-suspend;
> pinctrl-names = "default";
> pinctrl-0 = <&sdio_pmx_func
> &sdio_clk_cfg_func
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: hikey960: Remove keep-power-in-suspend property
@ 2018-07-18 15:33 ` Wei Xu
0 siblings, 0 replies; 6+ messages in thread
From: Wei Xu @ 2018-07-18 15:33 UTC (permalink / raw)
To: Ryan Grachek
Cc: john.stultz, Rob Herring, Mark Rutland, Catalin Marinas,
Will Deacon, linux-arm-kernel, devicetree, linux-kernel
Hi Ryan,
On 2018/7/13 16:53, Ryan Grachek wrote:
> Remove the keep-power-in-suspend property because it keeps wifi power
> on during suspend. This property is only required when enabling WoWLAN
> and should only be enabled based on need. Also remove dupplicate property
>
> Signed-off-by: Ryan Grachek <ryan@edited.us>
Thanks!
Applied to the hisilicon dt tree.
Best Regards,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 1 -
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> index 68c5a6c819ae..a927ce4ec40b 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> @@ -586,7 +586,6 @@
> ti,non-removable;
> non-removable;
> cap-power-off-card;
> - keep-power-in-suspend;
> #address-cells = <0x1>;
> #size-cells = <0x0>;
> status = "ok";
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index 8d477dcbfa58..4588fe4e00a8 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -1050,7 +1050,6 @@
> reset-names = "reset";
> card-detect-delay = <200>;
> supports-highspeed;
> - keep-power-in-suspend;
> pinctrl-names = "default";
> pinctrl-0 = <&sdio_pmx_func
> &sdio_clk_cfg_func
>
^ permalink raw reply [flat|nested] 6+ messages in thread