From: "Daniel P. Berrange" <berrange@redhat.com>
To: Mike Krinkin <krinkin.m.u@gmail.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com,
qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] opts: fix NULL pointer derefernce in get_opt_value
Date: Mon, 16 Jul 2018 19:47:52 +0100 [thread overview]
Message-ID: <20180716184752.GA30657@redhat.com> (raw)
In-Reply-To: <20180716174146.19845-1-krinkin.m.u@gmail.com>
On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote:
> The value argument can be NULL, for example, in hw/i386/multiboot.c
> in the load_multiboot function get_opt_value is explicitly called
> with NULL as the second argument.
>
> The problem was introduced in commit 950c4e6c94b1 ("opts: don't
> silently truncate long option values"). This change fixes the
> problem by adding a check whether the value is NULL or not.
>
> Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
> ---
> util/qemu-option.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
This problem is fixed in this:
https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01490.html
but it is still waiting for i386 maintainers to respond....
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Mike Krinkin <krinkin.m.u@gmail.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com,
qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] opts: fix NULL pointer derefernce in get_opt_value
Date: Mon, 16 Jul 2018 19:47:52 +0100 [thread overview]
Message-ID: <20180716184752.GA30657@redhat.com> (raw)
In-Reply-To: <20180716174146.19845-1-krinkin.m.u@gmail.com>
On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote:
> The value argument can be NULL, for example, in hw/i386/multiboot.c
> in the load_multiboot function get_opt_value is explicitly called
> with NULL as the second argument.
>
> The problem was introduced in commit 950c4e6c94b1 ("opts: don't
> silently truncate long option values"). This change fixes the
> problem by adding a check whether the value is NULL or not.
>
> Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
> ---
> util/qemu-option.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
This problem is fixed in this:
https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01490.html
but it is still waiting for i386 maintainers to respond....
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2018-07-16 18:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 17:41 [Qemu-trivial] [PATCH] opts: fix NULL pointer derefernce in get_opt_value Mike Krinkin
2018-07-16 17:41 ` [Qemu-devel] " Mike Krinkin
2018-07-16 18:47 ` Daniel P. Berrange [this message]
2018-07-16 18:47 ` Daniel P. Berrange
2018-07-16 18:50 ` [Qemu-trivial] " Mike Krinkin
2018-07-16 18:50 ` [Qemu-devel] " Mike Krinkin
2018-07-17 10:36 ` [Qemu-trivial] " Paolo Bonzini
2018-07-17 10:36 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716184752.GA30657@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=krinkin.m.u@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.