* [Qemu-trivial] [PATCH] opts: fix NULL pointer derefernce in get_opt_value
@ 2018-07-16 17:41 ` Mike Krinkin
0 siblings, 0 replies; 8+ messages in thread
From: Mike Krinkin @ 2018-07-16 17:41 UTC (permalink / raw)
To: qemu-devel; +Cc: armbru, berrange, pbonzini, qemu-trivial, Mike Krinkin
The value argument can be NULL, for example, in hw/i386/multiboot.c
in the load_multiboot function get_opt_value is explicitly called
with NULL as the second argument.
The problem was introduced in commit 950c4e6c94b1 ("opts: don't
silently truncate long option values"). This change fixes the
problem by adding a check whether the value is NULL or not.
Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
---
util/qemu-option.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/util/qemu-option.c b/util/qemu-option.c
index 19761e3eaf..834217fc75 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -75,7 +75,9 @@ const char *get_opt_value(const char *p, char **value)
size_t capacity = 0, length;
const char *offset;
- *value = NULL;
+ if (value) {
+ *value = NULL;
+ }
while (1) {
offset = qemu_strchrnul(p, ',');
length = offset - p;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Qemu-devel] [PATCH] opts: fix NULL pointer derefernce in get_opt_value
@ 2018-07-16 17:41 ` Mike Krinkin
0 siblings, 0 replies; 8+ messages in thread
From: Mike Krinkin @ 2018-07-16 17:41 UTC (permalink / raw)
To: qemu-devel; +Cc: armbru, berrange, pbonzini, qemu-trivial, Mike Krinkin
The value argument can be NULL, for example, in hw/i386/multiboot.c
in the load_multiboot function get_opt_value is explicitly called
with NULL as the second argument.
The problem was introduced in commit 950c4e6c94b1 ("opts: don't
silently truncate long option values"). This change fixes the
problem by adding a check whether the value is NULL or not.
Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
---
util/qemu-option.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/util/qemu-option.c b/util/qemu-option.c
index 19761e3eaf..834217fc75 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -75,7 +75,9 @@ const char *get_opt_value(const char *p, char **value)
size_t capacity = 0, length;
const char *offset;
- *value = NULL;
+ if (value) {
+ *value = NULL;
+ }
while (1) {
offset = qemu_strchrnul(p, ',');
length = offset - p;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [PATCH] opts: fix NULL pointer derefernce in get_opt_value
2018-07-16 17:41 ` [Qemu-devel] " Mike Krinkin
@ 2018-07-16 18:47 ` Daniel P. Berrange
-1 siblings, 0 replies; 8+ messages in thread
From: Daniel P. Berrange @ 2018-07-16 18:47 UTC (permalink / raw)
To: Mike Krinkin; +Cc: qemu-devel, armbru, pbonzini, qemu-trivial
On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote:
> The value argument can be NULL, for example, in hw/i386/multiboot.c
> in the load_multiboot function get_opt_value is explicitly called
> with NULL as the second argument.
>
> The problem was introduced in commit 950c4e6c94b1 ("opts: don't
> silently truncate long option values"). This change fixes the
> problem by adding a check whether the value is NULL or not.
>
> Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
> ---
> util/qemu-option.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
This problem is fixed in this:
https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01490.html
but it is still waiting for i386 maintainers to respond....
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] opts: fix NULL pointer derefernce in get_opt_value
@ 2018-07-16 18:47 ` Daniel P. Berrange
0 siblings, 0 replies; 8+ messages in thread
From: Daniel P. Berrange @ 2018-07-16 18:47 UTC (permalink / raw)
To: Mike Krinkin; +Cc: qemu-devel, armbru, pbonzini, qemu-trivial
On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote:
> The value argument can be NULL, for example, in hw/i386/multiboot.c
> in the load_multiboot function get_opt_value is explicitly called
> with NULL as the second argument.
>
> The problem was introduced in commit 950c4e6c94b1 ("opts: don't
> silently truncate long option values"). This change fixes the
> problem by adding a check whether the value is NULL or not.
>
> Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
> ---
> util/qemu-option.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
This problem is fixed in this:
https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01490.html
but it is still waiting for i386 maintainers to respond....
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [PATCH] opts: fix NULL pointer derefernce in get_opt_value
2018-07-16 18:47 ` [Qemu-devel] " Daniel P. Berrange
@ 2018-07-16 18:50 ` Mike Krinkin
-1 siblings, 0 replies; 8+ messages in thread
From: Mike Krinkin @ 2018-07-16 18:50 UTC (permalink / raw)
To: berrange; +Cc: qemu-devel, armbru, Paolo Bonzini, qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]
On Mon, Jul 16, 2018 at 7:47 PM Daniel P. Berrange <berrange@redhat.com>
wrote:
> On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote:
> > The value argument can be NULL, for example, in hw/i386/multiboot.c
> > in the load_multiboot function get_opt_value is explicitly called
> > with NULL as the second argument.
> >
> > The problem was introduced in commit 950c4e6c94b1 ("opts: don't
> > silently truncate long option values"). This change fixes the
> > problem by adding a check whether the value is NULL or not.
> >
> > Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
> > ---
> > util/qemu-option.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> This problem is fixed in this:
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01490.html
>
> but it is still waiting for i386 maintainers to respond....
>
Thanks for the update, I searched through the archive briefly but didn't
find this fix, sorry for the noise and please ignore this path.
>
> Regards,
> Daniel
> --
> |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/
> :|
> |: http://libvirt.org -o- http://virt-manager.org
> :|
> |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/
> :|
>
[-- Attachment #2: Type: text/html, Size: 2440 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] opts: fix NULL pointer derefernce in get_opt_value
@ 2018-07-16 18:50 ` Mike Krinkin
0 siblings, 0 replies; 8+ messages in thread
From: Mike Krinkin @ 2018-07-16 18:50 UTC (permalink / raw)
To: berrange; +Cc: qemu-devel, armbru, Paolo Bonzini, qemu-trivial
On Mon, Jul 16, 2018 at 7:47 PM Daniel P. Berrange <berrange@redhat.com>
wrote:
> On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote:
> > The value argument can be NULL, for example, in hw/i386/multiboot.c
> > in the load_multiboot function get_opt_value is explicitly called
> > with NULL as the second argument.
> >
> > The problem was introduced in commit 950c4e6c94b1 ("opts: don't
> > silently truncate long option values"). This change fixes the
> > problem by adding a check whether the value is NULL or not.
> >
> > Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
> > ---
> > util/qemu-option.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> This problem is fixed in this:
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01490.html
>
> but it is still waiting for i386 maintainers to respond....
>
Thanks for the update, I searched through the archive briefly but didn't
find this fix, sorry for the noise and please ignore this path.
>
> Regards,
> Daniel
> --
> |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/
> :|
> |: http://libvirt.org -o- http://virt-manager.org
> :|
> |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/
> :|
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] opts: fix NULL pointer derefernce in get_opt_value
2018-07-16 18:47 ` [Qemu-devel] " Daniel P. Berrange
@ 2018-07-17 10:36 ` Paolo Bonzini
-1 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2018-07-17 10:36 UTC (permalink / raw)
To: Daniel P. Berrange, Mike Krinkin; +Cc: qemu-devel, armbru, qemu-trivial
On 16/07/2018 20:47, Daniel P. Berrange wrote:
> On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote:
>> The value argument can be NULL, for example, in hw/i386/multiboot.c
>> in the load_multiboot function get_opt_value is explicitly called
>> with NULL as the second argument.
>>
>> The problem was introduced in commit 950c4e6c94b1 ("opts: don't
>> silently truncate long option values"). This change fixes the
>> problem by adding a check whether the value is NULL or not.
>>
>> Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
>> ---
>> util/qemu-option.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> This problem is fixed in this:
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01490.html
>
> but it is still waiting for i386 maintainers to respond....
Generally Kevin has looked at multiboot patches, but I'll merge these
ones because he's on vacation. Thanks,
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] opts: fix NULL pointer derefernce in get_opt_value
@ 2018-07-17 10:36 ` Paolo Bonzini
0 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2018-07-17 10:36 UTC (permalink / raw)
To: Daniel P. Berrange, Mike Krinkin; +Cc: qemu-devel, armbru, qemu-trivial
On 16/07/2018 20:47, Daniel P. Berrange wrote:
> On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote:
>> The value argument can be NULL, for example, in hw/i386/multiboot.c
>> in the load_multiboot function get_opt_value is explicitly called
>> with NULL as the second argument.
>>
>> The problem was introduced in commit 950c4e6c94b1 ("opts: don't
>> silently truncate long option values"). This change fixes the
>> problem by adding a check whether the value is NULL or not.
>>
>> Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
>> ---
>> util/qemu-option.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> This problem is fixed in this:
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01490.html
>
> but it is still waiting for i386 maintainers to respond....
Generally Kevin has looked at multiboot patches, but I'll merge these
ones because he's on vacation. Thanks,
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-07-17 10:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-16 17:41 [Qemu-trivial] [PATCH] opts: fix NULL pointer derefernce in get_opt_value Mike Krinkin
2018-07-16 17:41 ` [Qemu-devel] " Mike Krinkin
2018-07-16 18:47 ` [Qemu-trivial] " Daniel P. Berrange
2018-07-16 18:47 ` [Qemu-devel] " Daniel P. Berrange
2018-07-16 18:50 ` [Qemu-trivial] " Mike Krinkin
2018-07-16 18:50 ` [Qemu-devel] " Mike Krinkin
2018-07-17 10:36 ` [Qemu-trivial] " Paolo Bonzini
2018-07-17 10:36 ` [Qemu-devel] " Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.