From: Lukas Wunner <lukas@wunner.de>
To: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@linux.ie>,
nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [Nouveau] [PATCH 2/5] drm/nouveau: Grab RPM ref while probing outputs
Date: Tue, 17 Jul 2018 09:21:52 +0200 [thread overview]
Message-ID: <20180717072152.GA16115@wunner.de> (raw)
In-Reply-To: <20180716235936.11268-3-lyude@redhat.com>
On Mon, Jul 16, 2018 at 07:59:26PM -0400, Lyude Paul wrote:
> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -2012,10 +2012,18 @@ nv50_disp_atomic_state_alloc(struct drm_device *dev)
> return &atom->state;
> }
>
> +static void
> +nouveau_output_poll_changed(struct drm_device *dev)
> +{
> + pm_runtime_get_sync(dev->dev);
> + drm_fb_helper_hotplug_event(dev->fb_helper);
> + pm_runtime_put_autosuspend(dev->dev);
> +}
> +
> static const struct drm_mode_config_funcs
> nv50_disp_func = {
> .fb_create = nouveau_user_framebuffer_create,
> - .output_poll_changed = drm_fb_helper_output_poll_changed,
> + .output_poll_changed = nouveau_output_poll_changed,
It might make sense to provide a generic DRM helper for this.
Same for patch 3 in this series.
Thanks,
Lukas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Lukas Wunner <lukas@wunner.de>
To: Lyude Paul <lyude@redhat.com>
Cc: nouveau@lists.freedesktop.org, "David Airlie" <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
linux-kernel@vger.kernel.org, "Ben Skeggs" <bskeggs@redhat.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: Re: [Nouveau] [PATCH 2/5] drm/nouveau: Grab RPM ref while probing outputs
Date: Tue, 17 Jul 2018 09:21:52 +0200 [thread overview]
Message-ID: <20180717072152.GA16115@wunner.de> (raw)
In-Reply-To: <20180716235936.11268-3-lyude@redhat.com>
On Mon, Jul 16, 2018 at 07:59:26PM -0400, Lyude Paul wrote:
> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -2012,10 +2012,18 @@ nv50_disp_atomic_state_alloc(struct drm_device *dev)
> return &atom->state;
> }
>
> +static void
> +nouveau_output_poll_changed(struct drm_device *dev)
> +{
> + pm_runtime_get_sync(dev->dev);
> + drm_fb_helper_hotplug_event(dev->fb_helper);
> + pm_runtime_put_autosuspend(dev->dev);
> +}
> +
> static const struct drm_mode_config_funcs
> nv50_disp_func = {
> .fb_create = nouveau_user_framebuffer_create,
> - .output_poll_changed = drm_fb_helper_output_poll_changed,
> + .output_poll_changed = nouveau_output_poll_changed,
It might make sense to provide a generic DRM helper for this.
Same for patch 3 in this series.
Thanks,
Lukas
next prev parent reply other threads:[~2018-07-17 7:21 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 23:59 [PATCH 0/5] drm/nouveau: Fix a lot of nasty RPM bugs and deadlocks Lyude Paul
2018-07-16 23:59 ` Lyude Paul
2018-07-16 23:59 ` [PATCH 1/5] drm/nouveau: Prevent RPM callback recursion in suspend/resume paths Lyude Paul
2018-07-16 23:59 ` Lyude Paul
2018-07-17 7:16 ` [Nouveau] " Lukas Wunner
[not found] ` <20180717071641.GA5411-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2018-07-17 7:39 ` Rafael J. Wysocki
2018-07-17 7:39 ` [Nouveau] " Rafael J. Wysocki
2018-07-17 16:53 ` Lyude Paul
[not found] ` <d7c25a7f41df70685c0c4726315592d1d9b561ff.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-17 18:20 ` Lukas Wunner
2018-07-17 18:20 ` [Nouveau] " Lukas Wunner
[not found] ` <20180717182041.GA18363-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2018-07-17 18:24 ` Lyude Paul
2018-07-17 18:24 ` [Nouveau] " Lyude Paul
2018-07-17 18:32 ` Lukas Wunner
2018-07-17 18:34 ` Lyude Paul
2018-07-17 18:34 ` Lyude Paul
[not found] ` <2dbe75b1a83c025b9cddc229dbca9af6fb30111e.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-18 7:40 ` Rafael J. Wysocki
2018-07-18 7:40 ` [Nouveau] " Rafael J. Wysocki
2018-07-18 7:47 ` Lukas Wunner
2018-07-18 7:47 ` [Nouveau] " Lukas Wunner
2018-07-18 7:38 ` Rafael J. Wysocki
2018-07-18 7:38 ` [Nouveau] " Rafael J. Wysocki
[not found] ` <CAJZ5v0g8O8J0U8V-gLMe+NnTd3xgZ5_pjr9p2oci7yAfW54B-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-18 8:25 ` Lukas Wunner
2018-07-18 8:25 ` [Nouveau] " Lukas Wunner
[not found] ` <20180718082505.GB16072-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2018-07-18 8:35 ` Rafael J. Wysocki
2018-07-18 8:35 ` [Nouveau] " Rafael J. Wysocki
2018-07-18 8:36 ` Lukas Wunner
2018-07-18 8:36 ` Lukas Wunner
2018-07-18 20:11 ` Lyude Paul
[not found] ` <2724dd5eee8a1e4e523e43915fa184ad5afe1c59.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-18 21:49 ` Rafael J. Wysocki
2018-07-18 21:49 ` [Nouveau] " Rafael J. Wysocki
[not found] ` <20180716235936.11268-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-16 23:59 ` [PATCH 2/5] drm/nouveau: Grab RPM ref while probing outputs Lyude Paul
2018-07-16 23:59 ` Lyude Paul
2018-07-17 7:21 ` Lukas Wunner [this message]
2018-07-17 7:21 ` [Nouveau] " Lukas Wunner
2018-07-17 10:12 ` Karol Herbst
2018-07-17 10:12 ` Karol Herbst
2018-07-16 23:59 ` [PATCH 3/5] drm/nouveau: Add missing RPM get/put() when probing connectors Lyude Paul
2018-07-16 23:59 ` Lyude Paul
2018-07-17 10:11 ` [Nouveau] " Karol Herbst
2018-07-16 23:59 ` [PATCH 4/5] drm/nouveau: Grab RPM ref when i2c bus is in use Lyude Paul
2018-07-16 23:59 ` Lyude Paul
2018-07-17 10:17 ` [Nouveau] " Karol Herbst
2018-07-17 11:54 ` Ben Skeggs
2018-07-17 11:54 ` Ben Skeggs
2018-07-17 12:10 ` Karol Herbst
2018-07-16 23:59 ` [PATCH 5/5] drm/nouveau: Grab RPM ref when aux " Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717072152.GA16115@wunner.de \
--to=lukas@wunner.de \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.