From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: hannah@marvell.com, Jonathan Corbet <corbet@lwn.net>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Josef Griebichler <griebichler.josef@gmx.at>,
Hannes Frederic Sowa <hannes@redhat.com>,
Jesper Dangaard Brouer <jbrouer@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@s-opensource.com>,
Ingo Molnar <mingo@kernel.org>,
Network Development <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Rik van Riel <riel@redhat.com>,
Alan Stern <stern@rowland.harvard.edu>,
dma <dmaengine@vger.kernel.org>,
vkoul@kernel.org, Dan Williams <dan.j.williams@intel.com>,
nadavh@marvell.com, thomas.petazzoni@bootlin.com,
omrii@marvell.com
Subject: dvb usb issues since kernel 4.9
Date: Wed, 18 Jul 2018 07:21:07 +0900 [thread overview]
Message-ID: <20180718072107.0bfdece8@vela.lan> (raw)
Hi Linus,
Em Tue, 17 Jul 2018 10:09:28 -0700
Linus Torvalds <torvalds@linux-foundation.org> escreveu:
> On Tue, Jul 17, 2018 at 4:58 AM Hanna Hawa <hannah@marvell.com> wrote:
> >
> > After some debug/bisect/diff, found that patch "softirq: Let ksoftirqd
> > do its job" is problematic patch.
>
> Ok, this thread died down without any resolution.
>
> >- Using v4.14.0 (including softirq patch) and the additional fix
> > proposed by Linus - no timeout issue.
>
> Are you talking about the patch that made HI_SOFTIRQ and
> TASKLET_SOFTIRQ special, and had this:
>
> #define SOFTIRQ_NOW_MASK ((1 << HI_SOFTIRQ) | (1 << TASKLET_SOFTIRQ))
>
> in it?
>
> I think I'll just commit the damn thing. It's hacky, but it's simple,
> and it never got applied because we had smarter suggestions. But the
> smarter suggestions never ended up being applied either, so..
Yeah, IMHO the best would be to apply your patch[1], c/c stable up to
4.9. Nothing prevents applying a better/smarter solution once we
have it. From my side, I can keep testing whatever smart suggestions
people propose. Yet, better to have one fix on our hand than two
fixes flying around.
[1] e. g.
https://git.linuxtv.org/mchehab/experimental.git/commit/?h=v4.15%2bmedia%2bdwc2&id=ccf833fd4a5b99c3d3cf2c09c065670f74a230a7
Regards,
Mauro
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: hannah@marvell.com, Jonathan Corbet <corbet@lwn.net>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Josef Griebichler <griebichler.josef@gmx.at>,
Hannes Frederic Sowa <hannes@redhat.com>,
Jesper Dangaard Brouer <jbrouer@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@s-opensource.com>,
Ingo Molnar <mingo@kernel.org>,
Network Development <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Rik van Riel <riel@redhat.com>,
Alan Stern <stern@rowland.harvard.edu>,
dma <dmaengine@vger.kernel.org>,
vkoul@kernel.org, Dan Williams <dan.j.williams@intel.com>,
nadavh@marvell.com, thomas.petazzoni@bootlin.com,
omrii@marvell.com
Subject: Re: dvb usb issues since kernel 4.9
Date: Wed, 18 Jul 2018 07:21:07 +0900 [thread overview]
Message-ID: <20180718072107.0bfdece8@vela.lan> (raw)
In-Reply-To: <CA+55aFwb5hPtPFbB02SSn+wTkqTDSgHGFkiw7LB57mj42VzyZQ@mail.gmail.com>
Hi Linus,
Em Tue, 17 Jul 2018 10:09:28 -0700
Linus Torvalds <torvalds@linux-foundation.org> escreveu:
> On Tue, Jul 17, 2018 at 4:58 AM Hanna Hawa <hannah@marvell.com> wrote:
> >
> > After some debug/bisect/diff, found that patch "softirq: Let ksoftirqd
> > do its job" is problematic patch.
>
> Ok, this thread died down without any resolution.
>
> >- Using v4.14.0 (including softirq patch) and the additional fix
> > proposed by Linus - no timeout issue.
>
> Are you talking about the patch that made HI_SOFTIRQ and
> TASKLET_SOFTIRQ special, and had this:
>
> #define SOFTIRQ_NOW_MASK ((1 << HI_SOFTIRQ) | (1 << TASKLET_SOFTIRQ))
>
> in it?
>
> I think I'll just commit the damn thing. It's hacky, but it's simple,
> and it never got applied because we had smarter suggestions. But the
> smarter suggestions never ended up being applied either, so..
Yeah, IMHO the best would be to apply your patch[1], c/c stable up to
4.9. Nothing prevents applying a better/smarter solution once we
have it. From my side, I can keep testing whatever smart suggestions
people propose. Yet, better to have one fix on our hand than two
fixes flying around.
[1] e. g.
https://git.linuxtv.org/mchehab/experimental.git/commit/?h=v4.15%2bmedia%2bdwc2&id=ccf833fd4a5b99c3d3cf2c09c065670f74a230a7
Regards,
Mauro
WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: hannah@marvell.com, Jonathan Corbet <corbet@lwn.net>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Josef Griebichler <griebichler.josef@gmx.at>,
Hannes Frederic Sowa <hannes@redhat.com>,
Jesper Dangaard Brouer <jbrouer@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@s-opensource.com>,
Ingo Molnar <mingo@kernel.org>,
Network Development <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Rik van Riel <riel@redhat.com>,
Alan Stern <stern@rowland.harvard.edu>,
dma <dmaengine@vger.kernel.o
Subject: Re: dvb usb issues since kernel 4.9
Date: Wed, 18 Jul 2018 07:21:07 +0900 [thread overview]
Message-ID: <20180718072107.0bfdece8@vela.lan> (raw)
In-Reply-To: <CA+55aFwb5hPtPFbB02SSn+wTkqTDSgHGFkiw7LB57mj42VzyZQ@mail.gmail.com>
Hi Linus,
Em Tue, 17 Jul 2018 10:09:28 -0700
Linus Torvalds <torvalds@linux-foundation.org> escreveu:
> On Tue, Jul 17, 2018 at 4:58 AM Hanna Hawa <hannah@marvell.com> wrote:
> >
> > After some debug/bisect/diff, found that patch "softirq: Let ksoftirqd
> > do its job" is problematic patch.
>
> Ok, this thread died down without any resolution.
>
> >- Using v4.14.0 (including softirq patch) and the additional fix
> > proposed by Linus - no timeout issue.
>
> Are you talking about the patch that made HI_SOFTIRQ and
> TASKLET_SOFTIRQ special, and had this:
>
> #define SOFTIRQ_NOW_MASK ((1 << HI_SOFTIRQ) | (1 << TASKLET_SOFTIRQ))
>
> in it?
>
> I think I'll just commit the damn thing. It's hacky, but it's simple,
> and it never got applied because we had smarter suggestions. But the
> smarter suggestions never ended up being applied either, so..
Yeah, IMHO the best would be to apply your patch[1], c/c stable up to
4.9. Nothing prevents applying a better/smarter solution once we
have it. From my side, I can keep testing whatever smart suggestions
people propose. Yet, better to have one fix on our hand than two
fixes flying around.
[1] e. g.
https://git.linuxtv.org/mchehab/experimental.git/commit/?h=v4.15%2bmedia%2bdwc2&id=ccf833fd4a5b99c3d3cf2c09c065670f74a230a7
Regards,
Mauro
next reply other threads:[~2018-07-17 22:21 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 22:21 Mauro Carvalho Chehab [this message]
2018-07-17 22:21 ` dvb usb issues since kernel 4.9 Mauro Carvalho Chehab
2018-07-17 22:21 ` Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2018-07-17 18:07 hannah
2018-07-17 18:07 ` Hanna Hawa
2018-07-17 18:07 ` Hanna Hawa
2018-07-17 17:09 Linus Torvalds
2018-07-17 17:09 ` Linus Torvalds
2018-07-17 17:09 ` Linus Torvalds
2018-07-17 11:54 hannah
2018-07-17 11:54 ` Hanna Hawa
2018-01-13 10:46 Aw: " Mauro Carvalho Chehab
2018-01-13 10:46 ` Mauro Carvalho Chehab
2018-01-13 9:09 Aw: " Mauro Carvalho Chehab
2018-01-13 9:09 ` Mauro Carvalho Chehab
2018-01-12 21:48 Aw: " Eric Dumazet
2018-01-12 21:48 ` Eric Dumazet
2018-01-12 21:13 Aw: " Mauro Carvalho Chehab
2018-01-12 21:13 ` Mauro Carvalho Chehab
2018-01-10 9:45 Aw: " Jesper Dangaard Brouer
2018-01-10 9:45 ` Jesper Dangaard Brouer
2018-01-10 3:02 Mike Galbraith
2018-01-10 3:02 ` Mike Galbraith
2018-01-09 21:48 Aw: " Eric Dumazet
2018-01-09 21:48 ` Eric Dumazet
2018-01-09 21:26 Jesper Dangaard Brouer
2018-01-09 21:26 ` Jesper Dangaard Brouer
2018-01-09 18:58 Aw: " Linus Torvalds
2018-01-09 18:58 ` Linus Torvalds
2018-01-09 17:57 Aw: " Eric Dumazet
2018-01-09 17:57 ` Eric Dumazet
2018-01-09 17:55 Linus Torvalds
2018-01-09 17:55 ` Linus Torvalds
2018-01-09 17:48 Aw: " Linus Torvalds
2018-01-09 17:48 ` Linus Torvalds
2018-01-09 17:42 Mauro Carvalho Chehab
2018-01-09 17:42 ` Mauro Carvalho Chehab
2018-01-09 17:27 Aw: " Eric Dumazet
2018-01-09 17:27 ` Eric Dumazet
2018-01-09 16:51 Aw: " Josef Griebichler
2018-01-09 16:51 ` Josef Griebichler
2018-01-08 22:16 Jesper Dangaard Brouer
2018-01-08 22:16 ` Jesper Dangaard Brouer
2018-01-08 21:44 Aw: " Peter Zijlstra
2018-01-08 21:44 ` Peter Zijlstra
2018-01-08 21:31 Aw: " Jesper Dangaard Brouer
2018-01-08 21:31 ` Jesper Dangaard Brouer
2018-01-08 20:40 Aw: " Jesper Dangaard Brouer
2018-01-08 20:40 ` Jesper Dangaard Brouer
2018-01-08 19:51 Linus Torvalds
2018-01-08 19:51 ` Linus Torvalds
2018-01-08 17:35 Aw: " Alan Stern
2018-01-08 17:35 ` Aw: " Alan Stern
2018-01-08 17:15 Aw: " Josef Griebichler
2018-01-08 17:15 ` Aw: " Josef Griebichler
2018-01-08 16:31 Aw: " Alan Stern
2018-01-08 16:31 ` Alan Stern
2018-01-08 16:26 Josef Griebichler
2018-01-08 16:26 ` Josef Griebichler
2018-01-08 16:10 Alan Stern
2018-01-08 16:10 ` Alan Stern
2018-01-08 9:43 Mauro Carvalho Chehab
2018-01-08 9:43 ` Mauro Carvalho Chehab
[not found] <trinity-35b3a044-b548-4a31-9646-ed9bc83e6846-1513505978471@3c-app-gmx-bs03>
[not found] ` <20171217120634.pmmuhdqyqmbkxrvl@gofer.mess.org>
2017-12-17 13:27 ` Mauro Carvalho Chehab
[not found] ` <trinity-1fa14556-8596-44b1-95cb-b8919d94d2d4-1515251056328@3c-app-gmx-bs15>
2018-01-06 19:54 ` Mauro Carvalho Chehab
2018-01-06 21:07 ` Aw: " Josef Griebichler
2018-01-06 21:44 ` Alan Stern
2018-01-07 11:03 ` Mauro Carvalho Chehab
2018-01-07 15:41 ` Alan Stern
2018-01-07 17:01 ` Aw: " Josef Griebichler
2018-01-07 17:01 ` Josef Griebichler
2018-01-07 21:23 ` Linus Torvalds
2018-01-08 10:02 ` Mauro Carvalho Chehab
2018-01-08 11:59 ` Jesper Dangaard Brouer
2018-01-08 12:53 ` Mauro Carvalho Chehab
2018-01-08 16:25 ` Alan Stern
2018-01-08 17:55 ` Ingo Molnar
2018-01-08 18:32 ` Linus Torvalds
2018-01-08 19:15 ` Alan Stern
2018-01-26 14:17 ` Mauro Carvalho Chehab
2018-01-26 19:37 ` Mauro Carvalho Chehab
2018-01-29 13:51 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718072107.0bfdece8@vela.lan \
--to=mchehab+samsung@kernel.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=griebichler.josef@gmx.at \
--cc=hannah@marvell.com \
--cc=hannes@redhat.com \
--cc=jbrouer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@s-opensource.com \
--cc=mingo@kernel.org \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=omrii@marvell.com \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=stern@rowland.harvard.edu \
--cc=thomas.petazzoni@bootlin.com \
--cc=torvalds@linux-foundation.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.