All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	bridge@lists.linux-foundation.org, wkok@cumulusnetworks.com,
	anuradhak@cumulusnetworks.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 0/2] net: bridge: add support for backup port
Date: Fri, 20 Jul 2018 08:22:22 -0700	[thread overview]
Message-ID: <20180720082222.2f8cb8d2@xeon-e3> (raw)
In-Reply-To: <20180720144826.29892-1-nikolay@cumulusnetworks.com>

On Fri, 20 Jul 2018 17:48:24 +0300
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:

> Hi,
> This set introduces a new bridge port option that allows any port to have
> any other port (in the same bridge of course) as its backup and traffic
> will be forwarded to the backup port when the primary goes down. This is
> mainly used in MLAG and EVPN setups where we have peerlink path which is
> a backup of many (or even all) ports and is a participating bridge port
> itself. There's more detailed information in patch 02. Patch 01 just
> prepares the port sysfs code for options that take raw value. The main
> issues that this set solves are scalability and fallback latency.
> 
> We have used similar code for over 6 months now to bring the fallback
> latency of the backup peerlink down and avoid fdb notification storms.
> Also due to the nature of master devices such setup is currently not
> possible, and last but not least having tens of thousands of fdbs require
> thousands of calls to switch.
> 
> I've also CCed our MLAG experts that have been using similar option.
> 
> Thanks,
>  Nik
> 
> 
> Nikolay Aleksandrov (2):
>   net: bridge: add support for raw sysfs port options
>   net: bridge: add support for backup port
> 
>  include/uapi/linux/if_link.h |  1 +
>  net/bridge/br_forward.c      | 16 ++++++++-
>  net/bridge/br_if.c           | 53 ++++++++++++++++++++++++++++
>  net/bridge/br_netlink.c      | 30 +++++++++++++++-
>  net/bridge/br_private.h      |  3 ++
>  net/bridge/br_sysfs_if.c     | 82 ++++++++++++++++++++++++++++++++++++--------
>  6 files changed, 168 insertions(+), 17 deletions(-)
> 

Not sure why this has to be built into the bridge.
There already is bonding and teaming, why invent yet another?

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	anuradhak@cumulusnetworks.com, bridge@lists.linux-foundation.org,
	wkok@cumulusnetworks.com, davem@davemloft.net
Subject: Re: [PATCH net-next 0/2] net: bridge: add support for backup port
Date: Fri, 20 Jul 2018 08:22:22 -0700	[thread overview]
Message-ID: <20180720082222.2f8cb8d2@xeon-e3> (raw)
In-Reply-To: <20180720144826.29892-1-nikolay@cumulusnetworks.com>

On Fri, 20 Jul 2018 17:48:24 +0300
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:

> Hi,
> This set introduces a new bridge port option that allows any port to have
> any other port (in the same bridge of course) as its backup and traffic
> will be forwarded to the backup port when the primary goes down. This is
> mainly used in MLAG and EVPN setups where we have peerlink path which is
> a backup of many (or even all) ports and is a participating bridge port
> itself. There's more detailed information in patch 02. Patch 01 just
> prepares the port sysfs code for options that take raw value. The main
> issues that this set solves are scalability and fallback latency.
> 
> We have used similar code for over 6 months now to bring the fallback
> latency of the backup peerlink down and avoid fdb notification storms.
> Also due to the nature of master devices such setup is currently not
> possible, and last but not least having tens of thousands of fdbs require
> thousands of calls to switch.
> 
> I've also CCed our MLAG experts that have been using similar option.
> 
> Thanks,
>  Nik
> 
> 
> Nikolay Aleksandrov (2):
>   net: bridge: add support for raw sysfs port options
>   net: bridge: add support for backup port
> 
>  include/uapi/linux/if_link.h |  1 +
>  net/bridge/br_forward.c      | 16 ++++++++-
>  net/bridge/br_if.c           | 53 ++++++++++++++++++++++++++++
>  net/bridge/br_netlink.c      | 30 +++++++++++++++-
>  net/bridge/br_private.h      |  3 ++
>  net/bridge/br_sysfs_if.c     | 82 ++++++++++++++++++++++++++++++++++++--------
>  6 files changed, 168 insertions(+), 17 deletions(-)
> 

Not sure why this has to be built into the bridge.
There already is bonding and teaming, why invent yet another?

  parent reply	other threads:[~2018-07-20 15:22 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 14:48 [Bridge] [PATCH net-next 0/2] net: bridge: add support for backup port Nikolay Aleksandrov
2018-07-20 14:48 ` Nikolay Aleksandrov
2018-07-20 14:48 ` [Bridge] [PATCH net-next 1/2] net: bridge: add support for raw sysfs port options Nikolay Aleksandrov
2018-07-20 14:48   ` Nikolay Aleksandrov
2018-07-20 15:57   ` [Bridge] " Stephen Hemminger
2018-07-20 15:57     ` Stephen Hemminger
2018-07-20 17:14     ` [Bridge] " Nikolay Aleksandrov
2018-07-20 17:14       ` Nikolay Aleksandrov
2018-07-20 17:20       ` [Bridge] " Stephen Hemminger
2018-07-20 17:20         ` Stephen Hemminger
2018-07-20 17:26         ` [Bridge] " Nikolay Aleksandrov
2018-07-20 17:26           ` Nikolay Aleksandrov
2018-07-20 17:47           ` [Bridge] " Nikolay Aleksandrov
2018-07-20 17:47             ` Nikolay Aleksandrov
2018-07-20 21:14             ` [Bridge] " Stephen Hemminger
2018-07-20 21:14               ` Stephen Hemminger
2018-07-22  6:27   ` [Bridge] " David Miller
2018-07-22  6:27     ` David Miller
2018-07-22  7:41     ` [Bridge] " Nikolay Aleksandrov
2018-07-22  7:41       ` Nikolay Aleksandrov
2018-07-20 14:48 ` [Bridge] [PATCH net-next 2/2] net: bridge: add support for backup port Nikolay Aleksandrov
2018-07-20 14:48   ` Nikolay Aleksandrov
2018-07-20 16:02   ` [Bridge] " Stephen Hemminger
2018-07-20 16:02     ` Stephen Hemminger
2018-07-20 16:41     ` [Bridge] " Roopa Prabhu
2018-07-20 16:41       ` Roopa Prabhu
2018-07-23  6:15       ` [Bridge] " Toshiaki Makita
2018-07-23  6:15         ` Toshiaki Makita
2018-07-23  8:03         ` [Bridge] " Nikolay Aleksandrov
2018-07-23  8:03           ` Nikolay Aleksandrov
2018-07-20 15:22 ` Stephen Hemminger [this message]
2018-07-20 15:22   ` [PATCH net-next 0/2] " Stephen Hemminger
2018-07-20 15:26   ` [Bridge] " Nikolay Aleksandrov
2018-07-20 15:26     ` Nikolay Aleksandrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180720082222.2f8cb8d2@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=anuradhak@cumulusnetworks.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=wkok@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.