From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org, wkok@cumulusnetworks.com,
anuradhak@cumulusnetworks.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 1/2] net: bridge: add support for raw sysfs port options
Date: Fri, 20 Jul 2018 14:14:22 -0700 [thread overview]
Message-ID: <20180720141422.34e83e3f@xeon-e3> (raw)
In-Reply-To: <C6B4C1AB-7991-45B3-9649-CC4A36D878A8@cumulusnetworks.com>
On Fri, 20 Jul 2018 20:47:26 +0300
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> On July 20, 2018 8:26:36 PM GMT+03:00, Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> >On July 20, 2018 8:20:44 PM GMT+03:00, Stephen Hemminger
> ><stephen@networkplumber.org> wrote:
> >>On Fri, 20 Jul 2018 20:14:43 +0300
> >>Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> >>
> >>> >Casting away the const on the buf variable is going to cause
> >>warnings
> >>> >and should not be necessary.
> >>> >
> >>>
> >>> It doesn't when it's casted like that, the new line is changed to
> >>null byte so we need to drop
> >>> the const.
> >>
> >>Then change store function to take a char *?
> >
> >Sure, will do.
>
> Acrually I can't change sysfs_ops store prototype.
> That is the reason the bond also casts the ptr.
>
>
>
Ok.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
anuradhak@cumulusnetworks.com, bridge@lists.linux-foundation.org,
wkok@cumulusnetworks.com, davem@davemloft.net
Subject: Re: [PATCH net-next 1/2] net: bridge: add support for raw sysfs port options
Date: Fri, 20 Jul 2018 14:14:22 -0700 [thread overview]
Message-ID: <20180720141422.34e83e3f@xeon-e3> (raw)
In-Reply-To: <C6B4C1AB-7991-45B3-9649-CC4A36D878A8@cumulusnetworks.com>
On Fri, 20 Jul 2018 20:47:26 +0300
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> On July 20, 2018 8:26:36 PM GMT+03:00, Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> >On July 20, 2018 8:20:44 PM GMT+03:00, Stephen Hemminger
> ><stephen@networkplumber.org> wrote:
> >>On Fri, 20 Jul 2018 20:14:43 +0300
> >>Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> >>
> >>> >Casting away the const on the buf variable is going to cause
> >>warnings
> >>> >and should not be necessary.
> >>> >
> >>>
> >>> It doesn't when it's casted like that, the new line is changed to
> >>null byte so we need to drop
> >>> the const.
> >>
> >>Then change store function to take a char *?
> >
> >Sure, will do.
>
> Acrually I can't change sysfs_ops store prototype.
> That is the reason the bond also casts the ptr.
>
>
>
Ok.
next prev parent reply other threads:[~2018-07-20 21:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 14:48 [Bridge] [PATCH net-next 0/2] net: bridge: add support for backup port Nikolay Aleksandrov
2018-07-20 14:48 ` Nikolay Aleksandrov
2018-07-20 14:48 ` [Bridge] [PATCH net-next 1/2] net: bridge: add support for raw sysfs port options Nikolay Aleksandrov
2018-07-20 14:48 ` Nikolay Aleksandrov
2018-07-20 15:57 ` [Bridge] " Stephen Hemminger
2018-07-20 15:57 ` Stephen Hemminger
2018-07-20 17:14 ` [Bridge] " Nikolay Aleksandrov
2018-07-20 17:14 ` Nikolay Aleksandrov
2018-07-20 17:20 ` [Bridge] " Stephen Hemminger
2018-07-20 17:20 ` Stephen Hemminger
2018-07-20 17:26 ` [Bridge] " Nikolay Aleksandrov
2018-07-20 17:26 ` Nikolay Aleksandrov
2018-07-20 17:47 ` [Bridge] " Nikolay Aleksandrov
2018-07-20 17:47 ` Nikolay Aleksandrov
2018-07-20 21:14 ` Stephen Hemminger [this message]
2018-07-20 21:14 ` Stephen Hemminger
2018-07-22 6:27 ` [Bridge] " David Miller
2018-07-22 6:27 ` David Miller
2018-07-22 7:41 ` [Bridge] " Nikolay Aleksandrov
2018-07-22 7:41 ` Nikolay Aleksandrov
2018-07-20 14:48 ` [Bridge] [PATCH net-next 2/2] net: bridge: add support for backup port Nikolay Aleksandrov
2018-07-20 14:48 ` Nikolay Aleksandrov
2018-07-20 16:02 ` [Bridge] " Stephen Hemminger
2018-07-20 16:02 ` Stephen Hemminger
2018-07-20 16:41 ` [Bridge] " Roopa Prabhu
2018-07-20 16:41 ` Roopa Prabhu
2018-07-23 6:15 ` [Bridge] " Toshiaki Makita
2018-07-23 6:15 ` Toshiaki Makita
2018-07-23 8:03 ` [Bridge] " Nikolay Aleksandrov
2018-07-23 8:03 ` Nikolay Aleksandrov
2018-07-20 15:22 ` [Bridge] [PATCH net-next 0/2] " Stephen Hemminger
2018-07-20 15:22 ` Stephen Hemminger
2018-07-20 15:26 ` [Bridge] " Nikolay Aleksandrov
2018-07-20 15:26 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720141422.34e83e3f@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=anuradhak@cumulusnetworks.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=wkok@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.