From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
linux-mips@linux-mips.org, alsa-devel@alsa-project.org,
Neil Armstrong <narmstrong@baylibre.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
James Hogan <jhogan@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Russell King <linux@armlinux.org.uk>,
Donglin Peng <dolinux.peng@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Mark Brown <broonie@kernel.org>,
linux-tegra@vger.kernel.org, Han Xu <han.xu@nxp.com>,
Jaroslav Kysela <perex@perex.cz>,
linux-arm-kernel@lists.infradead.org,
Bhumika Goyal <bhumirks@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Liam
Subject: Re: [PATCH] ASoC: wm9712: fix replace codec to component
Date: Fri, 20 Jul 2018 14:22:58 +0100 [thread overview]
Message-ID: <20180720132258.GD18740@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <87effy48lz.wl-kuninori.morimoto.gx@renesas.com>
On Fri, Jul 20, 2018 at 08:30:41AM +0000, Kuninori Morimoto wrote:
>
> Hi Marcel
>
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component")
> > "wm9712-codec" got renamed to "wm9712-component", however, this change
> > never got propagated down to the actual board/platform drivers. E.g. on
> > Colibri T20 this lead to the following spew upon boot with sound/touch
> > being broken:
>
> Oops, my bad...
> The platform_driver name is not important,
> how about simply rename back it to "wm9712-codec" ?
>
Yeah I would agree here wm9712-component isn't great as a name
for board files etc. Lets rename back to wm9712-codec for these
specific bits.
Thanks,
Charles
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Marcel Ziswiler <marcel@ziswiler.com>,
<alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
<linux-mips@linux-mips.org>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
James Hogan <jhogan@kernel.org>,
"Philippe Ombredanne" <pombredanne@nexb.com>,
Bhumika Goyal <bhumirks@gmail.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ralf Baechle <ralf@linux-mips.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Takashi Iwai <tiwai@suse.com>, Paul Burton <paul.burton@mips.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
"Daniel Mack" <daniel@zonque.org>,
Manuel Lauss <manuel.lauss@gmail.com>,
Russell King <linux@armlinux.org.uk>,
<linux-arm-kernel@lists.infradead.org>,
"Jaroslav Kysela" <perex@perex.cz>,
Robert Jarzmik <robert.jarzmik@free.fr>,
<patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>,
Han Xu <han.xu@nxp.com>, Donglin Peng <dolinux.peng@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Boris Brezillon <boris.brezillon@bootlin.com>
Subject: Re: [PATCH] ASoC: wm9712: fix replace codec to component
Date: Fri, 20 Jul 2018 14:22:58 +0100 [thread overview]
Message-ID: <20180720132258.GD18740@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <87effy48lz.wl-kuninori.morimoto.gx@renesas.com>
On Fri, Jul 20, 2018 at 08:30:41AM +0000, Kuninori Morimoto wrote:
>
> Hi Marcel
>
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component")
> > "wm9712-codec" got renamed to "wm9712-component", however, this change
> > never got propagated down to the actual board/platform drivers. E.g. on
> > Colibri T20 this lead to the following spew upon boot with sound/touch
> > being broken:
>
> Oops, my bad...
> The platform_driver name is not important,
> how about simply rename back it to "wm9712-codec" ?
>
Yeah I would agree here wm9712-component isn't great as a name
for board files etc. Lets rename back to wm9712-codec for these
specific bits.
Thanks,
Charles
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Marcel Ziswiler <marcel@ziswiler.com>,
alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
linux-mips@linux-mips.org,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
James Hogan <jhogan@kernel.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Bhumika Goyal <bhumirks@gmail.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ralf Baechle <ralf@linux-mips.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Takashi Iwai <tiwai@suse.com>, Paul Burton <paul.burton@mips.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Lee Jones <lee.jones@linaro.org>, Daniel Mack <daniel@zonque.org>,
Manuel Lauss <manuel.lauss@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Jaroslav Kysela <perex@perex.cz>,
Robert Jarzmik <robert.jarzmik@free.fr>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
Han Xu <han.xu@nxp.com>, Donglin Peng <dolinux.peng@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Boris Brezillon <boris.brezillon@bootlin.com>
Subject: Re: [PATCH] ASoC: wm9712: fix replace codec to component
Date: Fri, 20 Jul 2018 14:22:58 +0100 [thread overview]
Message-ID: <20180720132258.GD18740@imbe.wolfsonmicro.main> (raw)
Message-ID: <20180720132258.BiDDHoH3IvldNJXx68otvBV_CslVDD2ES2PrnbNYVy8@z> (raw)
In-Reply-To: <87effy48lz.wl-kuninori.morimoto.gx@renesas.com>
On Fri, Jul 20, 2018 at 08:30:41AM +0000, Kuninori Morimoto wrote:
>
> Hi Marcel
>
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component")
> > "wm9712-codec" got renamed to "wm9712-component", however, this change
> > never got propagated down to the actual board/platform drivers. E.g. on
> > Colibri T20 this lead to the following spew upon boot with sound/touch
> > being broken:
>
> Oops, my bad...
> The platform_driver name is not important,
> how about simply rename back it to "wm9712-codec" ?
>
Yeah I would agree here wm9712-component isn't great as a name
for board files etc. Lets rename back to wm9712-codec for these
specific bits.
Thanks,
Charles
WARNING: multiple messages have this Message-ID (diff)
From: ckeepax@opensource.cirrus.com (Charles Keepax)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: wm9712: fix replace codec to component
Date: Fri, 20 Jul 2018 14:22:58 +0100 [thread overview]
Message-ID: <20180720132258.GD18740@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <87effy48lz.wl-kuninori.morimoto.gx@renesas.com>
On Fri, Jul 20, 2018 at 08:30:41AM +0000, Kuninori Morimoto wrote:
>
> Hi Marcel
>
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component")
> > "wm9712-codec" got renamed to "wm9712-component", however, this change
> > never got propagated down to the actual board/platform drivers. E.g. on
> > Colibri T20 this lead to the following spew upon boot with sound/touch
> > being broken:
>
> Oops, my bad...
> The platform_driver name is not important,
> how about simply rename back it to "wm9712-codec" ?
>
Yeah I would agree here wm9712-component isn't great as a name
for board files etc. Lets rename back to wm9712-codec for these
specific bits.
Thanks,
Charles
next prev parent reply other threads:[~2018-07-20 13:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 7:51 [PATCH] ASoC: wm9712: fix replace codec to component Marcel Ziswiler
2018-07-20 7:51 ` Marcel Ziswiler
2018-07-20 7:51 ` Marcel Ziswiler
2018-07-20 8:30 ` Kuninori Morimoto
2018-07-20 8:30 ` Kuninori Morimoto
2018-07-20 8:30 ` Kuninori Morimoto
2018-07-20 8:30 ` Kuninori Morimoto
2018-07-20 9:20 ` Marcel Ziswiler
2018-07-20 9:20 ` Marcel Ziswiler
2018-07-20 9:20 ` Marcel Ziswiler
2018-07-22 23:56 ` Kuninori Morimoto
2018-07-22 23:56 ` Kuninori Morimoto
2018-07-22 23:56 ` Kuninori Morimoto
2018-07-22 23:56 ` Kuninori Morimoto
2018-07-20 13:22 ` Charles Keepax [this message]
2018-07-20 13:22 ` Charles Keepax
2018-07-20 13:22 ` Charles Keepax
2018-07-20 13:22 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720132258.GD18740@imbe.wolfsonmicro.main \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=bhumirks@gmail.com \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=dolinux.peng@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=han.xu@nxp.com \
--cc=haojian.zhuang@gmail.com \
--cc=jhogan@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kstewart@linuxfoundation.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marcel.ziswiler@toradex.com \
--cc=narmstrong@baylibre.com \
--cc=perex@perex.cz \
--cc=robert.jarzmik@free.fr \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.