* Re: next-20180723 build: 2 failures 11 warnings (next-20180723) [not found] <E1fheAy-0003tU-Dq@optimist> @ 2018-07-23 18:11 ` Mark Brown 2018-07-23 18:25 ` Mark Brown 1 sibling, 0 replies; 8+ messages in thread From: Mark Brown @ 2018-07-23 18:11 UTC (permalink / raw) To: Catalin Marinas, Will Deacon Cc: linaro-kernel, khilman, kernel-build-reports, linux-next, matthew.hart, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 779 bytes --] On Mon, Jul 23, 2018 at 05:59:12PM +0100, Build bot for Mark Brown wrote: Today's -next fails to build an arm64 allmodconfig with: > arm64-allmodconfig > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! using aarch64-linux-gnu-gcc (Linaro GCC 5.3-2016.05) 5.3.1 20160412 however it builds perfectly fine with aarch64-linux-gnu-gcc (Linaro GCC 6.2-2016.11) 6.2.1 20161016 which honestly seems like a sensible and worthwhile upgrade at this point anyway given that it's a year and a half old so I'm going to do that for my builder (perhaps even jump on a newer version) but it seemed worth highlighting in case this is considered undesirable. A similar issue is hitting on KernelCI, we should probably look at upgrading the toolchain there too. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* next-20180723 build: 2 failures 11 warnings (next-20180723) @ 2018-07-23 18:11 ` Mark Brown 0 siblings, 0 replies; 8+ messages in thread From: Mark Brown @ 2018-07-23 18:11 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jul 23, 2018 at 05:59:12PM +0100, Build bot for Mark Brown wrote: Today's -next fails to build an arm64 allmodconfig with: > arm64-allmodconfig > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! using aarch64-linux-gnu-gcc (Linaro GCC 5.3-2016.05) 5.3.1 20160412 however it builds perfectly fine with aarch64-linux-gnu-gcc (Linaro GCC 6.2-2016.11) 6.2.1 20161016 which honestly seems like a sensible and worthwhile upgrade at this point anyway given that it's a year and a half old so I'm going to do that for my builder (perhaps even jump on a newer version) but it seemed worth highlighting in case this is considered undesirable. A similar issue is hitting on KernelCI, we should probably look at upgrading the toolchain there too. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180723/f22badc9/attachment-0001.sig> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: next-20180723 build: 2 failures 11 warnings (next-20180723) 2018-07-23 18:11 ` Mark Brown @ 2018-07-24 9:16 ` Will Deacon -1 siblings, 0 replies; 8+ messages in thread From: Will Deacon @ 2018-07-24 9:16 UTC (permalink / raw) To: Mark Brown Cc: linaro-kernel, kernel-build-reports, Catalin Marinas, khilman, linux-next, matthew.hart, linux-arm-kernel On Mon, Jul 23, 2018 at 07:11:50PM +0100, Mark Brown wrote: > On Mon, Jul 23, 2018 at 05:59:12PM +0100, Build bot for Mark Brown wrote: > > Today's -next fails to build an arm64 allmodconfig with: > > > arm64-allmodconfig > > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! > > using > > aarch64-linux-gnu-gcc (Linaro GCC 5.3-2016.05) 5.3.1 20160412 > > however it builds perfectly fine with > > aarch64-linux-gnu-gcc (Linaro GCC 6.2-2016.11) 6.2.1 20161016 > > which honestly seems like a sensible and worthwhile upgrade at this > point anyway given that it's a year and a half old so I'm going to do > that for my builder (perhaps even jump on a newer version) but it seemed > worth highlighting in case this is considered undesirable. A similar > issue is hitting on KernelCI, we should probably look at upgrading the > toolchain there too. Hmm, it looks to me like this comes about because xen/privcmd.c is being built as a module, but contains a call to set_pte_at() with a special pte: pte_t pte = pte_mkspecial(pfn_pte(page_to_pfn(page), r->prot)); set_pte_at(r->mm, addr, ptep, pte); which on arm64 contains: if (pte_present(pte) && pte_user_exec(pte) && !pte_special(pte)) __sync_icache_dcache(pte); so GCC 6 can optimise away the call to the non-exported symbol, but GCC 5 has trouble. What I don't understand is why this suddenly cropped up. Did GCC 5 build linux-next arm64 allmodconfig last week? Cheers, Will ^ permalink raw reply [flat|nested] 8+ messages in thread
* next-20180723 build: 2 failures 11 warnings (next-20180723) @ 2018-07-24 9:16 ` Will Deacon 0 siblings, 0 replies; 8+ messages in thread From: Will Deacon @ 2018-07-24 9:16 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jul 23, 2018 at 07:11:50PM +0100, Mark Brown wrote: > On Mon, Jul 23, 2018 at 05:59:12PM +0100, Build bot for Mark Brown wrote: > > Today's -next fails to build an arm64 allmodconfig with: > > > arm64-allmodconfig > > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! > > using > > aarch64-linux-gnu-gcc (Linaro GCC 5.3-2016.05) 5.3.1 20160412 > > however it builds perfectly fine with > > aarch64-linux-gnu-gcc (Linaro GCC 6.2-2016.11) 6.2.1 20161016 > > which honestly seems like a sensible and worthwhile upgrade at this > point anyway given that it's a year and a half old so I'm going to do > that for my builder (perhaps even jump on a newer version) but it seemed > worth highlighting in case this is considered undesirable. A similar > issue is hitting on KernelCI, we should probably look at upgrading the > toolchain there too. Hmm, it looks to me like this comes about because xen/privcmd.c is being built as a module, but contains a call to set_pte_at() with a special pte: pte_t pte = pte_mkspecial(pfn_pte(page_to_pfn(page), r->prot)); set_pte_at(r->mm, addr, ptep, pte); which on arm64 contains: if (pte_present(pte) && pte_user_exec(pte) && !pte_special(pte)) __sync_icache_dcache(pte); so GCC 6 can optimise away the call to the non-exported symbol, but GCC 5 has trouble. What I don't understand is why this suddenly cropped up. Did GCC 5 build linux-next arm64 allmodconfig last week? Cheers, Will ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CAH+k93GQRKO8s+0qkSH+d_2GkapMAp8C776Q4bZZnL37M5MBCw@mail.gmail.com>]
* Re: next-20180723 build: 2 failures 11 warnings (next-20180723) [not found] ` <CAH+k93GQRKO8s+0qkSH+d_2GkapMAp8C776Q4bZZnL37M5MBCw@mail.gmail.com> @ 2018-07-24 9:34 ` Matt Hart 0 siblings, 0 replies; 8+ messages in thread From: Matt Hart @ 2018-07-24 9:34 UTC (permalink / raw) To: Will Deacon Cc: linaro-kernel, Kernel Build Reports Mailman List, Catalin Marinas, Kevin Hilman, Mark Brown, linux-next, linux-arm-kernel On 24 July 2018 at 10:32, Matt Hart <matthew.hart@linaro.org> wrote: > > > > On 24 July 2018 at 10:16, Will Deacon <will.deacon@arm.com> wrote: >> >> On Mon, Jul 23, 2018 at 07:11:50PM +0100, Mark Brown wrote: >> > On Mon, Jul 23, 2018 at 05:59:12PM +0100, Build bot for Mark Brown wrote: >> > >> > Today's -next fails to build an arm64 allmodconfig with: >> > >> > > arm64-allmodconfig >> > > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! >> > >> > using >> > >> > aarch64-linux-gnu-gcc (Linaro GCC 5.3-2016.05) 5.3.1 20160412 >> > >> > however it builds perfectly fine with >> > >> > aarch64-linux-gnu-gcc (Linaro GCC 6.2-2016.11) 6.2.1 20161016 >> > >> > which honestly seems like a sensible and worthwhile upgrade at this >> > point anyway given that it's a year and a half old so I'm going to do >> > that for my builder (perhaps even jump on a newer version) but it seemed >> > worth highlighting in case this is considered undesirable. A similar >> > issue is hitting on KernelCI, we should probably look at upgrading the >> > toolchain there too. >> >> Hmm, it looks to me like this comes about because xen/privcmd.c is being >> built as a module, but contains a call to set_pte_at() with a special pte: >> >> pte_t pte = pte_mkspecial(pfn_pte(page_to_pfn(page), r->prot)); >> >> set_pte_at(r->mm, addr, ptep, pte); >> >> which on arm64 contains: >> >> if (pte_present(pte) && pte_user_exec(pte) && !pte_special(pte)) >> __sync_icache_dcache(pte); >> >> so GCC 6 can optimise away the call to the non-exported symbol, but GCC 5 >> has trouble. >> >> What I don't understand is why this suddenly cropped up. Did GCC 5 build >> linux-next arm64 allmodconfig last week? > > > KernelCI uses GCC5 for ARM64 and xen-privcmd.ko has been broken in linux-next (and mainline) allmodconfig for a long time Bloody gmail and it's HTML mean't this didn't get delivered to linux-arm-kernel list. Resent. > >> >> >> Cheers, >> >> Will > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* next-20180723 build: 2 failures 11 warnings (next-20180723) @ 2018-07-24 9:34 ` Matt Hart 0 siblings, 0 replies; 8+ messages in thread From: Matt Hart @ 2018-07-24 9:34 UTC (permalink / raw) To: linux-arm-kernel On 24 July 2018 at 10:32, Matt Hart <matthew.hart@linaro.org> wrote: > > > > On 24 July 2018 at 10:16, Will Deacon <will.deacon@arm.com> wrote: >> >> On Mon, Jul 23, 2018 at 07:11:50PM +0100, Mark Brown wrote: >> > On Mon, Jul 23, 2018 at 05:59:12PM +0100, Build bot for Mark Brown wrote: >> > >> > Today's -next fails to build an arm64 allmodconfig with: >> > >> > > arm64-allmodconfig >> > > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! >> > >> > using >> > >> > aarch64-linux-gnu-gcc (Linaro GCC 5.3-2016.05) 5.3.1 20160412 >> > >> > however it builds perfectly fine with >> > >> > aarch64-linux-gnu-gcc (Linaro GCC 6.2-2016.11) 6.2.1 20161016 >> > >> > which honestly seems like a sensible and worthwhile upgrade at this >> > point anyway given that it's a year and a half old so I'm going to do >> > that for my builder (perhaps even jump on a newer version) but it seemed >> > worth highlighting in case this is considered undesirable. A similar >> > issue is hitting on KernelCI, we should probably look at upgrading the >> > toolchain there too. >> >> Hmm, it looks to me like this comes about because xen/privcmd.c is being >> built as a module, but contains a call to set_pte_at() with a special pte: >> >> pte_t pte = pte_mkspecial(pfn_pte(page_to_pfn(page), r->prot)); >> >> set_pte_at(r->mm, addr, ptep, pte); >> >> which on arm64 contains: >> >> if (pte_present(pte) && pte_user_exec(pte) && !pte_special(pte)) >> __sync_icache_dcache(pte); >> >> so GCC 6 can optimise away the call to the non-exported symbol, but GCC 5 >> has trouble. >> >> What I don't understand is why this suddenly cropped up. Did GCC 5 build >> linux-next arm64 allmodconfig last week? > > > KernelCI uses GCC5 for ARM64 and xen-privcmd.ko has been broken in linux-next (and mainline) allmodconfig for a long time Bloody gmail and it's HTML mean't this didn't get delivered to linux-arm-kernel list. Resent. > >> >> >> Cheers, >> >> Will > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: next-20180723 build: 2 failures 11 warnings (next-20180723) [not found] <E1fheAy-0003tU-Dq@optimist> @ 2018-07-23 18:25 ` Mark Brown 2018-07-23 18:25 ` Mark Brown 1 sibling, 0 replies; 8+ messages in thread From: Mark Brown @ 2018-07-23 18:25 UTC (permalink / raw) To: Andrew Morton, David Rientjes, Russell King Cc: linaro-kernel, kernel-build-reports, Davidlohr Bueso, linux-next, linux-mm, Alexey Dobriyan, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 852 bytes --] On Mon, Jul 23, 2018 at 05:59:12PM +0100, Build bot for Mark Brown wrote: Today's -next fails to build an arm allnoconfig (and a bunch of other arm configs from the look of some of the other builder reports) with: > arm-allnoconfig > ../mm/vmacache.c:14:39: error: 'PMD_SHIFT' undeclared (first use in this function) > ../mm/vmacache.c:14:39: error: 'PMD_SHIFT' undeclared (first use in this function) > ../mm/vmacache.c:127:26: error: 'addr' undeclared (first use in this function) > ../mm/vmacache.c:14:39: error: 'PMD_SHIFT' undeclared (first use in this function) due to 5d2f33872046e (mm, vmacache: hash addresses based on pmd) which uses PMD_SHIFT rather than PAGE_SHIFT for VMACACHE_HASH() but that's not defined in at least !MMU arm configs. There is a reference to it in arm/pgtable-nommu.h but only in comments with FIXMEs next to them. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* next-20180723 build: 2 failures 11 warnings (next-20180723) @ 2018-07-23 18:25 ` Mark Brown 0 siblings, 0 replies; 8+ messages in thread From: Mark Brown @ 2018-07-23 18:25 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jul 23, 2018 at 05:59:12PM +0100, Build bot for Mark Brown wrote: Today's -next fails to build an arm allnoconfig (and a bunch of other arm configs from the look of some of the other builder reports) with: > arm-allnoconfig > ../mm/vmacache.c:14:39: error: 'PMD_SHIFT' undeclared (first use in this function) > ../mm/vmacache.c:14:39: error: 'PMD_SHIFT' undeclared (first use in this function) > ../mm/vmacache.c:127:26: error: 'addr' undeclared (first use in this function) > ../mm/vmacache.c:14:39: error: 'PMD_SHIFT' undeclared (first use in this function) due to 5d2f33872046e (mm, vmacache: hash addresses based on pmd) which uses PMD_SHIFT rather than PAGE_SHIFT for VMACACHE_HASH() but that's not defined in at least !MMU arm configs. There is a reference to it in arm/pgtable-nommu.h but only in comments with FIXMEs next to them. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180723/3421abd5/attachment.sig> ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-07-24 9:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1fheAy-0003tU-Dq@optimist>
2018-07-23 18:11 ` next-20180723 build: 2 failures 11 warnings (next-20180723) Mark Brown
2018-07-23 18:11 ` Mark Brown
2018-07-24 9:16 ` Will Deacon
2018-07-24 9:16 ` Will Deacon
[not found] ` <CAH+k93GQRKO8s+0qkSH+d_2GkapMAp8C776Q4bZZnL37M5MBCw@mail.gmail.com>
2018-07-24 9:34 ` Matt Hart
2018-07-24 9:34 ` Matt Hart
2018-07-23 18:25 ` Mark Brown
2018-07-23 18:25 ` Mark Brown
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.