All of lore.kernel.org
 help / color / mirror / Atom feed
From: mingo@kernel.org (Ingo Molnar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: asm/tlb.h: Fix build error implicit func declaration
Date: Wed, 25 Jul 2018 12:09:53 +0200	[thread overview]
Message-ID: <20180725100953.GA26481@gmail.com> (raw)
In-Reply-To: <20180725095557.19668-1-anders.roxell@linaro.org>


* Anders Roxell <anders.roxell@linaro.org> wrote:

> Building on arm 32 with LPAE enabled we don't include asm-generic/tlb.h,
> where we have tlb_flush_remove_tables_local and tlb_flush_remove_tables
> defined.
> mm/memory.c: In function ?tlb_remove_table_smp_sync?:
> mm/memory.c:339:2: error: implicit declaration of function ?tlb_flush_remove_tables_local?; did you mean ?tlb_remove_table?? [-Werror=implicit-function-declaration]
>   tlb_flush_remove_tables_local(mm);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   tlb_remove_table
> mm/memory.c: In function ?tlb_table_flush?:
> mm/memory.c:372:2: error: implicit declaration of function ?tlb_flush_remove_tables?; did you mean ?tlb_remove_table?? [-Werror=implicit-function-declaration]
>   tlb_flush_remove_tables(tlb->mm);
>   ^~~~~~~~~~~~~~~~~~~~~~~
>   tlb_remove_table
> 
> To fix this issue we define them in arm 32's specific asm/tlb.h file.
> 
> Fixes: 2ff6ddf19c0e ("x86/mm/tlb: Leave lazy TLB mode at page table free time")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> 
> Ingo, would it make sense for you to pick it up into the x86 tree since
> that contains the bug ?

Done and sorry about that! Will push your fix out to -next as well ASAP.

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: riel@surriel.com, peterz@infradead.org, songliubraving@fb.com,
	linux@armlinux.org.uk, dave.hansen@intel.com, x86@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: asm/tlb.h: Fix build error implicit func declaration
Date: Wed, 25 Jul 2018 12:09:53 +0200	[thread overview]
Message-ID: <20180725100953.GA26481@gmail.com> (raw)
In-Reply-To: <20180725095557.19668-1-anders.roxell@linaro.org>


* Anders Roxell <anders.roxell@linaro.org> wrote:

> Building on arm 32 with LPAE enabled we don't include asm-generic/tlb.h,
> where we have tlb_flush_remove_tables_local and tlb_flush_remove_tables
> defined.
> mm/memory.c: In function ‘tlb_remove_table_smp_sync’:
> mm/memory.c:339:2: error: implicit declaration of function ‘tlb_flush_remove_tables_local’; did you mean ‘tlb_remove_table’? [-Werror=implicit-function-declaration]
>   tlb_flush_remove_tables_local(mm);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   tlb_remove_table
> mm/memory.c: In function ‘tlb_table_flush’:
> mm/memory.c:372:2: error: implicit declaration of function ‘tlb_flush_remove_tables’; did you mean ‘tlb_remove_table’? [-Werror=implicit-function-declaration]
>   tlb_flush_remove_tables(tlb->mm);
>   ^~~~~~~~~~~~~~~~~~~~~~~
>   tlb_remove_table
> 
> To fix this issue we define them in arm 32's specific asm/tlb.h file.
> 
> Fixes: 2ff6ddf19c0e ("x86/mm/tlb: Leave lazy TLB mode at page table free time")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> 
> Ingo, would it make sense for you to pick it up into the x86 tree since
> that contains the bug ?

Done and sorry about that! Will push your fix out to -next as well ASAP.

Thanks,

	Ingo

  reply	other threads:[~2018-07-25 10:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25  9:55 [PATCH] arm: asm/tlb.h: Fix build error implicit func declaration Anders Roxell
2018-07-25  9:55 ` Anders Roxell
2018-07-25 10:09 ` Ingo Molnar [this message]
2018-07-25 10:09   ` Ingo Molnar
2018-07-25 14:37 ` [tip:x86/mm] arm/asm/tlb.h: " tip-bot for Anders Roxell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180725100953.GA26481@gmail.com \
    --to=mingo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.