From: Christoph Hellwig <hch@lst.de>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Christoph Hellwig <hch@lst.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
"Wesley W . Terpstra" <wesley@sifive.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/3] PCI: add a callback to struct pci_host_bridge for adding a new device
Date: Mon, 6 Aug 2018 14:30:51 +0200 [thread overview]
Message-ID: <20180806123051.GA6997@lst.de> (raw)
In-Reply-To: <20180806112310.GB18685@e107981-ln.cambridge.arm.com>
On Mon, Aug 06, 2018 at 12:23:10PM +0100, Lorenzo Pieralisi wrote:
> > pci_configure_device(dev);
> > @@ -2328,6 +2329,11 @@ void pci_device_add(struct pci_dev *dev, struct pci_bus *bus)
> > ret = pcibios_add_device(dev);
> > WARN_ON(ret < 0);
> >
> > + if (host->add_device) {
> > + ret = host->add_device(dev);
> > + WARN_ON(ret < 0);
> > + }
>
> This looks fine; we could go a step further and make the hunk above
> the default (weak) implementation of pcibios_add_device() that is
> currently a NOP returning 0, I will remove it for v4.20.
I'd love to see pcibios_add_device go away entirely. But I wonder how to
get setup the pci_host_bridge pointer for the remaining architectures that
still implement it. I did look for any easy way but couldn't find one.
But then I don't really know this area of the PCI code too well.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [PATCH 1/3] PCI: add a callback to struct pci_host_bridge for adding a new device
Date: Mon, 6 Aug 2018 14:30:51 +0200 [thread overview]
Message-ID: <20180806123051.GA6997@lst.de> (raw)
In-Reply-To: <20180806112310.GB18685@e107981-ln.cambridge.arm.com>
On Mon, Aug 06, 2018 at 12:23:10PM +0100, Lorenzo Pieralisi wrote:
> > pci_configure_device(dev);
> > @@ -2328,6 +2329,11 @@ void pci_device_add(struct pci_dev *dev, struct pci_bus *bus)
> > ret = pcibios_add_device(dev);
> > WARN_ON(ret < 0);
> >
> > + if (host->add_device) {
> > + ret = host->add_device(dev);
> > + WARN_ON(ret < 0);
> > + }
>
> This looks fine; we could go a step further and make the hunk above
> the default (weak) implementation of pcibios_add_device() that is
> currently a NOP returning 0, I will remove it for v4.20.
I'd love to see pcibios_add_device go away entirely. But I wonder how to
get setup the pci_host_bridge pointer for the remaining architectures that
still implement it. I did look for any easy way but couldn't find one.
But then I don't really know this area of the PCI code too well.
next prev parent reply other threads:[~2018-08-06 14:34 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 10:13 add support for Xilinx PCIe root ports on RISC-V v3 Christoph Hellwig
2018-08-04 10:13 ` Christoph Hellwig
2018-08-04 10:14 ` [PATCH 1/3] PCI: add a callback to struct pci_host_bridge for adding a new device Christoph Hellwig
2018-08-04 10:14 ` Christoph Hellwig
2018-08-06 11:23 ` Lorenzo Pieralisi
2018-08-06 11:23 ` Lorenzo Pieralisi
2018-08-06 12:30 ` Christoph Hellwig [this message]
2018-08-06 12:30 ` Christoph Hellwig
2018-08-06 13:54 ` Arnd Bergmann
2018-08-06 13:54 ` Arnd Bergmann
2018-08-06 14:55 ` Lorenzo Pieralisi
2018-08-06 14:55 ` Lorenzo Pieralisi
2018-08-06 19:49 ` Arnd Bergmann
2018-08-06 19:49 ` Arnd Bergmann
2018-08-04 10:14 ` [PATCH 2/3] PCI/xilinx: Work-around for hardware DMA limit (32 bits) Christoph Hellwig
2018-08-04 10:14 ` Christoph Hellwig
2018-08-05 20:02 ` Wesley Terpstra
2018-08-05 20:02 ` Wesley Terpstra
2018-08-06 12:35 ` Christoph Hellwig
2018-08-06 12:35 ` Christoph Hellwig
2018-08-06 13:40 ` Lorenzo Pieralisi
2018-08-06 13:40 ` Lorenzo Pieralisi
2018-08-06 15:33 ` Christoph Hellwig
2018-08-06 15:33 ` Christoph Hellwig
2018-08-06 16:21 ` Wesley Terpstra
2018-08-06 16:21 ` Wesley Terpstra
2018-08-06 16:34 ` Christoph Hellwig
2018-08-06 16:34 ` Christoph Hellwig
2018-08-04 10:14 ` [PATCH 3/3] PCI/xilinx: Depend on OF instead of the ARCH Christoph Hellwig
2018-08-04 10:14 ` Christoph Hellwig
2018-08-06 10:52 ` Lorenzo Pieralisi
2018-08-06 10:52 ` Lorenzo Pieralisi
-- strict thread matches above, loose matches on Subject: below --
2018-08-01 15:14 add support for Xilinx PCIe root ports on RISC-V v2 Christoph Hellwig
2018-08-01 15:14 ` [PATCH 1/3] PCI: add a callback to struct pci_host_bridge for adding a new device Christoph Hellwig
2018-08-01 15:14 ` Christoph Hellwig
2018-08-02 16:54 ` Lorenzo Pieralisi
2018-08-02 16:54 ` Lorenzo Pieralisi
2018-08-04 10:11 ` Christoph Hellwig
2018-08-04 10:11 ` Christoph Hellwig
2018-08-15 19:52 ` Bjorn Helgaas
2018-08-15 19:52 ` Bjorn Helgaas
2018-08-16 20:59 ` Bjorn Helgaas
2018-08-16 20:59 ` Bjorn Helgaas
2018-08-16 21:04 ` Arnd Bergmann
2018-08-16 21:04 ` Arnd Bergmann
2018-08-17 15:25 ` Lorenzo Pieralisi
2018-08-17 15:25 ` Lorenzo Pieralisi
2018-08-17 15:47 ` Arnd Bergmann
2018-08-17 15:47 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806123051.GA6997@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=palmer@dabbelt.com \
--cc=wesley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.