* [LTP] [PATCH 2/2] netstress: Unifi help
2018-08-16 17:20 [LTP] [PATCH 1/2] netstress: Update help for -m behavior for client and server Petr Vorel
@ 2018-08-16 17:20 ` Petr Vorel
2018-08-16 17:23 ` Petr Vorel
2018-08-17 11:12 ` [LTP] [PATCH 1/2] netstress: Update help for -m behavior for client and server Alexey Kodanev
1 sibling, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2018-08-16 17:20 UTC (permalink / raw)
To: ltp
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/network/netstress/netstress.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/testcases/network/netstress/netstress.c b/testcases/network/netstress/netstress.c
index 0de3fde1a..21d7245d4 100644
--- a/testcases/network/netstress/netstress.c
+++ b/testcases/network/netstress/netstress.c
@@ -994,7 +994,7 @@ static struct tst_option options[] = {
{"g:", &tcp_port, "-g x x - server port"},
{"b:", &barg, "-b x x - low latency busy poll timeout"},
{"T:", &type, "-T x tcp (default), udp, udp_lite, dccp, sctp"},
- {"z", &zcopy, "-z enable SO_ZEROCOPY\n"},
+ {"z", &zcopy, "-z Enable SO_ZEROCOPY\n"},
{"H:", &server_addr, "Client:\n-H x Server name or IP address"},
{"l", &client_mode, "-l Become client, default is server"},
@@ -1003,13 +1003,13 @@ static struct tst_option options[] = {
{"n:", &narg, "-n x Client message size"},
{"N:", &Narg, "-N x Server message size"},
{"m:", &Targ, "-m x Reply timeout in microsec (for udp, udp_lite, dccp is timeout always 100 microsec)"},
- {"d:", &rpath, "-d x x is a path to file where result is saved"},
+ {"d:", &rpath, "-d x x - path to file where result is saved"},
{"A:", &Aarg, "-A x x max payload length (generated randomly)\n"},
{"R:", &Rarg, "Server:\n-R x x requests after which conn.closed"},
{"q:", &qarg, "-q x x - TFO queue"},
{"m:", &Targ, "-m x Connect timeout in microsec (only for udp, udp_lite)"},
- {"B:", &server_bg, "-B x run in background, x - process directory"},
+ {"B:", &server_bg, "-B x Run in background, x - process directory"},
{NULL, NULL, NULL}
};
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [LTP] [PATCH 1/2] netstress: Update help for -m behavior for client and server
2018-08-16 17:20 [LTP] [PATCH 1/2] netstress: Update help for -m behavior for client and server Petr Vorel
2018-08-16 17:20 ` [LTP] [PATCH 2/2] netstress: Unifi help Petr Vorel
@ 2018-08-17 11:12 ` Alexey Kodanev
1 sibling, 0 replies; 4+ messages in thread
From: Alexey Kodanev @ 2018-08-17 11:12 UTC (permalink / raw)
To: ltp
On 16.08.2018 20:20, Petr Vorel wrote:
> Different udp/udp_lite behaviour for server is due no listen() call.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
Hi Petr,
> testcases/network/netstress/netstress.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/network/netstress/netstress.c b/testcases/network/netstress/netstress.c
> index acce26f00..0de3fde1a 100644
> --- a/testcases/network/netstress/netstress.c
> +++ b/testcases/network/netstress/netstress.c
> @@ -1002,12 +1002,13 @@ static struct tst_option options[] = {
> {"r:", &rarg, "-r x Number of client requests"},
> {"n:", &narg, "-n x Client message size"},
> {"N:", &Narg, "-N x Server message size"},
> - {"m:", &Targ, "-m x Reply timeout in microsec."},
> + {"m:", &Targ, "-m x Reply timeout in microsec (for udp, udp_lite, dccp is timeout always 100 microsec)"},
The timeout value not in microseconds, but in milliseconds.
What is "dccp is timeout always 100 microsec"?
> {"d:", &rpath, "-d x x is a path to file where result is saved"},
> {"A:", &Aarg, "-A x x max payload length (generated randomly)\n"},
>
> {"R:", &Rarg, "Server:\n-R x x requests after which conn.closed"},
> {"q:", &qarg, "-q x x - TFO queue"},
> + {"m:", &Targ, "-m x Connect timeout in microsec (only for udp, udp_lite)"},
This is misleading actually, connect is for the client...
Why not to stick with what we had already discussed some time ago,
something like this?
"-m x Receive timeout in milliseconds (not used by UDP/DCCP client)"
Thanks,
Alexey
> {"B:", &server_bg, "-B x run in background, x - process directory"},
> {NULL, NULL, NULL}
> };
>
^ permalink raw reply [flat|nested] 4+ messages in thread