All of lore.kernel.org
 help / color / mirror / Atom feed
From: idosch at idosch.org (Ido Schimmel)
Subject: [PATCH] selftests: net: move fragment forwarding/config up a level
Date: Wed, 22 Aug 2018 09:45:46 +0300	[thread overview]
Message-ID: <20180822064546.GA32527@splinter.mtl.com> (raw)
In-Reply-To: <fa188bdd-2f4c-66fc-a803-5d53425c3daf@kernel.org>

On Tue, Aug 21, 2018 at 01:41:54PM -0600, Shuah Khan wrote:
> On 08/21/2018 12:56 PM, Ido Schimmel wrote:
> > On Tue, Aug 21, 2018 at 06:12:12PM +0200, Anders Roxell wrote:
> >> 'make kselftest-merge' assumes that the config files for the tests are
> >> located under the 'main' tet dir, like tools/testing/selftests/net/ and
> >> not in a subdir to net.
> > 
> > The tests under tools/testing/selftests/net/forwarding/ aren't executed
> > as part of the Makefile. The config file is there mainly so that people
> > will know which config options they need in order to run the tests.
> > 
> > The tests can be added to the Makefile, but some of them take a few
> > minutes to complete which is probably against "Don't take too long;"
> > mentioned in Documentation/dev-tools/kselftest.rst.
> > 
> 
> I don't see any reason why these shouldn't be added. With the number of
> tests that get run by default, time has gone up. The goal is to run more
> tests not less. There are some stress/destructive tests that continue to
> be left out of the Makefile.

Thanks for clarifying. I'll add the tests.

WARNING: multiple messages have this Message-ID (diff)
From: idosch@idosch.org (Ido Schimmel)
Subject: [PATCH] selftests: net: move fragment forwarding/config up a level
Date: Wed, 22 Aug 2018 09:45:46 +0300	[thread overview]
Message-ID: <20180822064546.GA32527@splinter.mtl.com> (raw)
Message-ID: <20180822064546.RnVYx0TGrV0CtGGqHMDc0ElXNyrJP36hPkyQ9S0Wj-c@z> (raw)
In-Reply-To: <fa188bdd-2f4c-66fc-a803-5d53425c3daf@kernel.org>

On Tue, Aug 21, 2018@01:41:54PM -0600, Shuah Khan wrote:
> On 08/21/2018 12:56 PM, Ido Schimmel wrote:
> > On Tue, Aug 21, 2018@06:12:12PM +0200, Anders Roxell wrote:
> >> 'make kselftest-merge' assumes that the config files for the tests are
> >> located under the 'main' tet dir, like tools/testing/selftests/net/ and
> >> not in a subdir to net.
> > 
> > The tests under tools/testing/selftests/net/forwarding/ aren't executed
> > as part of the Makefile. The config file is there mainly so that people
> > will know which config options they need in order to run the tests.
> > 
> > The tests can be added to the Makefile, but some of them take a few
> > minutes to complete which is probably against "Don't take too long;"
> > mentioned in Documentation/dev-tools/kselftest.rst.
> > 
> 
> I don't see any reason why these shouldn't be added. With the number of
> tests that get run by default, time has gone up. The goal is to run more
> tests not less. There are some stress/destructive tests that continue to
> be left out of the Makefile.

Thanks for clarifying. I'll add the tests.

WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@idosch.org>
To: Shuah Khan <shuah@kernel.org>
Cc: Anders Roxell <anders.roxell@linaro.org>,
	davem@davemloft.net, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests: net: move fragment forwarding/config up a level
Date: Wed, 22 Aug 2018 09:45:46 +0300	[thread overview]
Message-ID: <20180822064546.GA32527@splinter.mtl.com> (raw)
In-Reply-To: <fa188bdd-2f4c-66fc-a803-5d53425c3daf@kernel.org>

On Tue, Aug 21, 2018 at 01:41:54PM -0600, Shuah Khan wrote:
> On 08/21/2018 12:56 PM, Ido Schimmel wrote:
> > On Tue, Aug 21, 2018 at 06:12:12PM +0200, Anders Roxell wrote:
> >> 'make kselftest-merge' assumes that the config files for the tests are
> >> located under the 'main' tet dir, like tools/testing/selftests/net/ and
> >> not in a subdir to net.
> > 
> > The tests under tools/testing/selftests/net/forwarding/ aren't executed
> > as part of the Makefile. The config file is there mainly so that people
> > will know which config options they need in order to run the tests.
> > 
> > The tests can be added to the Makefile, but some of them take a few
> > minutes to complete which is probably against "Don't take too long;"
> > mentioned in Documentation/dev-tools/kselftest.rst.
> > 
> 
> I don't see any reason why these shouldn't be added. With the number of
> tests that get run by default, time has gone up. The goal is to run more
> tests not less. There are some stress/destructive tests that continue to
> be left out of the Makefile.

Thanks for clarifying. I'll add the tests.

  reply	other threads:[~2018-08-22  6:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21 16:12 [PATCH] selftests: net: move fragment forwarding/config up a level anders.roxell
2018-08-21 16:12 ` Anders Roxell
2018-08-21 16:12 ` Anders Roxell
2018-08-21 18:56 ` idosch
2018-08-21 18:56   ` Ido Schimmel
2018-08-21 18:56   ` Ido Schimmel
2018-08-21 19:41   ` shuah
2018-08-21 19:41     ` Shuah Khan
2018-08-21 19:41     ` Shuah Khan
2018-08-22  6:45     ` idosch [this message]
2018-08-22  6:45       ` Ido Schimmel
2018-08-22  6:45       ` Ido Schimmel
2018-08-23 17:09       ` shuah
2018-08-23 17:09         ` Shuah Khan
2018-08-23 17:09         ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180822064546.GA32527@splinter.mtl.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.