* [PATCH 2/2] drm/i915: Do not advertize support for NV12 on ICL yet.
2018-08-24 20:38 [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar() Dhinakaran Pandiyan
@ 2018-08-24 20:38 ` Dhinakaran Pandiyan
2018-08-27 11:56 ` Ville Syrjälä
2018-08-24 21:02 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Clean up skl_plane_has_planar() Patchwork
` (5 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Dhinakaran Pandiyan @ 2018-08-24 20:38 UTC (permalink / raw)
To: intel-gfx; +Cc: Dhinakaran Pandiyan, Rodrigo Vivi
ICL requires two planes for scanning out a NV12 framebuffer. Do
not advertize support for creating NV12 framebuffers until required
plane programming is implemented.
v2: Do not allow adding buffers.
Check inside skl_plane_has_planar (Ville)
Bspec: Plane Planar YUV programming (18566)
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 7e18bd8b21b8..8e4e88eb10e4 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -13622,6 +13622,13 @@ static bool skl_plane_has_fbc(struct drm_i915_private *dev_priv,
bool skl_plane_has_planar(struct drm_i915_private *dev_priv,
enum pipe pipe, enum plane_id plane_id)
{
+ /*
+ * FIXME: ICL requires two hardware planes for scanning out NV12
+ * framebuffers. Do not advertize support until this is implemented.
+ */
+ if (INTEL_GEN(dev_priv) >= 11)
+ return false;
+
if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
return false;
@@ -14543,7 +14550,7 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
break;
case DRM_FORMAT_NV12:
if (INTEL_GEN(dev_priv) < 9 || IS_SKYLAKE(dev_priv) ||
- IS_BROXTON(dev_priv)) {
+ IS_BROXTON(dev_priv) || INTEL_GEN(dev_priv) >= 11) {
DRM_DEBUG_KMS("unsupported pixel format: %s\n",
drm_get_format_name(mode_cmd->pixel_format,
&format_name));
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 2/2] drm/i915: Do not advertize support for NV12 on ICL yet.
2018-08-24 20:38 ` [PATCH 2/2] drm/i915: Do not advertize support for NV12 on ICL yet Dhinakaran Pandiyan
@ 2018-08-27 11:56 ` Ville Syrjälä
0 siblings, 0 replies; 16+ messages in thread
From: Ville Syrjälä @ 2018-08-27 11:56 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx, Rodrigo Vivi
On Fri, Aug 24, 2018 at 01:38:56PM -0700, Dhinakaran Pandiyan wrote:
> ICL requires two planes for scanning out a NV12 framebuffer. Do
> not advertize support for creating NV12 framebuffers until required
> plane programming is implemented.
>
> v2: Do not allow adding buffers.
> Check inside skl_plane_has_planar (Ville)
>
> Bspec: Plane Planar YUV programming (18566)
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 7e18bd8b21b8..8e4e88eb10e4 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13622,6 +13622,13 @@ static bool skl_plane_has_fbc(struct drm_i915_private *dev_priv,
> bool skl_plane_has_planar(struct drm_i915_private *dev_priv,
> enum pipe pipe, enum plane_id plane_id)
> {
> + /*
> + * FIXME: ICL requires two hardware planes for scanning out NV12
> + * framebuffers. Do not advertize support until this is implemented.
> + */
> + if (INTEL_GEN(dev_priv) >= 11)
> + return false;
> +
> if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> return false;
>
> @@ -14543,7 +14550,7 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
> break;
> case DRM_FORMAT_NV12:
> if (INTEL_GEN(dev_priv) < 9 || IS_SKYLAKE(dev_priv) ||
> - IS_BROXTON(dev_priv)) {
> + IS_BROXTON(dev_priv) || INTEL_GEN(dev_priv) >= 11) {
> DRM_DEBUG_KMS("unsupported pixel format: %s\n",
> drm_get_format_name(mode_cmd->pixel_format,
> &format_name));
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Clean up skl_plane_has_planar()
2018-08-24 20:38 [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar() Dhinakaran Pandiyan
2018-08-24 20:38 ` [PATCH 2/2] drm/i915: Do not advertize support for NV12 on ICL yet Dhinakaran Pandiyan
@ 2018-08-24 21:02 ` Patchwork
2018-08-24 21:56 ` ✓ Fi.CI.IGT: " Patchwork
` (4 subsequent siblings)
6 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-08-24 21:02 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Clean up skl_plane_has_planar()
URL : https://patchwork.freedesktop.org/series/48687/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4704 -> Patchwork_10013 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48687/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10013:
=== IGT changes ===
==== Warnings ====
{igt@kms_psr@primary_page_flip}:
fi-cnl-psr: DMESG-WARN -> DMESG-FAIL
== Known issues ==
Here are the changes found in Patchwork_10013 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_chamelium@hdmi-hpd-fast:
fi-kbl-7500u: SKIP -> FAIL (fdo#102672, fdo#103841)
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
fi-skl-guc: FAIL (fdo#103191) -> PASS +1
{fi-byt-clapper}: FAIL (fdo#107362, fdo#103191) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-skl-6260u: INCOMPLETE (fdo#104108) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
== Participating hosts (54 -> 49) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4704 -> Patchwork_10013
CI_DRM_4704: eb9a20b20d4790be1561235f45e209fba02dc6c0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4609: 0bc9763af77bbb37f2ed65cc39c398e88db7d8e3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10013: 24a2c0467627d06cbb32a43469a8b4dfbe9241a1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
24a2c0467627 drm/i915: Do not advertize support for NV12 on ICL yet.
b0c0b66f1e11 drm/i915: Clean up skl_plane_has_planar()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10013/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Clean up skl_plane_has_planar()
2018-08-24 20:38 [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar() Dhinakaran Pandiyan
2018-08-24 20:38 ` [PATCH 2/2] drm/i915: Do not advertize support for NV12 on ICL yet Dhinakaran Pandiyan
2018-08-24 21:02 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Clean up skl_plane_has_planar() Patchwork
@ 2018-08-24 21:56 ` Patchwork
2018-08-24 22:15 ` [PATCH 1/2] " Rodrigo Vivi
` (3 subsequent siblings)
6 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-08-24 21:56 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Clean up skl_plane_has_planar()
URL : https://patchwork.freedesktop.org/series/48687/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4704_full -> Patchwork_10013_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10013_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10013_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10013_full:
=== IGT changes ===
==== Warnings ====
igt@kms_vblank@pipe-a-wait-busy-hang:
shard-snb: PASS -> SKIP +2
== Known issues ==
Here are the changes found in Patchwork_10013_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_busy@extended-parallel-bsd1:
shard-hsw: SKIP -> INCOMPLETE (fdo#103540) +22
igt@gem_flink_basic@flink-lifetime:
shard-hsw: PASS -> INCOMPLETE (fdo#103540) +46
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@kms_cursor_legacy@cursor-vs-flip-toggle:
shard-hsw: FAIL (fdo#103355) -> PASS
igt@kms_vblank@pipe-a-ts-continuation-suspend:
shard-hsw: FAIL (fdo#104894) -> PASS
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#104894 https://bugs.freedesktop.org/show_bug.cgi?id=104894
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4704 -> Patchwork_10013
CI_DRM_4704: eb9a20b20d4790be1561235f45e209fba02dc6c0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4609: 0bc9763af77bbb37f2ed65cc39c398e88db7d8e3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10013: 24a2c0467627d06cbb32a43469a8b4dfbe9241a1 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10013/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar()
2018-08-24 20:38 [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar() Dhinakaran Pandiyan
` (2 preceding siblings ...)
2018-08-24 21:56 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-08-24 22:15 ` Rodrigo Vivi
2018-08-24 22:27 ` Pandiyan, Dhinakaran
2018-08-27 11:56 ` Ville Syrjälä
` (2 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Rodrigo Vivi @ 2018-08-24 22:15 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
On Fri, Aug 24, 2018 at 01:38:55PM -0700, Dhinakaran Pandiyan wrote:
> skl_plane_has_planar is hard to read, simplify the logic by checking for
> support in the order of platform, pipe and plane.
>
> No change in functionality intended.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 27 +++++++++------------------
> 1 file changed, 9 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 30fdfd1a3037..7e18bd8b21b8 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13622,24 +13622,15 @@ static bool skl_plane_has_fbc(struct drm_i915_private *dev_priv,
> bool skl_plane_has_planar(struct drm_i915_private *dev_priv,
> enum pipe pipe, enum plane_id plane_id)
> {
> - if (plane_id == PLANE_PRIMARY) {
> - if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> - return false;
> - else if ((INTEL_GEN(dev_priv) == 9 && pipe == PIPE_C) &&
> - !IS_GEMINILAKE(dev_priv))
> - return false;
> - } else if (plane_id >= PLANE_SPRITE0) {
> - if (plane_id == PLANE_CURSOR)
> - return false;
> - if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) == 10) {
> - if (plane_id != PLANE_SPRITE0)
> - return false;
> - } else {
> - if (plane_id != PLANE_SPRITE0 || pipe == PIPE_C ||
> - IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> - return false;
> - }
> - }
> + if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> + return false;
The current code is indeed ugly, but I'm afraid it doesn't always return
false for these platforms.
for instance plane_id = PLANE_SPRITE0
> +
> + if (INTEL_GEN(dev_priv) == 9 && !IS_GEMINILAKE(dev_priv) && pipe == PIPE_C)
> + return false;
> +
> + if (plane_id == PLANE_CURSOR || plane_id != PLANE_SPRITE0)
> + return false;
> +
> return true;
> }
>
> --
> 2.17.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar()
2018-08-24 22:15 ` [PATCH 1/2] " Rodrigo Vivi
@ 2018-08-24 22:27 ` Pandiyan, Dhinakaran
2018-08-24 23:16 ` Rodrigo Vivi
0 siblings, 1 reply; 16+ messages in thread
From: Pandiyan, Dhinakaran @ 2018-08-24 22:27 UTC (permalink / raw)
To: Vivi, Rodrigo; +Cc: intel-gfx@lists.freedesktop.org
On Fri, 2018-08-24 at 15:15 -0700, Rodrigo Vivi wrote:
> On Fri, Aug 24, 2018 at 01:38:55PM -0700, Dhinakaran Pandiyan wrote:
> > skl_plane_has_planar is hard to read, simplify the logic by
> > checking for
> > support in the order of platform, pipe and plane.
> >
> > No change in functionality intended.
> >
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 27 +++++++++---------------
> > ---
> > 1 file changed, 9 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > index 30fdfd1a3037..7e18bd8b21b8 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -13622,24 +13622,15 @@ static bool skl_plane_has_fbc(struct
> > drm_i915_private *dev_priv,
> > bool skl_plane_has_planar(struct drm_i915_private *dev_priv,
> > enum pipe pipe, enum plane_id plane_id)
> > {
> > - if (plane_id == PLANE_PRIMARY) {
> > - if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> > - return false;
> > - else if ((INTEL_GEN(dev_priv) == 9 && pipe ==
> > PIPE_C) &&
> > - !IS_GEMINILAKE(dev_priv))
> > - return false;
> > - } else if (plane_id >= PLANE_SPRITE0) {
> > - if (plane_id == PLANE_CURSOR)
> > - return false;
> > - if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv)
> > == 10) {
> > - if (plane_id != PLANE_SPRITE0)
> > - return false;
> > - } else {
> > - if (plane_id != PLANE_SPRITE0 || pipe ==
> > PIPE_C ||
> > - IS_SKYLAKE(dev_priv) ||
> > IS_BROXTON(dev_priv))
> > - return false;
^ Here it does, or am I not seeing the paranthesis correctly.
> > - }
> > - }
> > + if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> > + return false;
>
> The current code is indeed ugly, but I'm afraid it doesn't always
> return
> false for these platforms.
>
> for instance plane_id = PLANE_SPRITE0
>
> > +
> > + if (INTEL_GEN(dev_priv) == 9 && !IS_GEMINILAKE(dev_priv)
> > && pipe == PIPE_C)
> > + return false;
> > +
> > + if (plane_id == PLANE_CURSOR || plane_id != PLANE_SPRITE0)
> > + return false;
> > +
> > return true;
> > }
> >
> > --
> > 2.17.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar()
2018-08-24 22:27 ` Pandiyan, Dhinakaran
@ 2018-08-24 23:16 ` Rodrigo Vivi
2018-08-24 23:38 ` Pandiyan, Dhinakaran
0 siblings, 1 reply; 16+ messages in thread
From: Rodrigo Vivi @ 2018-08-24 23:16 UTC (permalink / raw)
To: Pandiyan, Dhinakaran; +Cc: intel-gfx@lists.freedesktop.org
On Fri, Aug 24, 2018 at 10:27:09PM +0000, Pandiyan, Dhinakaran wrote:
>
>
> On Fri, 2018-08-24 at 15:15 -0700, Rodrigo Vivi wrote:
> > On Fri, Aug 24, 2018 at 01:38:55PM -0700, Dhinakaran Pandiyan wrote:
> > > skl_plane_has_planar is hard to read, simplify the logic by
> > > checking for
> > > support in the order of platform, pipe and plane.
> > >
> > > No change in functionality intended.
> > >
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/intel_display.c | 27 +++++++++---------------
> > > ---
> > > 1 file changed, 9 insertions(+), 18 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > > b/drivers/gpu/drm/i915/intel_display.c
> > > index 30fdfd1a3037..7e18bd8b21b8 100644
> > > --- a/drivers/gpu/drm/i915/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/intel_display.c
> > > @@ -13622,24 +13622,15 @@ static bool skl_plane_has_fbc(struct
> > > drm_i915_private *dev_priv,
> > > bool skl_plane_has_planar(struct drm_i915_private *dev_priv,
> > > enum pipe pipe, enum plane_id plane_id)
> > > {
> > > - if (plane_id == PLANE_PRIMARY) {
> > > - if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> > > - return false;
> > > - else if ((INTEL_GEN(dev_priv) == 9 && pipe ==
> > > PIPE_C) &&
> > > - !IS_GEMINILAKE(dev_priv))
> > > - return false;
> > > - } else if (plane_id >= PLANE_SPRITE0) {
> > > - if (plane_id == PLANE_CURSOR)
> > > - return false;
> > > - if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv)
> > > == 10) {
> > > - if (plane_id != PLANE_SPRITE0)
> > > - return false;
> > > - } else {
> > > - if (plane_id != PLANE_SPRITE0 || pipe ==
> > > PIPE_C ||
> > > - IS_SKYLAKE(dev_priv) ||
> > > IS_BROXTON(dev_priv))
> > > - return false;
> ^ Here it does, or am I not seeing the paranthesis correctly.
dam... it is so bad that I got confused when drawing a
table here...
nip: The name of the function seems wrong since "skl_" always
return false....
but I don't have a better suggestion ... maybe just "intel_"
and can be in a follow up patch...
so,
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> > > - }
> > > - }
> > > + if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> > > + return false;
> >
> > The current code is indeed ugly, but I'm afraid it doesn't always
> > return
> > false for these platforms.
> >
> > for instance plane_id = PLANE_SPRITE0
> >
> > > +
> > > + if (INTEL_GEN(dev_priv) == 9 && !IS_GEMINILAKE(dev_priv)
> > > && pipe == PIPE_C)
> > > + return false;
> > > +
> > > + if (plane_id == PLANE_CURSOR || plane_id != PLANE_SPRITE0)
> > > + return false;
> > > +
> > > return true;
> > > }
> > >
> > > --
> > > 2.17.1
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar()
2018-08-24 23:16 ` Rodrigo Vivi
@ 2018-08-24 23:38 ` Pandiyan, Dhinakaran
0 siblings, 0 replies; 16+ messages in thread
From: Pandiyan, Dhinakaran @ 2018-08-24 23:38 UTC (permalink / raw)
To: Vivi, Rodrigo; +Cc: intel-gfx@lists.freedesktop.org
On Fri, 2018-08-24 at 16:16 -0700, Rodrigo Vivi wrote:
> On Fri, Aug 24, 2018 at 10:27:09PM +0000, Pandiyan, Dhinakaran wrote:
> >
> >
> > On Fri, 2018-08-24 at 15:15 -0700, Rodrigo Vivi wrote:
> > > On Fri, Aug 24, 2018 at 01:38:55PM -0700, Dhinakaran Pandiyan
> > > wrote:
> > > > skl_plane_has_planar is hard to read, simplify the logic by
> > > > checking for
> > > > support in the order of platform, pipe and plane.
> > > >
> > > > No change in functionality intended.
> > > >
> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.c
> > > > om>
> > > > ---
> > > > drivers/gpu/drm/i915/intel_display.c | 27 +++++++++-----------
> > > > ----
> > > > ---
> > > > 1 file changed, 9 insertions(+), 18 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > > > b/drivers/gpu/drm/i915/intel_display.c
> > > > index 30fdfd1a3037..7e18bd8b21b8 100644
> > > > --- a/drivers/gpu/drm/i915/intel_display.c
> > > > +++ b/drivers/gpu/drm/i915/intel_display.c
> > > > @@ -13622,24 +13622,15 @@ static bool skl_plane_has_fbc(struct
> > > > drm_i915_private *dev_priv,
> > > > bool skl_plane_has_planar(struct drm_i915_private *dev_priv,
> > > > enum pipe pipe, enum plane_id
> > > > plane_id)
> > > > {
> > > > - if (plane_id == PLANE_PRIMARY) {
> > > > - if (IS_SKYLAKE(dev_priv) ||
> > > > IS_BROXTON(dev_priv))
> > > > - return false;
> > > > - else if ((INTEL_GEN(dev_priv) == 9 && pipe ==
> > > > PIPE_C) &&
> > > > - !IS_GEMINILAKE(dev_priv))
> > > > - return false;
> > > > - } else if (plane_id >= PLANE_SPRITE0) {
> > > > - if (plane_id == PLANE_CURSOR)
> > > > - return false;
> > > > - if (IS_GEMINILAKE(dev_priv) ||
> > > > INTEL_GEN(dev_priv)
> > > > == 10) {
> > > > - if (plane_id != PLANE_SPRITE0)
> > > > - return false;
> > > > - } else {
> > > > - if (plane_id != PLANE_SPRITE0 || pipe
> > > > ==
> > > > PIPE_C ||
> > > > - IS_SKYLAKE(dev_priv) ||
> > > > IS_BROXTON(dev_priv))
> > > > - return false;
> >
> > ^ Here it does, or am I not seeing the paranthesis correctly.
>
> dam... it is so bad that I got confused when drawing a
> table here...
>
> nip: The name of the function seems wrong since "skl_" always
> return false....
Looks like the first versions of the patch implementing nv12 did
include SKL, not clear what happened later.
> but I don't have a better suggestion ... maybe just "intel_"
> and can be in a follow up patch...
>
> so,
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Thanks!
-DK
>
> >
> > > > - }
> > > > - }
> > > > + if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> > > > + return false;
> > >
> > > The current code is indeed ugly, but I'm afraid it doesn't always
> > > return
> > > false for these platforms.
> > >
> > > for instance plane_id = PLANE_SPRITE0
> > >
> > > > +
> > > > + if (INTEL_GEN(dev_priv) == 9 &&
> > > > !IS_GEMINILAKE(dev_priv)
> > > > && pipe == PIPE_C)
> > > > + return false;
> > > > +
> > > > + if (plane_id == PLANE_CURSOR || plane_id !=
> > > > PLANE_SPRITE0)
> > > > + return false;
> > > > +
> > > > return true;
> > > > }
> > > >
> > > > --
> > > > 2.17.1
> > > >
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > Intel-gfx@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar()
2018-08-24 20:38 [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar() Dhinakaran Pandiyan
` (3 preceding siblings ...)
2018-08-24 22:15 ` [PATCH 1/2] " Rodrigo Vivi
@ 2018-08-27 11:56 ` Ville Syrjälä
2018-08-27 17:53 ` Pandiyan, Dhinakaran
2018-08-27 22:56 ` [PATCH v2] " Dhinakaran Pandiyan
2018-08-28 0:04 ` ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Clean up skl_plane_has_planar() (rev2) Patchwork
2018-08-28 1:51 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 2 replies; 16+ messages in thread
From: Ville Syrjälä @ 2018-08-27 11:56 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
On Fri, Aug 24, 2018 at 01:38:55PM -0700, Dhinakaran Pandiyan wrote:
> skl_plane_has_planar is hard to read, simplify the logic by checking for
> support in the order of platform, pipe and plane.
I had a slightly different version of this somewhere. But this one might
be even better.
>
> No change in functionality intended.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 27 +++++++++------------------
> 1 file changed, 9 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 30fdfd1a3037..7e18bd8b21b8 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13622,24 +13622,15 @@ static bool skl_plane_has_fbc(struct drm_i915_private *dev_priv,
> bool skl_plane_has_planar(struct drm_i915_private *dev_priv,
> enum pipe pipe, enum plane_id plane_id)
> {
> - if (plane_id == PLANE_PRIMARY) {
> - if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> - return false;
> - else if ((INTEL_GEN(dev_priv) == 9 && pipe == PIPE_C) &&
> - !IS_GEMINILAKE(dev_priv))
> - return false;
> - } else if (plane_id >= PLANE_SPRITE0) {
> - if (plane_id == PLANE_CURSOR)
> - return false;
> - if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) == 10) {
> - if (plane_id != PLANE_SPRITE0)
> - return false;
> - } else {
> - if (plane_id != PLANE_SPRITE0 || pipe == PIPE_C ||
> - IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> - return false;
> - }
> - }
> + if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> + return false;
> +
> + if (INTEL_GEN(dev_priv) == 9 && !IS_GEMINILAKE(dev_priv) && pipe == PIPE_C)
> + return false;
> +
> + if (plane_id == PLANE_CURSOR || plane_id != PLANE_SPRITE0)
> + return false;
The cursor check is rather redundant here. IIRC I put it at the very
start of the function to make it obvious that cursor never supports
this. But we could just as well drop the check entirely.
This also disables NV12 for the primary plane which isn't correct.
> +
> return true;
> }
>
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar()
2018-08-27 11:56 ` Ville Syrjälä
@ 2018-08-27 17:53 ` Pandiyan, Dhinakaran
2018-08-27 22:56 ` [PATCH v2] " Dhinakaran Pandiyan
1 sibling, 0 replies; 16+ messages in thread
From: Pandiyan, Dhinakaran @ 2018-08-27 17:53 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com, Vivi, Rodrigo
Cc: intel-gfx@lists.freedesktop.org
On Mon, 2018-08-27 at 14:56 +0300, Ville Syrjälä wrote:
> On Fri, Aug 24, 2018 at 01:38:55PM -0700, Dhinakaran Pandiyan wrote:
> > skl_plane_has_planar is hard to read, simplify the logic by
> > checking for
> > support in the order of platform, pipe and plane.
>
> I had a slightly different version of this somewhere. But this one
> might
> be even better.
>
> >
> > No change in functionality intended.
> >
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 27 +++++++++---------------
> > ---
> > 1 file changed, 9 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > index 30fdfd1a3037..7e18bd8b21b8 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -13622,24 +13622,15 @@ static bool skl_plane_has_fbc(struct
> > drm_i915_private *dev_priv,
> > bool skl_plane_has_planar(struct drm_i915_private *dev_priv,
> > enum pipe pipe, enum plane_id plane_id)
> > {
> > - if (plane_id == PLANE_PRIMARY) {
> > - if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> > - return false;
> > - else if ((INTEL_GEN(dev_priv) == 9 && pipe ==
> > PIPE_C) &&
> > - !IS_GEMINILAKE(dev_priv))
> > - return false;
> > - } else if (plane_id >= PLANE_SPRITE0) {
> > - if (plane_id == PLANE_CURSOR)
> > - return false;
> > - if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv)
> > == 10) {
> > - if (plane_id != PLANE_SPRITE0)
> > - return false;
> > - } else {
> > - if (plane_id != PLANE_SPRITE0 || pipe ==
> > PIPE_C ||
> > - IS_SKYLAKE(dev_priv) ||
> > IS_BROXTON(dev_priv))
> > - return false;
> > - }
> > - }
> > + if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> > + return false;
> > +
> > + if (INTEL_GEN(dev_priv) == 9 && !IS_GEMINILAKE(dev_priv)
> > && pipe == PIPE_C)
> > + return false;
> > +
> > + if (plane_id == PLANE_CURSOR || plane_id != PLANE_SPRITE0)
> > + return false;
>
> The cursor check is rather redundant here. IIRC I put it at the very
> start of the function to make it obvious that cursor never supports
> this. But we could just as well drop the check entirely.
>
> This also disables NV12 for the primary plane which isn't correct.
That's a good catch, thanks.
Switch the condition to
if (plane_id != PLANE_PRIMARY && plane_id != PLANE_SPRITE0)
return false;
?
>
> > +
> > return true;
> > }
> >
> > --
> > 2.17.1
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH v2] drm/i915: Clean up skl_plane_has_planar()
2018-08-27 11:56 ` Ville Syrjälä
2018-08-27 17:53 ` Pandiyan, Dhinakaran
@ 2018-08-27 22:56 ` Dhinakaran Pandiyan
2018-08-28 12:45 ` Ville Syrjälä
1 sibling, 1 reply; 16+ messages in thread
From: Dhinakaran Pandiyan @ 2018-08-27 22:56 UTC (permalink / raw)
To: intel-gfx; +Cc: Dhinakaran Pandiyan, rodrigo.vivi
skl_plane_has_planar is hard to read, simplify the logic by checking for
support in the order of platform, pipe and plane.
No change in functionality intended.
v2: Fix logic for primary plane (Ville)
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 27 +++++++++------------------
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 30fdfd1a3037..178552db1552 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -13622,24 +13622,15 @@ static bool skl_plane_has_fbc(struct drm_i915_private *dev_priv,
bool skl_plane_has_planar(struct drm_i915_private *dev_priv,
enum pipe pipe, enum plane_id plane_id)
{
- if (plane_id == PLANE_PRIMARY) {
- if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
- return false;
- else if ((INTEL_GEN(dev_priv) == 9 && pipe == PIPE_C) &&
- !IS_GEMINILAKE(dev_priv))
- return false;
- } else if (plane_id >= PLANE_SPRITE0) {
- if (plane_id == PLANE_CURSOR)
- return false;
- if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) == 10) {
- if (plane_id != PLANE_SPRITE0)
- return false;
- } else {
- if (plane_id != PLANE_SPRITE0 || pipe == PIPE_C ||
- IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
- return false;
- }
- }
+ if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
+ return false;
+
+ if (INTEL_GEN(dev_priv) == 9 && !IS_GEMINILAKE(dev_priv) && pipe == PIPE_C)
+ return false;
+
+ if (plane_id != PLANE_PRIMARY && plane_id != PLANE_SPRITE0)
+ return false;
+
return true;
}
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH v2] drm/i915: Clean up skl_plane_has_planar()
2018-08-27 22:56 ` [PATCH v2] " Dhinakaran Pandiyan
@ 2018-08-28 12:45 ` Ville Syrjälä
2018-08-28 19:45 ` Dhinakaran Pandiyan
0 siblings, 1 reply; 16+ messages in thread
From: Ville Syrjälä @ 2018-08-28 12:45 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx, rodrigo.vivi
On Mon, Aug 27, 2018 at 03:56:24PM -0700, Dhinakaran Pandiyan wrote:
> skl_plane_has_planar is hard to read, simplify the logic by checking for
> support in the order of platform, pipe and plane.
>
> No change in functionality intended.
> v2: Fix logic for primary plane (Ville)
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 27 +++++++++------------------
> 1 file changed, 9 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 30fdfd1a3037..178552db1552 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13622,24 +13622,15 @@ static bool skl_plane_has_fbc(struct drm_i915_private *dev_priv,
> bool skl_plane_has_planar(struct drm_i915_private *dev_priv,
> enum pipe pipe, enum plane_id plane_id)
> {
> - if (plane_id == PLANE_PRIMARY) {
> - if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> - return false;
> - else if ((INTEL_GEN(dev_priv) == 9 && pipe == PIPE_C) &&
> - !IS_GEMINILAKE(dev_priv))
> - return false;
> - } else if (plane_id >= PLANE_SPRITE0) {
> - if (plane_id == PLANE_CURSOR)
> - return false;
> - if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) == 10) {
> - if (plane_id != PLANE_SPRITE0)
> - return false;
> - } else {
> - if (plane_id != PLANE_SPRITE0 || pipe == PIPE_C ||
> - IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> - return false;
> - }
> - }
> + if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> + return false;
> +
> + if (INTEL_GEN(dev_priv) == 9 && !IS_GEMINILAKE(dev_priv) && pipe == PIPE_C)
> + return false;
> +
> + if (plane_id != PLANE_PRIMARY && plane_id != PLANE_SPRITE0)
> + return false;
> +
> return true;
> }
>
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH v2] drm/i915: Clean up skl_plane_has_planar()
2018-08-28 12:45 ` Ville Syrjälä
@ 2018-08-28 19:45 ` Dhinakaran Pandiyan
0 siblings, 0 replies; 16+ messages in thread
From: Dhinakaran Pandiyan @ 2018-08-28 19:45 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx, rodrigo.vivi
On Tue, 2018-08-28 at 15:45 +0300, Ville Syrjälä wrote:
> On Mon, Aug 27, 2018 at 03:56:24PM -0700, Dhinakaran Pandiyan wrote:
> > skl_plane_has_planar is hard to read, simplify the logic by
> > checking for
> > support in the order of platform, pipe and plane.
> >
> > No change in functionality intended.
> > v2: Fix logic for primary plane (Ville)
> >
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
Thank you, pushed the series.
-DK
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 27 +++++++++---------------
> > ---
> > 1 file changed, 9 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > index 30fdfd1a3037..178552db1552 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -13622,24 +13622,15 @@ static bool skl_plane_has_fbc(struct
> > drm_i915_private *dev_priv,
> > bool skl_plane_has_planar(struct drm_i915_private *dev_priv,
> > enum pipe pipe, enum plane_id plane_id)
> > {
> > - if (plane_id == PLANE_PRIMARY) {
> > - if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> > - return false;
> > - else if ((INTEL_GEN(dev_priv) == 9 && pipe ==
> > PIPE_C) &&
> > - !IS_GEMINILAKE(dev_priv))
> > - return false;
> > - } else if (plane_id >= PLANE_SPRITE0) {
> > - if (plane_id == PLANE_CURSOR)
> > - return false;
> > - if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv)
> > == 10) {
> > - if (plane_id != PLANE_SPRITE0)
> > - return false;
> > - } else {
> > - if (plane_id != PLANE_SPRITE0 || pipe ==
> > PIPE_C ||
> > - IS_SKYLAKE(dev_priv) ||
> > IS_BROXTON(dev_priv))
> > - return false;
> > - }
> > - }
> > + if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> > + return false;
> > +
> > + if (INTEL_GEN(dev_priv) == 9 && !IS_GEMINILAKE(dev_priv)
> > && pipe == PIPE_C)
> > + return false;
> > +
> > + if (plane_id != PLANE_PRIMARY && plane_id !=
> > PLANE_SPRITE0)
> > + return false;
> > +
> > return true;
> > }
> >
> > --
> > 2.17.1
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Clean up skl_plane_has_planar() (rev2)
2018-08-24 20:38 [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar() Dhinakaran Pandiyan
` (4 preceding siblings ...)
2018-08-27 11:56 ` Ville Syrjälä
@ 2018-08-28 0:04 ` Patchwork
2018-08-28 1:51 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-08-28 0:04 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v2] drm/i915: Clean up skl_plane_has_planar() (rev2)
URL : https://patchwork.freedesktop.org/series/48687/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4713 -> Patchwork_10024 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48687/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_10024 that come from known issues:
=== IGT changes ===
==== Issues hit ====
{igt@pm_rpm@module-reload}:
fi-cnl-psr: PASS -> WARN (fdo#107602)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
fi-cfl-guc: DMESG-FAIL -> PASS
fi-cfl-s3: DMESG-FAIL (fdo#106560) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-b:
{fi-byt-clapper}: FAIL (fdo#107362) -> PASS +1
igt@pm_rpm@basic-pci-d3-state:
fi-skl-6770hq: WARN -> PASS +1
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
== Participating hosts (54 -> 49) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4713 -> Patchwork_10024
CI_DRM_4713: 9261175f56a1b035b9db12e959ba2e8c756924a6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4610: c40743d3fce5055682d31610519758dd7379c0f8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10024: 3bed945859e3c28fb1257c7d2cecae5121e60d8d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3bed945859e3 drm/i915: Do not advertize support for NV12 on ICL yet.
cd298ba950fd drm/i915: Clean up skl_plane_has_planar()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10024/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* ✓ Fi.CI.IGT: success for series starting with [v2] drm/i915: Clean up skl_plane_has_planar() (rev2)
2018-08-24 20:38 [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar() Dhinakaran Pandiyan
` (5 preceding siblings ...)
2018-08-28 0:04 ` ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Clean up skl_plane_has_planar() (rev2) Patchwork
@ 2018-08-28 1:51 ` Patchwork
6 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2018-08-28 1:51 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v2] drm/i915: Clean up skl_plane_has_planar() (rev2)
URL : https://patchwork.freedesktop.org/series/48687/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4713_full -> Patchwork_10024_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10024_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@debugfs-reader:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#102887, fdo#105363)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
shard-kbl: DMESG-FAIL (fdo#106560, fdo#106947) -> PASS
igt@drv_suspend@shrink:
shard-glk: INCOMPLETE (k.org#198133, fdo#103359, fdo#106886) -> PASS
igt@gem_eio@reset-stress:
shard-kbl: FAIL -> PASS
igt@gem_exec_await@wide-contexts:
shard-kbl: FAIL (fdo#105900) -> PASS
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-kbl: INCOMPLETE (fdo#103665, fdo#106023) -> PASS
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4713 -> Patchwork_10024
CI_DRM_4713: 9261175f56a1b035b9db12e959ba2e8c756924a6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4610: c40743d3fce5055682d31610519758dd7379c0f8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10024: 3bed945859e3c28fb1257c7d2cecae5121e60d8d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10024/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread