All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Abishek V Ashok <abishekvashok@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters
Date: Mon, 27 Aug 2018 17:49:40 +0000	[thread overview]
Message-ID: <20180827174940.GC27089@kroah.com> (raw)
In-Reply-To: <20180808093552.2248-1-abishekvashok@gmail.com>

On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote:
> Splits definition of function programModeRegisters into two lines such
> that each line is less than 80 characters.
> 
> Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 7e22d093b..57cf9e6a5 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -13,8 +13,8 @@
>   * HW only supports 7 predefined pixel clocks, and clock select is
>   * in bit 29:27 of Display Control register.
>   */
> -static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
> -						  unsigned long dispControl)
> +static unsigned long displayControlAdjust_SM750LE(
> +		struct mode_parameter *pModeParam, unsigned long dispControl)

Ick, actually the original code is just fine here, please leave it
as-is.

thanks,,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Abishek V Ashok <abishekvashok@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters
Date: Mon, 27 Aug 2018 19:49:40 +0200	[thread overview]
Message-ID: <20180827174940.GC27089@kroah.com> (raw)
In-Reply-To: <20180808093552.2248-1-abishekvashok@gmail.com>

On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote:
> Splits definition of function programModeRegisters into two lines such
> that each line is less than 80 characters.
> 
> Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 7e22d093b..57cf9e6a5 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -13,8 +13,8 @@
>   * HW only supports 7 predefined pixel clocks, and clock select is
>   * in bit 29:27 of Display Control register.
>   */
> -static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
> -						  unsigned long dispControl)
> +static unsigned long displayControlAdjust_SM750LE(
> +		struct mode_parameter *pModeParam, unsigned long dispControl)

Ick, actually the original code is just fine here, please leave it
as-is.

thanks,,

greg k-h

  parent reply	other threads:[~2018-08-27 17:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08  9:35 [PATCH] ddk750_mode.c: Wraps line to 80 charecters Abishek V Ashok
2018-08-08  9:47 ` Abishek V Ashok
2018-08-27 17:49 ` Greg KH
2018-08-27 17:49   ` Greg KH
2018-08-27 17:49 ` Greg KH [this message]
2018-08-27 17:49   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180827174940.GC27089@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abishekvashok@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.