* [PATCH] ddk750_mode.c: Wraps line to 80 charecters
@ 2018-08-08 9:47 ` Abishek V Ashok
0 siblings, 0 replies; 6+ messages in thread
From: Abishek V Ashok @ 2018-08-08 9:35 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel,
linux-kernel
Cc: Abishek V Ashok
Splits definition of function programModeRegisters into two lines such
that each line is less than 80 characters.
Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
---
drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index 7e22d093b..57cf9e6a5 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -13,8 +13,8 @@
* HW only supports 7 predefined pixel clocks, and clock select is
* in bit 29:27 of Display Control register.
*/
-static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
- unsigned long dispControl)
+static unsigned long displayControlAdjust_SM750LE(
+ struct mode_parameter *pModeParam, unsigned long dispControl)
{
unsigned long x, y;
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ddk750_mode.c: Wraps line to 80 charecters
@ 2018-08-08 9:47 ` Abishek V Ashok
0 siblings, 0 replies; 6+ messages in thread
From: Abishek V Ashok @ 2018-08-08 9:47 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel,
linux-kernel
Cc: Abishek V Ashok
Splits definition of function programModeRegisters into two lines such
that each line is less than 80 characters.
Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
---
drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index 7e22d093b..57cf9e6a5 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -13,8 +13,8 @@
* HW only supports 7 predefined pixel clocks, and clock select is
* in bit 29:27 of Display Control register.
*/
-static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
- unsigned long dispControl)
+static unsigned long displayControlAdjust_SM750LE(
+ struct mode_parameter *pModeParam, unsigned long dispControl)
{
unsigned long x, y;
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters
2018-08-08 9:47 ` Abishek V Ashok
@ 2018-08-27 17:49 ` Greg KH
-1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2018-08-27 17:49 UTC (permalink / raw)
To: Abishek V Ashok
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, devel, linux-kernel
On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote:
> Splits definition of function programModeRegisters into two lines such
> that each line is less than 80 characters.
>
> Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Please put the subsystem in the subject line to make it harder to miss
your patch, you need a "staging:" in there, like all other patches for
drivers/staging/
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters
@ 2018-08-27 17:49 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2018-08-27 17:49 UTC (permalink / raw)
To: Abishek V Ashok
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, devel, linux-kernel
On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote:
> Splits definition of function programModeRegisters into two lines such
> that each line is less than 80 characters.
>
> Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Please put the subsystem in the subject line to make it harder to miss
your patch, you need a "staging:" in there, like all other patches for
drivers/staging/
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters
2018-08-08 9:47 ` Abishek V Ashok
@ 2018-08-27 17:49 ` Greg KH
-1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2018-08-27 17:49 UTC (permalink / raw)
To: Abishek V Ashok
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, devel, linux-kernel
On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote:
> Splits definition of function programModeRegisters into two lines such
> that each line is less than 80 characters.
>
> Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 7e22d093b..57cf9e6a5 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -13,8 +13,8 @@
> * HW only supports 7 predefined pixel clocks, and clock select is
> * in bit 29:27 of Display Control register.
> */
> -static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
> - unsigned long dispControl)
> +static unsigned long displayControlAdjust_SM750LE(
> + struct mode_parameter *pModeParam, unsigned long dispControl)
Ick, actually the original code is just fine here, please leave it
as-is.
thanks,,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters
@ 2018-08-27 17:49 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2018-08-27 17:49 UTC (permalink / raw)
To: Abishek V Ashok
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, devel, linux-kernel
On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote:
> Splits definition of function programModeRegisters into two lines such
> that each line is less than 80 characters.
>
> Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 7e22d093b..57cf9e6a5 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -13,8 +13,8 @@
> * HW only supports 7 predefined pixel clocks, and clock select is
> * in bit 29:27 of Display Control register.
> */
> -static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
> - unsigned long dispControl)
> +static unsigned long displayControlAdjust_SM750LE(
> + struct mode_parameter *pModeParam, unsigned long dispControl)
Ick, actually the original code is just fine here, please leave it
as-is.
thanks,,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-27 18:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-08 9:35 [PATCH] ddk750_mode.c: Wraps line to 80 charecters Abishek V Ashok
2018-08-08 9:47 ` Abishek V Ashok
2018-08-27 17:49 ` Greg KH
2018-08-27 17:49 ` Greg KH
2018-08-27 17:49 ` Greg KH
2018-08-27 17:49 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.