From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong \(Peter Hong\)" <hpeter@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
peter_hong@fintek.com.tw, hpeter+linux_kernel@gmail.com,
Oliver Neukum <oneukum@suse.com>
Subject: [V2,1/4] USB: serial: f81232: clear overrun flag
Date: Wed, 5 Sep 2018 16:39:33 +0200 [thread overview]
Message-ID: <20180905143933.GC1089@localhost> (raw)
On Thu, Aug 30, 2018 at 09:47:10AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The F81232 will report data and LSR with bulk like following format:
> bulk-in data: [LSR(1Byte)+DATA(1Byte)][LSR(1Byte)+DATA(1Byte)]...
>
> LSR will auto clear frame/parity/break error flag when reading by H/W,
> but overrrun will only cleared when reading LSR. So this patch add a
> worker to read LSR when OE.
>
> Cc: Oliver Neukum <oneukum@suse.com>
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
> ---
> v2:
> 1: Add flush_work(&port_priv->lsr_work) in f81232_close().
> Thanks for notice by Oliver Neukum
Looks like you ignored Oliver's comment that you needed to take care of
any pending lsr work both and close and suspend.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
peter_hong@fintek.com.tw, hpeter+linux_kernel@gmail.com,
Oliver Neukum <oneukum@suse.com>
Subject: Re: [PATCH V2 1/4] USB: serial: f81232: clear overrun flag
Date: Wed, 5 Sep 2018 16:39:33 +0200 [thread overview]
Message-ID: <20180905143933.GC1089@localhost> (raw)
In-Reply-To: <1535593634-22004-2-git-send-email-hpeter+linux_kernel@gmail.com>
On Thu, Aug 30, 2018 at 09:47:10AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The F81232 will report data and LSR with bulk like following format:
> bulk-in data: [LSR(1Byte)+DATA(1Byte)][LSR(1Byte)+DATA(1Byte)]...
>
> LSR will auto clear frame/parity/break error flag when reading by H/W,
> but overrrun will only cleared when reading LSR. So this patch add a
> worker to read LSR when OE.
>
> Cc: Oliver Neukum <oneukum@suse.com>
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
> ---
> v2:
> 1: Add flush_work(&port_priv->lsr_work) in f81232_close().
> Thanks for notice by Oliver Neukum
Looks like you ignored Oliver's comment that you needed to take care of
any pending lsr work both and close and suspend.
Johan
next reply other threads:[~2018-09-05 14:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 14:39 Johan Hovold [this message]
2018-09-05 14:39 ` [PATCH V2 1/4] USB: serial: f81232: clear overrun flag Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2018-09-07 7:41 [V2,1/4] " Ji-Ze Hong (Peter Hong)
2018-09-07 7:41 ` [PATCH V2 1/4] " Ji-Ze Hong (Peter Hong)
2018-09-05 14:46 [V2,4/4] USB: serial: f81232: fix bulk_in/out size Johan Hovold
2018-09-05 14:46 ` [PATCH V2 4/4] " Johan Hovold
2018-09-05 14:41 [V2,3/4] USB: serial: f81232: implement break control Johan Hovold
2018-09-05 14:41 ` [PATCH V2 3/4] " Johan Hovold
2018-08-31 10:13 [V2,3/4] " Johan Hovold
2018-08-31 10:13 ` [PATCH V2 3/4] " Johan Hovold
2018-08-30 1:55 [V2,3/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:55 ` [PATCH V2 3/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 [V2,4/4] USB: serial: f81232: fix bulk_in/out size Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 ` [PATCH V2 4/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 [V2,3/4] USB: serial: f81232: implement break control Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 ` [PATCH V2 3/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 [V2,3/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 ` [PATCH V2 3/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 [V2,2/4] USB: serial: f81232: add high baud rate support Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 ` [PATCH V2 2/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 [V2,1/4] USB: serial: f81232: clear overrun flag Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 ` [PATCH V2 1/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 [PATCH V2 0/4] Fintek F81232 driver improve and fix Ji-Ze Hong (Peter Hong)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905143933.GC1089@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=peter_hong@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.