From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong \(Peter Hong\)" <hpeter@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
peter_hong@fintek.com.tw, hpeter+linux_kernel@gmail.com
Subject: [V2,4/4] USB: serial: f81232: fix bulk_in/out size
Date: Wed, 5 Sep 2018 16:46:28 +0200 [thread overview]
Message-ID: <20180905144628.GE1089@localhost> (raw)
On Thu, Aug 30, 2018 at 09:47:14AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> Fix Fintek F81232 bulk_in/out size to 64/16 according to the spec.
> http://html.alldatasheet.com/html-pdf/406315/FINTEK/F81232/1762/8/F81232.html
I know we've discussed this before, but please explain here in the
commit message why you want to do this.
The bulk_in/out_size fields only set the buffer sizes used by the
driver and using buffers larger than the endpoint size is typically only
more efficient even if there may be hardware reasons for not wanting to
use that.
You said last time, you datasheets were incorrect and that the devices
were in fact using 64 b endpoints, right?
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
> ---
> drivers/usb/serial/f81232.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
> index 863430d7535f..e3ab1646a693 100644
> --- a/drivers/usb/serial/f81232.c
> +++ b/drivers/usb/serial/f81232.c
> @@ -785,8 +785,7 @@ static struct usb_serial_driver f81232_device = {
> },
> .id_table = id_table,
> .num_ports = 1,
> - .bulk_in_size = 256,
> - .bulk_out_size = 256,
> + .bulk_out_size = 16,
> .open = f81232_open,
> .close = f81232_close,
> .dtr_rts = f81232_dtr_rts,
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
peter_hong@fintek.com.tw, hpeter+linux_kernel@gmail.com
Subject: Re: [PATCH V2 4/4] USB: serial: f81232: fix bulk_in/out size
Date: Wed, 5 Sep 2018 16:46:28 +0200 [thread overview]
Message-ID: <20180905144628.GE1089@localhost> (raw)
In-Reply-To: <1535593634-22004-6-git-send-email-hpeter+linux_kernel@gmail.com>
On Thu, Aug 30, 2018 at 09:47:14AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> Fix Fintek F81232 bulk_in/out size to 64/16 according to the spec.
> http://html.alldatasheet.com/html-pdf/406315/FINTEK/F81232/1762/8/F81232.html
I know we've discussed this before, but please explain here in the
commit message why you want to do this.
The bulk_in/out_size fields only set the buffer sizes used by the
driver and using buffers larger than the endpoint size is typically only
more efficient even if there may be hardware reasons for not wanting to
use that.
You said last time, you datasheets were incorrect and that the devices
were in fact using 64 b endpoints, right?
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
> ---
> drivers/usb/serial/f81232.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
> index 863430d7535f..e3ab1646a693 100644
> --- a/drivers/usb/serial/f81232.c
> +++ b/drivers/usb/serial/f81232.c
> @@ -785,8 +785,7 @@ static struct usb_serial_driver f81232_device = {
> },
> .id_table = id_table,
> .num_ports = 1,
> - .bulk_in_size = 256,
> - .bulk_out_size = 256,
> + .bulk_out_size = 16,
> .open = f81232_open,
> .close = f81232_close,
> .dtr_rts = f81232_dtr_rts,
Johan
next reply other threads:[~2018-09-05 14:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 14:46 Johan Hovold [this message]
2018-09-05 14:46 ` [PATCH V2 4/4] USB: serial: f81232: fix bulk_in/out size Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2018-09-07 7:41 [V2,1/4] USB: serial: f81232: clear overrun flag Ji-Ze Hong (Peter Hong)
2018-09-07 7:41 ` [PATCH V2 1/4] " Ji-Ze Hong (Peter Hong)
2018-09-05 14:41 [V2,3/4] USB: serial: f81232: implement break control Johan Hovold
2018-09-05 14:41 ` [PATCH V2 3/4] " Johan Hovold
2018-09-05 14:39 [V2,1/4] USB: serial: f81232: clear overrun flag Johan Hovold
2018-09-05 14:39 ` [PATCH V2 1/4] " Johan Hovold
2018-08-31 10:13 [V2,3/4] serial: f81232: implement break control Johan Hovold
2018-08-31 10:13 ` [PATCH V2 3/4] " Johan Hovold
2018-08-30 1:55 [V2,3/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:55 ` [PATCH V2 3/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 [V2,4/4] USB: serial: f81232: fix bulk_in/out size Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 ` [PATCH V2 4/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 [V2,3/4] USB: serial: f81232: implement break control Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 ` [PATCH V2 3/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 [V2,3/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 ` [PATCH V2 3/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 [V2,2/4] USB: serial: f81232: add high baud rate support Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 ` [PATCH V2 2/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 [V2,1/4] USB: serial: f81232: clear overrun flag Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 ` [PATCH V2 1/4] " Ji-Ze Hong (Peter Hong)
2018-08-30 1:47 [PATCH V2 0/4] Fintek F81232 driver improve and fix Ji-Ze Hong (Peter Hong)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905144628.GE1089@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.