From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Angus Ainslie \(Purism\)" <angus@akkea.ca>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>
Subject: usb: typec: don't disable sink or source on initialization
Date: Fri, 7 Sep 2018 13:34:38 +0300 [thread overview]
Message-ID: <20180907103438.GI25121@kuha.fi.intel.com> (raw)
+Guenter
On Thu, Sep 06, 2018 at 01:26:44PM -0600, Angus Ainslie (Purism) wrote:
> If the board is being powered by USB disabling the source and sink
> can remove power from the board. Default to source and sink enabled.
>
> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
> ---
> drivers/usb/typec/tcpm.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
> index ca7bedb46f7f..a1b819cf31da 100644
> --- a/drivers/usb/typec/tcpm.c
> +++ b/drivers/usb/typec/tcpm.c
> @@ -2462,9 +2462,11 @@ static int tcpm_init_vbus(struct tcpm_port *port)
> {
> int ret;
>
> - ret = port->tcpc->set_vbus(port->tcpc, false, false);
> - port->vbus_source = false;
> - port->vbus_charge = false;
> + /* default to source and sink enabled in case USB is our only power
> + * source */
> + ret = port->tcpc->set_vbus(port->tcpc, true, true);
> + port->vbus_source = true;
> + port->vbus_charge = true;
> return ret;
> }
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Angus Ainslie (Purism)" <angus@akkea.ca>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] usb: typec: don't disable sink or source on initialization
Date: Fri, 7 Sep 2018 13:34:38 +0300 [thread overview]
Message-ID: <20180907103438.GI25121@kuha.fi.intel.com> (raw)
In-Reply-To: <20180906192644.24587-1-angus@akkea.ca>
+Guenter
On Thu, Sep 06, 2018 at 01:26:44PM -0600, Angus Ainslie (Purism) wrote:
> If the board is being powered by USB disabling the source and sink
> can remove power from the board. Default to source and sink enabled.
>
> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
> ---
> drivers/usb/typec/tcpm.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
> index ca7bedb46f7f..a1b819cf31da 100644
> --- a/drivers/usb/typec/tcpm.c
> +++ b/drivers/usb/typec/tcpm.c
> @@ -2462,9 +2462,11 @@ static int tcpm_init_vbus(struct tcpm_port *port)
> {
> int ret;
>
> - ret = port->tcpc->set_vbus(port->tcpc, false, false);
> - port->vbus_source = false;
> - port->vbus_charge = false;
> + /* default to source and sink enabled in case USB is our only power
> + * source */
> + ret = port->tcpc->set_vbus(port->tcpc, true, true);
> + port->vbus_source = true;
> + port->vbus_charge = true;
> return ret;
> }
--
heikki
next reply other threads:[~2018-09-07 10:34 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 10:34 Heikki Krogerus [this message]
2018-09-07 10:34 ` [PATCH] usb: typec: don't disable sink or source on initialization Heikki Krogerus
-- strict thread matches above, loose matches on Subject: below --
2018-09-14 0:38 [v3] usb: typec: get the vbus source and charge values from the devicetree Jun Li
2018-09-14 0:38 ` [PATCH v3] " Jun Li
2018-09-14 0:25 [v3] " Jun Li
2018-09-14 0:25 ` [PATCH v3] " Jun Li
2018-09-13 17:34 [v3] " Guenter Roeck
2018-09-13 17:34 ` [PATCH v3] " Guenter Roeck
2018-09-13 11:10 [v3] " Angus Ainslie
2018-09-13 11:10 ` [PATCH v3] " Angus Ainslie
2018-09-13 7:27 [v3] " Peter Chen
2018-09-13 7:27 ` [PATCH v3] " Peter Chen
2018-09-12 16:32 [v3] " Guenter Roeck
2018-09-12 16:32 ` [PATCH v3] " Guenter Roeck
2018-09-12 16:08 [v3] " Angus Ainslie
2018-09-12 16:08 ` [PATCH v3] " Angus Ainslie
2018-09-11 15:33 [v3] " Guenter Roeck
2018-09-11 15:33 ` [PATCH v3] " Guenter Roeck
2018-09-11 14:59 [v3] " Angus Ainslie
2018-09-11 14:59 ` [PATCH v3] " Angus Ainslie (Purism)
2018-09-10 14:32 [v2] " Angus Ainslie
2018-09-10 14:32 ` [PATCH v2] " Angus Ainslie
2018-09-10 13:49 [v2] " Heikki Krogerus
2018-09-10 13:49 ` [PATCH v2] " Heikki Krogerus
2018-09-10 13:43 [v2] " Guenter Roeck
2018-09-10 13:43 ` [PATCH v2] " Guenter Roeck
2018-09-10 13:11 [v2] " Angus Ainslie
2018-09-10 13:11 ` [PATCH v2] " Angus Ainslie
2018-09-10 7:35 [v2] " Heikki Krogerus
2018-09-10 7:35 ` [PATCH v2] " Heikki Krogerus
2018-09-09 20:09 [v2] " Angus Ainslie
2018-09-09 20:09 ` [PATCH v2] " Angus Ainslie
2018-09-09 19:52 [v2] " Guenter Roeck
2018-09-09 19:52 ` [PATCH v2] " Guenter Roeck
2018-09-09 18:05 [v2] " Angus Ainslie
2018-09-09 18:05 ` [PATCH v2] " Angus Ainslie (Purism)
2018-09-09 14:43 usb: typec: don't disable sink or source on initialization Guenter Roeck
2018-09-09 14:43 ` [PATCH] " Guenter Roeck
2018-09-09 14:36 Angus Ainslie
2018-09-09 14:36 ` [PATCH] " Angus Ainslie
2018-09-09 14:20 Guenter Roeck
2018-09-09 14:20 ` [PATCH] " Guenter Roeck
2018-09-09 14:08 Angus Ainslie
2018-09-09 14:08 ` [PATCH] " Angus Ainslie
2018-09-07 12:55 Guenter Roeck
2018-09-07 12:55 ` [PATCH] " Guenter Roeck
2018-09-07 9:39 Sergei Shtylyov
2018-09-07 9:39 ` [PATCH] " Sergei Shtylyov
2018-09-06 19:26 Angus Ainslie
2018-09-06 19:26 ` [PATCH] " Angus Ainslie (Purism)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907103438.GI25121@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=angus@akkea.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.