From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Antoine Tenart" <antoine.tenart@bootlin.com>,
"Nadav Haklai" <nadavh@marvell.com>
Subject: Re: [PATCHv2 2/3] PCI: mvebu: Convert to PCI emulated bridge config space
Date: Fri, 14 Sep 2018 15:44:20 +0100 [thread overview]
Message-ID: <20180914144420.GD30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20180912154831.2220-3-thomas.petazzoni@bootlin.com>
On Wed, Sep 12, 2018 at 05:48:30PM +0200, Thomas Petazzoni wrote:
> This commit convers the pci-mvebu driver to use the recently
> introduced pci-bridge-emul logic, that helps emulating a root port PCI
> bridge configuration space.
>
> It has been tested on Armada GP XP, with a E1000E NIC.
I think this needs commentry explaining the "FIXME":
> - case PCISWCAP_EXP_DEVCTL:
> + case PCI_EXP_DEVCTL:
> *value = mvebu_readl(port, PCIE_CAP_PCIEXP + PCI_EXP_DEVCTL) &
> ~(PCI_EXP_DEVCTL_URRE | PCI_EXP_DEVCTL_FERE |
> PCI_EXP_DEVCTL_NFERE | PCI_EXP_DEVCTL_CERE);
> - *value |= bridge->pcie_devctl;
> + /* FIXME */
> + *value |= bridge->pcie_conf.devctl;
> break;
otherwise it's likely to end up remaining there.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up
WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/3] PCI: mvebu: Convert to PCI emulated bridge config space
Date: Fri, 14 Sep 2018 15:44:20 +0100 [thread overview]
Message-ID: <20180914144420.GD30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20180912154831.2220-3-thomas.petazzoni@bootlin.com>
On Wed, Sep 12, 2018 at 05:48:30PM +0200, Thomas Petazzoni wrote:
> This commit convers the pci-mvebu driver to use the recently
> introduced pci-bridge-emul logic, that helps emulating a root port PCI
> bridge configuration space.
>
> It has been tested on Armada GP XP, with a E1000E NIC.
I think this needs commentry explaining the "FIXME":
> - case PCISWCAP_EXP_DEVCTL:
> + case PCI_EXP_DEVCTL:
> *value = mvebu_readl(port, PCIE_CAP_PCIEXP + PCI_EXP_DEVCTL) &
> ~(PCI_EXP_DEVCTL_URRE | PCI_EXP_DEVCTL_FERE |
> PCI_EXP_DEVCTL_NFERE | PCI_EXP_DEVCTL_CERE);
> - *value |= bridge->pcie_devctl;
> + /* FIXME */
> + *value |= bridge->pcie_conf.devctl;
> break;
otherwise it's likely to end up remaining there.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up
next prev parent reply other threads:[~2018-09-14 19:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 15:48 [PATCHv2 0/3] PCI: emulated PCI bridge config space Thomas Petazzoni
2018-09-12 15:48 ` Thomas Petazzoni
2018-09-12 15:48 ` [PATCHv2 1/3] PCI: Introduce PCI bridge emulated config space common logic Thomas Petazzoni
2018-09-12 15:48 ` Thomas Petazzoni
2018-09-12 18:53 ` Bjorn Helgaas
2018-09-12 18:53 ` Bjorn Helgaas
2018-09-14 14:38 ` Russell King - ARM Linux
2018-09-14 14:38 ` Russell King - ARM Linux
2018-09-14 14:38 ` Russell King - ARM Linux
2018-09-12 15:48 ` [PATCHv2 2/3] PCI: mvebu: Convert to PCI emulated bridge config space Thomas Petazzoni
2018-09-12 15:48 ` Thomas Petazzoni
2018-09-14 14:44 ` Russell King - ARM Linux [this message]
2018-09-14 14:44 ` Russell King - ARM Linux
2018-09-18 16:17 ` Lorenzo Pieralisi
2018-09-18 16:17 ` Lorenzo Pieralisi
2018-09-18 16:17 ` Lorenzo Pieralisi
2018-10-04 10:48 ` Lorenzo Pieralisi
2018-10-04 10:48 ` Lorenzo Pieralisi
2018-10-04 11:13 ` Thomas Petazzoni
2018-10-04 11:13 ` Thomas Petazzoni
2018-10-04 11:26 ` Russell King - ARM Linux
2018-10-04 11:26 ` Russell King - ARM Linux
2018-09-12 15:48 ` [PATCHv2 3/3] PCI: aardvark: Implement emulated root PCI " Thomas Petazzoni
2018-09-12 15:48 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914144420.GD30658@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=antoine.tenart@bootlin.com \
--cc=bhelgaas@google.com \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=nadavh@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.