From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Russell King <linux@arm.linux.org.uk>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Gregory Clement <gregory.clement@bootlin.com>,
Miqu??l Raynal <miquel.raynal@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>
Subject: Re: [PATCHv2 2/3] PCI: mvebu: Convert to PCI emulated bridge config space
Date: Thu, 4 Oct 2018 13:13:42 +0200 [thread overview]
Message-ID: <20181004131342.130d356a@windsurf> (raw)
In-Reply-To: <20181004104805.GB5233@e107981-ln.cambridge.arm.com>
Hello,
On Thu, 4 Oct 2018 11:48:05 +0100, Lorenzo Pieralisi wrote:
> > I would drop "recently introduced", unless we can define a precise
> > commit when code was added so that it can actually be checked (I know
> > you can't since the relevant patch is part of this series and not in
> > the mainline yet).
> >
> > Bjorn posted some guidelines that are helpful:
> >
> > https://marc.info/?l=linux-pci&m=150905742808166&w=2
> >
> > I can make these changes myself, no problem but please address Russell's
> > comment so that we can proceed.
>
> Hi Thomas,
>
> I understand you have more important things to think about these days :)
> (congratulations), let me know if I can fix this patch up myself, I
> would like to merge this series for v4.20.
Fixing up the commit log, of course, you can fix up yourself. However,
Russell made a comment about a remaining FIXME, and I haven't had the
chance to get back deep into the code to remember why I added this
FIXME, and whether it is still needed or not.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@bootlin.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/3] PCI: mvebu: Convert to PCI emulated bridge config space
Date: Thu, 4 Oct 2018 13:13:42 +0200 [thread overview]
Message-ID: <20181004131342.130d356a@windsurf> (raw)
In-Reply-To: <20181004104805.GB5233@e107981-ln.cambridge.arm.com>
Hello,
On Thu, 4 Oct 2018 11:48:05 +0100, Lorenzo Pieralisi wrote:
> > I would drop "recently introduced", unless we can define a precise
> > commit when code was added so that it can actually be checked (I know
> > you can't since the relevant patch is part of this series and not in
> > the mainline yet).
> >
> > Bjorn posted some guidelines that are helpful:
> >
> > https://marc.info/?l=linux-pci&m=150905742808166&w=2
> >
> > I can make these changes myself, no problem but please address Russell's
> > comment so that we can proceed.
>
> Hi Thomas,
>
> I understand you have more important things to think about these days :)
> (congratulations), let me know if I can fix this patch up myself, I
> would like to merge this series for v4.20.
Fixing up the commit log, of course, you can fix up yourself. However,
Russell made a comment about a remaining FIXME, and I haven't had the
chance to get back deep into the code to remember why I added this
FIXME, and whether it is still needed or not.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-10-04 11:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 15:48 [PATCHv2 0/3] PCI: emulated PCI bridge config space Thomas Petazzoni
2018-09-12 15:48 ` Thomas Petazzoni
2018-09-12 15:48 ` [PATCHv2 1/3] PCI: Introduce PCI bridge emulated config space common logic Thomas Petazzoni
2018-09-12 15:48 ` Thomas Petazzoni
2018-09-12 18:53 ` Bjorn Helgaas
2018-09-12 18:53 ` Bjorn Helgaas
2018-09-14 14:38 ` Russell King - ARM Linux
2018-09-14 14:38 ` Russell King - ARM Linux
2018-09-14 14:38 ` Russell King - ARM Linux
2018-09-12 15:48 ` [PATCHv2 2/3] PCI: mvebu: Convert to PCI emulated bridge config space Thomas Petazzoni
2018-09-12 15:48 ` Thomas Petazzoni
2018-09-14 14:44 ` Russell King - ARM Linux
2018-09-14 14:44 ` Russell King - ARM Linux
2018-09-18 16:17 ` Lorenzo Pieralisi
2018-09-18 16:17 ` Lorenzo Pieralisi
2018-09-18 16:17 ` Lorenzo Pieralisi
2018-10-04 10:48 ` Lorenzo Pieralisi
2018-10-04 10:48 ` Lorenzo Pieralisi
2018-10-04 11:13 ` Thomas Petazzoni [this message]
2018-10-04 11:13 ` Thomas Petazzoni
2018-10-04 11:26 ` Russell King - ARM Linux
2018-10-04 11:26 ` Russell King - ARM Linux
2018-09-12 15:48 ` [PATCHv2 3/3] PCI: aardvark: Implement emulated root PCI " Thomas Petazzoni
2018-09-12 15:48 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004131342.130d356a@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=antoine.tenart@bootlin.com \
--cc=bhelgaas@google.com \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=nadavh@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.