* [PATCH] misc: remove redundant include moduleparam.h
@ 2018-09-18 8:34 zhong jiang
2018-09-18 8:49 ` Winkler, Tomas
2018-09-18 8:55 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: zhong jiang @ 2018-09-18 8:34 UTC (permalink / raw)
To: gregkh; +Cc: tomas.winkler, arnd, linux-kernel
module.h already contains moduleparam.h, so it is safe to remove
the redundant include.
The issue is detected with the help of Coccinelle.
eePlease enter the commit message for your changes. Lines starting
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/misc/mei/bus-fixup.c | 1 -
drivers/misc/vmw_vmci/vmci_host.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c
index a6f41f9..80215c3 100644
--- a/drivers/misc/mei/bus-fixup.c
+++ b/drivers/misc/mei/bus-fixup.c
@@ -17,7 +17,6 @@
#include <linux/kernel.h>
#include <linux/sched.h>
#include <linux/module.h>
-#include <linux/moduleparam.h>
#include <linux/device.h>
#include <linux/slab.h>
#include <linux/uuid.h>
diff --git a/drivers/misc/vmw_vmci/vmci_host.c b/drivers/misc/vmw_vmci/vmci_host.c
index 83e0c95..be732e5 100644
--- a/drivers/misc/vmw_vmci/vmci_host.c
+++ b/drivers/misc/vmw_vmci/vmci_host.c
@@ -15,7 +15,6 @@
#include <linux/vmw_vmci_defs.h>
#include <linux/vmw_vmci_api.h>
-#include <linux/moduleparam.h>
#include <linux/miscdevice.h>
#include <linux/interrupt.h>
#include <linux/highmem.h>
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] misc: remove redundant include moduleparam.h
2018-09-18 8:34 [PATCH] misc: remove redundant include moduleparam.h zhong jiang
@ 2018-09-18 8:49 ` Winkler, Tomas
2018-09-18 8:55 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Winkler, Tomas @ 2018-09-18 8:49 UTC (permalink / raw)
To: zhong jiang, gregkh@linuxfoundation.org
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
> module.h already contains moduleparam.h, so it is safe to remove the
> redundant include.
>
> The issue is detected with the help of Coccinelle.
>
> eePlease enter the commit message for your changes. Lines starting
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/misc/mei/bus-fixup.c | 1 -
> drivers/misc/vmw_vmci/vmci_host.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c index
> a6f41f9..80215c3 100644
> --- a/drivers/misc/mei/bus-fixup.c
> +++ b/drivers/misc/mei/bus-fixup.c
Ack.
Tomas
> @@ -17,7 +17,6 @@
> #include <linux/kernel.h>
> #include <linux/sched.h>
> #include <linux/module.h>
> -#include <linux/moduleparam.h>
> #include <linux/device.h>
> #include <linux/slab.h>
> #include <linux/uuid.h>
> diff --git a/drivers/misc/vmw_vmci/vmci_host.c
> b/drivers/misc/vmw_vmci/vmci_host.c
> index 83e0c95..be732e5 100644
> --- a/drivers/misc/vmw_vmci/vmci_host.c
> +++ b/drivers/misc/vmw_vmci/vmci_host.c
> @@ -15,7 +15,6 @@
>
> #include <linux/vmw_vmci_defs.h>
> #include <linux/vmw_vmci_api.h>
> -#include <linux/moduleparam.h>
> #include <linux/miscdevice.h>
> #include <linux/interrupt.h>
> #include <linux/highmem.h>
> --
> 1.7.12.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] misc: remove redundant include moduleparam.h
2018-09-18 8:34 [PATCH] misc: remove redundant include moduleparam.h zhong jiang
2018-09-18 8:49 ` Winkler, Tomas
@ 2018-09-18 8:55 ` Greg KH
2018-09-18 9:09 ` zhong jiang
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2018-09-18 8:55 UTC (permalink / raw)
To: zhong jiang; +Cc: tomas.winkler, arnd, linux-kernel
On Tue, Sep 18, 2018 at 04:34:42PM +0800, zhong jiang wrote:
> module.h already contains moduleparam.h, so it is safe to remove
> the redundant include.
>
> The issue is detected with the help of Coccinelle.
>
> eePlease enter the commit message for your changes. Lines starting
Odd line to have in a changelog text :)
Please fix up and resend.
tanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] misc: remove redundant include moduleparam.h
2018-09-18 8:55 ` Greg KH
@ 2018-09-18 9:09 ` zhong jiang
0 siblings, 0 replies; 4+ messages in thread
From: zhong jiang @ 2018-09-18 9:09 UTC (permalink / raw)
To: Greg KH; +Cc: tomas.winkler, arnd, linux-kernel
On 2018/9/18 16:55, Greg KH wrote:
> On Tue, Sep 18, 2018 at 04:34:42PM +0800, zhong jiang wrote:
>> module.h already contains moduleparam.h, so it is safe to remove
>> the redundant include.
>>
>> The issue is detected with the help of Coccinelle.
>>
>> eePlease enter the commit message for your changes. Lines starting
> Odd line to have in a changelog text :)
>
> Please fix up and resend.
It's my fault to have a odd line. I will resend. Thanks.
Sincerely,
zhong jiang
> tanks,
>
> greg k-h
>
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-18 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-18 8:34 [PATCH] misc: remove redundant include moduleparam.h zhong jiang
2018-09-18 8:49 ` Winkler, Tomas
2018-09-18 8:55 ` Greg KH
2018-09-18 9:09 ` zhong jiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.