From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: [1/2] usb: typec: mux: Take care of driver module reference counting
Date: Thu, 20 Sep 2018 13:20:03 +0200 [thread overview]
Message-ID: <20180920112003.GA12655@kroah.com> (raw)
On Wed, Sep 19, 2018 at 10:58:04AM +0300, Heikki Krogerus wrote:
> Functions typec_mux_get() and typec_switch_get() already
> make sure that the mux device reference count is
> incremented, but the same must be done to the driver module
> as well to prevent the drivers from being unloaded in the
> middle of operation.
>
> This fixes a potential "BUG: unable to handle kernel paging
> request at ..." from happening.
>
> Fixes: 93dd2112c7b2 ("usb: typec: mux: Get the mux identifier from function parameter")
> Cc: <stable@vger.kernel.org>
Why is this flagged for stable? 93dd2112c7b2 went into 4.19-rc1 and has
not been backported anywhere else.
confused,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: typec: mux: Take care of driver module reference counting
Date: Thu, 20 Sep 2018 13:20:03 +0200 [thread overview]
Message-ID: <20180920112003.GA12655@kroah.com> (raw)
In-Reply-To: <20180919075805.61319-2-heikki.krogerus@linux.intel.com>
On Wed, Sep 19, 2018 at 10:58:04AM +0300, Heikki Krogerus wrote:
> Functions typec_mux_get() and typec_switch_get() already
> make sure that the mux device reference count is
> incremented, but the same must be done to the driver module
> as well to prevent the drivers from being unloaded in the
> middle of operation.
>
> This fixes a potential "BUG: unable to handle kernel paging
> request at ..." from happening.
>
> Fixes: 93dd2112c7b2 ("usb: typec: mux: Get the mux identifier from function parameter")
> Cc: <stable@vger.kernel.org>
Why is this flagged for stable? 93dd2112c7b2 went into 4.19-rc1 and has
not been backported anywhere else.
confused,
greg k-h
next reply other threads:[~2018-09-20 11:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 11:20 Greg Kroah-Hartman [this message]
2018-09-20 11:20 ` [PATCH 1/2] usb: typec: mux: Take care of driver module reference counting Greg KH
-- strict thread matches above, loose matches on Subject: below --
2018-09-20 11:34 [1/2] " Greg Kroah-Hartman
2018-09-20 11:34 ` [PATCH 1/2] " Greg KH
2018-09-20 11:26 [1/2] " Heikki Krogerus
2018-09-20 11:26 ` [PATCH 1/2] " Heikki Krogerus
2018-09-19 18:58 [2/2] usb: roles: " Sasha Levin
2018-09-19 18:58 ` [PATCH 2/2] " Sasha Levin
2018-09-19 18:58 [1/2] usb: typec: mux: " Sasha Levin
2018-09-19 18:58 ` [PATCH 1/2] " Sasha Levin
2018-09-19 7:58 [2/2] usb: roles: " Heikki Krogerus
2018-09-19 7:58 ` [PATCH 2/2] " Heikki Krogerus
2018-09-19 7:58 [1/2] usb: typec: mux: " Heikki Krogerus
2018-09-19 7:58 ` [PATCH 1/2] " Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920112003.GA12655@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.