* [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES
@ 2018-09-27 14:02 Martin Jansa
2018-09-28 20:14 ` S. Lockwood-Childs
0 siblings, 1 reply; 8+ messages in thread
From: Martin Jansa @ 2018-09-27 14:02 UTC (permalink / raw)
To: openembedded-devel
* dependency on samba was added recently in:
libldb: Add samba to rdeps for pyldb
so now we need to match samba restriction to prevent:
ERROR: Nothing RPROVIDES 'samba' (but meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS on or otherwise requires it)
samba was skipped: missing required distro feature 'pam' (not in DISTRO_FEATURES)
NOTE: Runtime target 'samba' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['samba']
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'libldb', 'samba']
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
index 99e62f66bb..3c7e5455e9 100644
--- a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
+++ b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
@@ -35,7 +35,8 @@ LIC_FILES_CHKSUM = "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
SRC_URI[sha256sum] = "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
-inherit waf-samba
+inherit waf-samba distro_features_check
+REQUIRED_DISTRO_FEATURES = "pam"
S = "${WORKDIR}/ldb-${PV}"
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES
2018-09-27 14:02 [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES Martin Jansa
@ 2018-09-28 20:14 ` S. Lockwood-Childs
2018-09-28 20:23 ` Khem Raj
0 siblings, 1 reply; 8+ messages in thread
From: S. Lockwood-Childs @ 2018-09-28 20:14 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-devel
Could you explain commit 0db9697dc6b8c a little bit, where libpam became a
distro requirement for samba itself? I'm not sure why pam is a hard
requirement, rather than being PACKAGECONFIG option. I haven't tried the server
ipk built with --without-pam but the client-side pieces are certainly useful.
I've got a bbappend to override the pam forcing, and was just wondering if
this change might be upstreamable.
On Thu, Sep 27, 2018 at 02:02:51PM +0000, Martin Jansa wrote:
> * dependency on samba was added recently in:
> libldb: Add samba to rdeps for pyldb
> so now we need to match samba restriction to prevent:
>
> ERROR: Nothing RPROVIDES 'samba' (but meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS on or otherwise requires it)
> samba was skipped: missing required distro feature 'pam' (not in DISTRO_FEATURES)
> NOTE: Runtime target 'samba' is unbuildable, removing...
> Missing or unbuildable dependency chain was: ['samba']
> ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'libldb', 'samba']
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> index 99e62f66bb..3c7e5455e9 100644
> --- a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> +++ b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> @@ -35,7 +35,8 @@ LIC_FILES_CHKSUM = "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
> SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
> SRC_URI[sha256sum] = "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
>
> -inherit waf-samba
> +inherit waf-samba distro_features_check
> +REQUIRED_DISTRO_FEATURES = "pam"
>
> S = "${WORKDIR}/ldb-${PV}"
>
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES
2018-09-28 20:14 ` S. Lockwood-Childs
@ 2018-09-28 20:23 ` Khem Raj
2018-09-28 21:08 ` S. Lockwood-Childs
0 siblings, 1 reply; 8+ messages in thread
From: Khem Raj @ 2018-09-28 20:23 UTC (permalink / raw)
To: S. Lockwood-Childs, Martin Jansa, openembeded-devel
On Fri, Sep 28, 2018 at 1:19 PM S. Lockwood-Childs <sjl@vctlabs.com> wrote:
>
> Could you explain commit 0db9697dc6b8c a little bit, where libpam became a
> distro requirement for samba itself? I'm not sure why pam is a hard
> requirement, rather than being PACKAGECONFIG option. I haven't tried the server
> ipk built with --without-pam but the client-side pieces are certainly useful.
> I've got a bbappend to override the pam forcing, and was just wondering if
> this change might be upstreamable.
its lack of fine grained packaging that this was needed. If you can
sort this out then I am all ears
>
> On Thu, Sep 27, 2018 at 02:02:51PM +0000, Martin Jansa wrote:
> > * dependency on samba was added recently in:
> > libldb: Add samba to rdeps for pyldb
> > so now we need to match samba restriction to prevent:
> >
> > ERROR: Nothing RPROVIDES 'samba' (but meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS on or otherwise requires it)
> > samba was skipped: missing required distro feature 'pam' (not in DISTRO_FEATURES)
> > NOTE: Runtime target 'samba' is unbuildable, removing...
> > Missing or unbuildable dependency chain was: ['samba']
> > ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> > Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'libldb', 'samba']
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> > meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > index 99e62f66bb..3c7e5455e9 100644
> > --- a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > +++ b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > @@ -35,7 +35,8 @@ LIC_FILES_CHKSUM = "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
> > SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
> > SRC_URI[sha256sum] = "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
> >
> > -inherit waf-samba
> > +inherit waf-samba distro_features_check
> > +REQUIRED_DISTRO_FEATURES = "pam"
> >
> > S = "${WORKDIR}/ldb-${PV}"
> >
> > --
> > 2.17.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES
2018-09-28 20:23 ` Khem Raj
@ 2018-09-28 21:08 ` S. Lockwood-Childs
2018-09-29 7:45 ` Martin Jansa
0 siblings, 1 reply; 8+ messages in thread
From: S. Lockwood-Childs @ 2018-09-28 21:08 UTC (permalink / raw)
To: Khem Raj; +Cc: openembeded-devel
On Fri, Sep 28, 2018 at 01:23:25PM -0700, Khem Raj wrote:
> On Fri, Sep 28, 2018 at 1:19 PM S. Lockwood-Childs <sjl@vctlabs.com> wrote:
> >
> > Could you explain commit 0db9697dc6b8c a little bit, where libpam became a
> > distro requirement for samba itself? I'm not sure why pam is a hard
> > requirement, rather than being PACKAGECONFIG option. I haven't tried the server
> > ipk built with --without-pam but the client-side pieces are certainly useful.
> > I've got a bbappend to override the pam forcing, and was just wondering if
> > this change might be upstreamable.
>
> its lack of fine grained packaging that this was needed. If you can
> sort this out then I am all ears
What are the packaging problems to be solved when pam support is disabled?
Like I said we're only running the client-side stuff so far, so I'm guessing
the problems came up in server-side packages. There were no build errors from
--without-pam at least.
>
> >
> > On Thu, Sep 27, 2018 at 02:02:51PM +0000, Martin Jansa wrote:
> > > * dependency on samba was added recently in:
> > > libldb: Add samba to rdeps for pyldb
> > > so now we need to match samba restriction to prevent:
> > >
> > > ERROR: Nothing RPROVIDES 'samba' (but meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS on or otherwise requires it)
> > > samba was skipped: missing required distro feature 'pam' (not in DISTRO_FEATURES)
> > > NOTE: Runtime target 'samba' is unbuildable, removing...
> > > Missing or unbuildable dependency chain was: ['samba']
> > > ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> > > Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'libldb', 'samba']
> > >
> > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > ---
> > > meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > > index 99e62f66bb..3c7e5455e9 100644
> > > --- a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > > +++ b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > > @@ -35,7 +35,8 @@ LIC_FILES_CHKSUM = "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
> > > SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
> > > SRC_URI[sha256sum] = "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
> > >
> > > -inherit waf-samba
> > > +inherit waf-samba distro_features_check
> > > +REQUIRED_DISTRO_FEATURES = "pam"
> > >
> > > S = "${WORKDIR}/ldb-${PV}"
> > >
> > > --
> > > 2.17.1
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES
2018-09-28 21:08 ` S. Lockwood-Childs
@ 2018-09-29 7:45 ` Martin Jansa
2018-10-01 10:26 ` Peter Kjellerstedt
2018-10-10 6:18 ` Martin Hundebøll
0 siblings, 2 replies; 8+ messages in thread
From: Martin Jansa @ 2018-09-29 7:45 UTC (permalink / raw)
To: S. Lockwood-Childs, Khem Raj, openembedded-devel
It depends on pam DISTRO_FEATURES, because it depends on libpam since:
commit a95726df4bb1c898da7e4d4dbf9e2846914061e4
Author: Andreas Müller <schnitzeltony@googlemail.com>
Date: Sat Sep 17 12:04:42 2016 +0200
samba: replace pam packageconfig by hard dependency
samba links against libpam even if pam is not in packageconfig and
libpam was
built before. This patch avoid this floating dependency - other
solution could
not be found. For those who want packageconfig back, see discussion iat
[1] for
further inspiration.
[1]
http://lists.openembedded.org/pipermail/openembedded-devel/2016-September/109143.html
Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
On Fri, Sep 28, 2018 at 11:04 PM S. Lockwood-Childs <sjl@vctlabs.com> wrote:
> On Fri, Sep 28, 2018 at 01:23:25PM -0700, Khem Raj wrote:
> > On Fri, Sep 28, 2018 at 1:19 PM S. Lockwood-Childs <sjl@vctlabs.com>
> wrote:
> > >
> > > Could you explain commit 0db9697dc6b8c a little bit, where libpam
> became a
> > > distro requirement for samba itself? I'm not sure why pam is a hard
> > > requirement, rather than being PACKAGECONFIG option. I haven't tried
> the server
> > > ipk built with --without-pam but the client-side pieces are certainly
> useful.
> > > I've got a bbappend to override the pam forcing, and was just
> wondering if
> > > this change might be upstreamable.
> >
> > its lack of fine grained packaging that this was needed. If you can
> > sort this out then I am all ears
>
> What are the packaging problems to be solved when pam support is disabled?
>
> Like I said we're only running the client-side stuff so far, so I'm
> guessing
> the problems came up in server-side packages. There were no build errors
> from
> --without-pam at least.
>
> >
> > >
> > > On Thu, Sep 27, 2018 at 02:02:51PM +0000, Martin Jansa wrote:
> > > > * dependency on samba was added recently in:
> > > > libldb: Add samba to rdeps for pyldb
> > > > so now we need to match samba restriction to prevent:
> > > >
> > > > ERROR: Nothing RPROVIDES 'samba' (but
> meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS
> on or otherwise requires it)
> > > > samba was skipped: missing required distro feature 'pam' (not in
> DISTRO_FEATURES)
> > > > NOTE: Runtime target 'samba' is unbuildable, removing...
> > > > Missing or unbuildable dependency chain was: ['samba']
> > > > ERROR: Required build target 'meta-world-pkgdata' has no buildable
> providers.
> > > > Missing or unbuildable dependency chain was: ['meta-world-pkgdata',
> 'libldb', 'samba']
> > > >
> > > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > > ---
> > > > meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > > > index 99e62f66bb..3c7e5455e9 100644
> > > > --- a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > > > +++ b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > > > @@ -35,7 +35,8 @@ LIC_FILES_CHKSUM =
> "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
> > > > SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
> > > > SRC_URI[sha256sum] =
> "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
> > > >
> > > > -inherit waf-samba
> > > > +inherit waf-samba distro_features_check
> > > > +REQUIRED_DISTRO_FEATURES = "pam"
> > > >
> > > > S = "${WORKDIR}/ldb-${PV}"
> > > >
> > > > --
> > > > 2.17.1
> > > >
> > > > --
> > > > _______________________________________________
> > > > Openembedded-devel mailing list
> > > > Openembedded-devel@lists.openembedded.org
> > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES
2018-09-29 7:45 ` Martin Jansa
@ 2018-10-01 10:26 ` Peter Kjellerstedt
2018-10-01 10:32 ` Martin Jansa
2018-10-10 6:18 ` Martin Hundebøll
1 sibling, 1 reply; 8+ messages in thread
From: Peter Kjellerstedt @ 2018-10-01 10:26 UTC (permalink / raw)
To: Martin Jansa, S. Lockwood-Childs, Khem Raj, openembedded-devel
Ok, so after reading the thread mentioned below, the actual problem
seems to be that if libpam has been built (e.g., because pam is
included in DISTRO_FEATURES), then samba will link with it even if
--without-pam is specified? This seems like something that can be
fixed. Because when building without pam in DISTRO_FEATURES (as we
do), then it does not seem to be a problem to build samba with
--without-pam and having it work as expected. In our case, the
REQUIRED_DISTRO_FEATURES = "pam" in the samba recipe is more of a
problem...
//Peter
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org <openembedded-
> devel-bounces@lists.openembedded.org> On Behalf Of Martin Jansa
> Sent: den 29 september 2018 09:45
> To: S. Lockwood-Childs <sjl@vctlabs.com>; Khem Raj
> <raj.khem@gmail.com>; openembedded-devel <openembedded-
> devel@lists.openembedded.org>
> Subject: Re: [oe] [meta-networking][PATCH] libldb: add pam to
> REQUIRED_DISTRO_FEATURES
>
> It depends on pam DISTRO_FEATURES, because it depends on libpam since:
> commit a95726df4bb1c898da7e4d4dbf9e2846914061e4
> Author: Andreas Müller <schnitzeltony@googlemail.com>
> Date: Sat Sep 17 12:04:42 2016 +0200
>
> samba: replace pam packageconfig by hard dependency
>
> samba links against libpam even if pam is not in packageconfig and
> libpam was
> built before. This patch avoid this floating dependency - other
> solution could
> not be found. For those who want packageconfig back, see discussion
> iat
> [1] for
> further inspiration.
>
> [1]
> http://lists.openembedded.org/pipermail/openembedded-devel/2016-
> September/109143.html
>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
>
>
> On Fri, Sep 28, 2018 at 11:04 PM S. Lockwood-Childs <sjl@vctlabs.com>
> wrote:
>
> > On Fri, Sep 28, 2018 at 01:23:25PM -0700, Khem Raj wrote:
> > > On Fri, Sep 28, 2018 at 1:19 PM S. Lockwood-Childs
> <sjl@vctlabs.com>
> > wrote:
> > > >
> > > > Could you explain commit 0db9697dc6b8c a little bit, where libpam
> > became a
> > > > distro requirement for samba itself? I'm not sure why pam is a
> hard
> > > > requirement, rather than being PACKAGECONFIG option. I haven't
> tried
> > the server
> > > > ipk built with --without-pam but the client-side pieces are
> certainly
> > useful.
> > > > I've got a bbappend to override the pam forcing, and was just
> > wondering if
> > > > this change might be upstreamable.
> > >
> > > its lack of fine grained packaging that this was needed. If you can
> > > sort this out then I am all ears
> >
> > What are the packaging problems to be solved when pam support is
> disabled?
> >
> > Like I said we're only running the client-side stuff so far, so I'm
> > guessing
> > the problems came up in server-side packages. There were no build
> errors
> > from
> > --without-pam at least.
> >
> > >
> > > >
> > > > On Thu, Sep 27, 2018 at 02:02:51PM +0000, Martin Jansa wrote:
> > > > > * dependency on samba was added recently in:
> > > > > libldb: Add samba to rdeps for pyldb
> > > > > so now we need to match samba restriction to prevent:
> > > > >
> > > > > ERROR: Nothing RPROVIDES 'samba' (but
> > meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> RDEPENDS
> > on or otherwise requires it)
> > > > > samba was skipped: missing required distro feature 'pam' (not
> in
> > DISTRO_FEATURES)
> > > > > NOTE: Runtime target 'samba' is unbuildable, removing...
> > > > > Missing or unbuildable dependency chain was: ['samba']
> > > > > ERROR: Required build target 'meta-world-pkgdata' has no
> buildable
> > providers.
> > > > > Missing or unbuildable dependency chain was: ['meta-world-
> pkgdata',
> > 'libldb', 'samba']
> > > > >
> > > > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > > > ---
> > > > > meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
> > > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/meta-networking/recipes-
> support/libldb/libldb_1.4.1.bb
> > b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > > > > index 99e62f66bb..3c7e5455e9 100644
> > > > > --- a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > > > > +++ b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > > > > @@ -35,7 +35,8 @@ LIC_FILES_CHKSUM =
> > "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
> > > > > SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
> > > > > SRC_URI[sha256sum] =
> > "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
> > > > >
> > > > > -inherit waf-samba
> > > > > +inherit waf-samba distro_features_check
> > > > > +REQUIRED_DISTRO_FEATURES = "pam"
> > > > >
> > > > > S = "${WORKDIR}/ldb-${PV}"
> > > > >
> > > > > --
> > > > > 2.17.1
> > > > >
> > > > > --
> > > > > _______________________________________________
> > > > > Openembedded-devel mailing list
> > > > > Openembedded-devel@lists.openembedded.org
> > > > > http://lists.openembedded.org/mailman/listinfo/openembedded-
> devel
> > > > --
> > > > _______________________________________________
> > > > Openembedded-devel mailing list
> > > > Openembedded-devel@lists.openembedded.org
> > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES
2018-10-01 10:26 ` Peter Kjellerstedt
@ 2018-10-01 10:32 ` Martin Jansa
0 siblings, 0 replies; 8+ messages in thread
From: Martin Jansa @ 2018-10-01 10:32 UTC (permalink / raw)
To: Peter Kjellerstedt; +Cc: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 6448 bytes --]
On Mon, Oct 01, 2018 at 10:26:42AM +0000, Peter Kjellerstedt wrote:
> Ok, so after reading the thread mentioned below, the actual problem
> seems to be that if libpam has been built (e.g., because pam is
> included in DISTRO_FEATURES), then samba will link with it even if
> --without-pam is specified? This seems like something that can be
> fixed.
Patches are surely welcome for that. There are at least 2 WIP patches
trying to do that, but neither worked.
Before oe-core c9e7a276859d38aaa03845ee09428f62760ad147 it was even
worse, because libpam could be built even without pam in
DISTRO_FEATUREs.
> Because when building without pam in DISTRO_FEATURES (as we
> do), then it does not seem to be a problem to build samba with
> --without-pam and having it work as expected. In our case, the
> REQUIRED_DISTRO_FEATURES = "pam" in the samba recipe is more of a
> problem...
>
> //Peter
>
> > -----Original Message-----
> > From: openembedded-devel-bounces@lists.openembedded.org <openembedded-
> > devel-bounces@lists.openembedded.org> On Behalf Of Martin Jansa
> > Sent: den 29 september 2018 09:45
> > To: S. Lockwood-Childs <sjl@vctlabs.com>; Khem Raj
> > <raj.khem@gmail.com>; openembedded-devel <openembedded-
> > devel@lists.openembedded.org>
> > Subject: Re: [oe] [meta-networking][PATCH] libldb: add pam to
> > REQUIRED_DISTRO_FEATURES
> >
> > It depends on pam DISTRO_FEATURES, because it depends on libpam since:
> > commit a95726df4bb1c898da7e4d4dbf9e2846914061e4
> > Author: Andreas Müller <schnitzeltony@googlemail.com>
> > Date: Sat Sep 17 12:04:42 2016 +0200
> >
> > samba: replace pam packageconfig by hard dependency
> >
> > samba links against libpam even if pam is not in packageconfig and
> > libpam was
> > built before. This patch avoid this floating dependency - other
> > solution could
> > not be found. For those who want packageconfig back, see discussion
> > iat
> > [1] for
> > further inspiration.
> >
> > [1]
> > http://lists.openembedded.org/pipermail/openembedded-devel/2016-
> > September/109143.html
> >
> > Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
> >
> >
> > On Fri, Sep 28, 2018 at 11:04 PM S. Lockwood-Childs <sjl@vctlabs.com>
> > wrote:
> >
> > > On Fri, Sep 28, 2018 at 01:23:25PM -0700, Khem Raj wrote:
> > > > On Fri, Sep 28, 2018 at 1:19 PM S. Lockwood-Childs
> > <sjl@vctlabs.com>
> > > wrote:
> > > > >
> > > > > Could you explain commit 0db9697dc6b8c a little bit, where libpam
> > > became a
> > > > > distro requirement for samba itself? I'm not sure why pam is a
> > hard
> > > > > requirement, rather than being PACKAGECONFIG option. I haven't
> > tried
> > > the server
> > > > > ipk built with --without-pam but the client-side pieces are
> > certainly
> > > useful.
> > > > > I've got a bbappend to override the pam forcing, and was just
> > > wondering if
> > > > > this change might be upstreamable.
> > > >
> > > > its lack of fine grained packaging that this was needed. If you can
> > > > sort this out then I am all ears
> > >
> > > What are the packaging problems to be solved when pam support is
> > disabled?
> > >
> > > Like I said we're only running the client-side stuff so far, so I'm
> > > guessing
> > > the problems came up in server-side packages. There were no build
> > errors
> > > from
> > > --without-pam at least.
> > >
> > > >
> > > > >
> > > > > On Thu, Sep 27, 2018 at 02:02:51PM +0000, Martin Jansa wrote:
> > > > > > * dependency on samba was added recently in:
> > > > > > libldb: Add samba to rdeps for pyldb
> > > > > > so now we need to match samba restriction to prevent:
> > > > > >
> > > > > > ERROR: Nothing RPROVIDES 'samba' (but
> > > meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > RDEPENDS
> > > on or otherwise requires it)
> > > > > > samba was skipped: missing required distro feature 'pam' (not
> > in
> > > DISTRO_FEATURES)
> > > > > > NOTE: Runtime target 'samba' is unbuildable, removing...
> > > > > > Missing or unbuildable dependency chain was: ['samba']
> > > > > > ERROR: Required build target 'meta-world-pkgdata' has no
> > buildable
> > > providers.
> > > > > > Missing or unbuildable dependency chain was: ['meta-world-
> > pkgdata',
> > > 'libldb', 'samba']
> > > > > >
> > > > > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > > > > ---
> > > > > > meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
> > > > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > > > >
> > > > > > diff --git a/meta-networking/recipes-
> > support/libldb/libldb_1.4.1.bb
> > > b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > > > > > index 99e62f66bb..3c7e5455e9 100644
> > > > > > --- a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > > > > > +++ b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
> > > > > > @@ -35,7 +35,8 @@ LIC_FILES_CHKSUM =
> > > "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
> > > > > > SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
> > > > > > SRC_URI[sha256sum] =
> > > "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
> > > > > >
> > > > > > -inherit waf-samba
> > > > > > +inherit waf-samba distro_features_check
> > > > > > +REQUIRED_DISTRO_FEATURES = "pam"
> > > > > >
> > > > > > S = "${WORKDIR}/ldb-${PV}"
> > > > > >
> > > > > > --
> > > > > > 2.17.1
> > > > > >
> > > > > > --
> > > > > > _______________________________________________
> > > > > > Openembedded-devel mailing list
> > > > > > Openembedded-devel@lists.openembedded.org
> > > > > > http://lists.openembedded.org/mailman/listinfo/openembedded-
> > devel
> > > > > --
> > > > > _______________________________________________
> > > > > Openembedded-devel mailing list
> > > > > Openembedded-devel@lists.openembedded.org
> > > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES
2018-09-29 7:45 ` Martin Jansa
2018-10-01 10:26 ` Peter Kjellerstedt
@ 2018-10-10 6:18 ` Martin Hundebøll
1 sibling, 0 replies; 8+ messages in thread
From: Martin Hundebøll @ 2018-10-10 6:18 UTC (permalink / raw)
To: Martin Jansa, S. Lockwood-Childs, Khem Raj, openembedded-devel
Hi Martin,
On 29/09/2018 09.45, Martin Jansa wrote:
> It depends on pam DISTRO_FEATURES, because it depends on libpam since:
> commit a95726df4bb1c898da7e4d4dbf9e2846914061e4
> Author: Andreas Müller <schnitzeltony@googlemail.com>
> Date: Sat Sep 17 12:04:42 2016 +0200
>
> samba: replace pam packageconfig by hard dependency
>
> samba links against libpam even if pam is not in packageconfig and
> libpam was
> built before. This patch avoid this floating dependency - other
> solution could
> not be found. For those who want packageconfig back, see discussion iat
> [1] for
> further inspiration.
Hasn't this fix (from 2016) been obsoleted by recipe-specific-sysroots?
// Martin
> [1]
> http://lists.openembedded.org/pipermail/openembedded-devel/2016-September/109143.html
>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
>
>
> On Fri, Sep 28, 2018 at 11:04 PM S. Lockwood-Childs <sjl@vctlabs.com> wrote:
>
>> On Fri, Sep 28, 2018 at 01:23:25PM -0700, Khem Raj wrote:
>>> On Fri, Sep 28, 2018 at 1:19 PM S. Lockwood-Childs <sjl@vctlabs.com>
>> wrote:
>>>>
>>>> Could you explain commit 0db9697dc6b8c a little bit, where libpam
>> became a
>>>> distro requirement for samba itself? I'm not sure why pam is a hard
>>>> requirement, rather than being PACKAGECONFIG option. I haven't tried
>> the server
>>>> ipk built with --without-pam but the client-side pieces are certainly
>> useful.
>>>> I've got a bbappend to override the pam forcing, and was just
>> wondering if
>>>> this change might be upstreamable.
>>>
>>> its lack of fine grained packaging that this was needed. If you can
>>> sort this out then I am all ears
>>
>> What are the packaging problems to be solved when pam support is disabled?
>>
>> Like I said we're only running the client-side stuff so far, so I'm
>> guessing
>> the problems came up in server-side packages. There were no build errors
>> from
>> --without-pam at least.
>>
>>>
>>>>
>>>> On Thu, Sep 27, 2018 at 02:02:51PM +0000, Martin Jansa wrote:
>>>>> * dependency on samba was added recently in:
>>>>> libldb: Add samba to rdeps for pyldb
>>>>> so now we need to match samba restriction to prevent:
>>>>>
>>>>> ERROR: Nothing RPROVIDES 'samba' (but
>> meta-oe/meta-networking/recipes-support/libldb/libldb_1.4.1.bb RDEPENDS
>> on or otherwise requires it)
>>>>> samba was skipped: missing required distro feature 'pam' (not in
>> DISTRO_FEATURES)
>>>>> NOTE: Runtime target 'samba' is unbuildable, removing...
>>>>> Missing or unbuildable dependency chain was: ['samba']
>>>>> ERROR: Required build target 'meta-world-pkgdata' has no buildable
>> providers.
>>>>> Missing or unbuildable dependency chain was: ['meta-world-pkgdata',
>> 'libldb', 'samba']
>>>>>
>>>>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>>>>> ---
>>>>> meta-networking/recipes-support/libldb/libldb_1.4.1.bb | 3 ++-
>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
>> b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
>>>>> index 99e62f66bb..3c7e5455e9 100644
>>>>> --- a/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
>>>>> +++ b/meta-networking/recipes-support/libldb/libldb_1.4.1.bb
>>>>> @@ -35,7 +35,8 @@ LIC_FILES_CHKSUM =
>> "file://pyldb.h;endline=24;md5=dfbd238cecad76957f7f860fbe9ada
>>>>> SRC_URI[md5sum] = "159a1b1a56dcccf410d1bba911be6076"
>>>>> SRC_URI[sha256sum] =
>> "2df13aa25b376b314ce24182c37691959019523de3cc5356c40c1a333b0890a2"
>>>>>
>>>>> -inherit waf-samba
>>>>> +inherit waf-samba distro_features_check
>>>>> +REQUIRED_DISTRO_FEATURES = "pam"
>>>>>
>>>>> S = "${WORKDIR}/ldb-${PV}"
>>>>>
>>>>> --
>>>>> 2.17.1
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> Openembedded-devel mailing list
>>>>> Openembedded-devel@lists.openembedded.org
>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>> --
>>>> _______________________________________________
>>>> Openembedded-devel mailing list
>>>> Openembedded-devel@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
--
Kind regards,
Martin Hundebøll
Embedded Linux Consultant
+45 61 65 54 61
martin@geanix.com
Geanix IVS
https://geanix.com
DK39600706
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-10-10 6:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-27 14:02 [meta-networking][PATCH] libldb: add pam to REQUIRED_DISTRO_FEATURES Martin Jansa
2018-09-28 20:14 ` S. Lockwood-Childs
2018-09-28 20:23 ` Khem Raj
2018-09-28 21:08 ` S. Lockwood-Childs
2018-09-29 7:45 ` Martin Jansa
2018-10-01 10:26 ` Peter Kjellerstedt
2018-10-01 10:32 ` Martin Jansa
2018-10-10 6:18 ` Martin Hundebøll
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.