All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Dan Williams <dan.j.williams@intel.com>,
	devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [v3,3/7] dt-bindings: stm32-mdma: Add DMA/MDMA chaining support bindings
Date: Sun, 7 Oct 2018 20:29:30 +0530	[thread overview]
Message-ID: <20181007145930.GA2372@vkoul-mobl> (raw)

On 28-09-18, 15:01, Pierre-Yves MORDRET wrote:
> From: M'boumba Cedric Madianga <cedric.madianga@gmail.com>
> 
> This patch adds the description of the 2 properties needed to support M2M
> transfer triggered by STM32 DMA when his transfer is complete.
> 
> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
> ---
>   Version history:
>     v3:
>     v2:
>        * rework content
>     v1:
>        * Initial
> ---
> ---
>  Documentation/devicetree/bindings/dma/stm32-mdma.txt | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/stm32-mdma.txt b/Documentation/devicetree/bindings/dma/stm32-mdma.txt
> index d18772d..27c2812 100644
> --- a/Documentation/devicetree/bindings/dma/stm32-mdma.txt
> +++ b/Documentation/devicetree/bindings/dma/stm32-mdma.txt
> @@ -10,7 +10,7 @@ Required properties:
>  - interrupts: Should contain the MDMA interrupt.
>  - clocks: Should contain the input clock of the DMA instance.
>  - resets: Reference to a reset controller asserting the DMA controller.
> -- #dma-cells : Must be <5>. See DMA client paragraph for more details.
> +- #dma-cells : Must be <6>. See DMA client paragraph for more details.

can you update the example for 6 cells?

Also what happens to dts using 5 cells..

>  
>  Optional properties:
>  - dma-channels: Number of DMA channels supported by the controller.
> @@ -26,7 +26,7 @@ Example:
>  		interrupts = <122>;
>  		clocks = <&timer_clk>;
>  		resets = <&rcc 992>;
> -		#dma-cells = <5>;
> +		#dma-cells = <6>;
>  		dma-channels = <16>;
>  		dma-requests = <32>;
>  		st,ahb-addr-masks = <0x20000000>, <0x00000000>;
> @@ -35,8 +35,8 @@ Example:
>  * DMA client
>  
>  DMA clients connected to the STM32 MDMA controller must use the format
> -described in the dma.txt file, using a five-cell specifier for each channel:
> -a phandle to the MDMA controller plus the following five integer cells:
> +described in the dma.txt file, using a six-cell specifier for each channel:
> +a phandle to the MDMA controller plus the following six integer cells:
>  
>  1. The request line number
>  2. The priority level
> @@ -76,6 +76,10 @@ a phandle to the MDMA controller plus the following five integer cells:
>     if no HW ack signal is used by the MDMA client
>  5. A 32bit mask specifying the value to be written to acknowledge the request
>     if no HW ack signal is used by the MDMA client
> +6. A bitfield value specifying if the MDMA client wants to generate M2M
> +   transfer with HW trigger (1) or not (0). This bitfield should be only
> +   enabled for M2M transfer triggered by STM32 DMA client. The memory devices
> +   involved in this kind of transfer are SRAM and DDR.
>  
>  Example:
>  
> -- 
> 2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: vkoul@kernel.org (Vinod)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/7] dt-bindings: stm32-mdma: Add DMA/MDMA chaining support bindings
Date: Sun, 7 Oct 2018 20:29:30 +0530	[thread overview]
Message-ID: <20181007145930.GA2372@vkoul-mobl> (raw)
In-Reply-To: <1538139715-24406-4-git-send-email-pierre-yves.mordret@st.com>

On 28-09-18, 15:01, Pierre-Yves MORDRET wrote:
> From: M'boumba Cedric Madianga <cedric.madianga@gmail.com>
> 
> This patch adds the description of the 2 properties needed to support M2M
> transfer triggered by STM32 DMA when his transfer is complete.
> 
> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
> ---
>   Version history:
>     v3:
>     v2:
>        * rework content
>     v1:
>        * Initial
> ---
> ---
>  Documentation/devicetree/bindings/dma/stm32-mdma.txt | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/stm32-mdma.txt b/Documentation/devicetree/bindings/dma/stm32-mdma.txt
> index d18772d..27c2812 100644
> --- a/Documentation/devicetree/bindings/dma/stm32-mdma.txt
> +++ b/Documentation/devicetree/bindings/dma/stm32-mdma.txt
> @@ -10,7 +10,7 @@ Required properties:
>  - interrupts: Should contain the MDMA interrupt.
>  - clocks: Should contain the input clock of the DMA instance.
>  - resets: Reference to a reset controller asserting the DMA controller.
> -- #dma-cells : Must be <5>. See DMA client paragraph for more details.
> +- #dma-cells : Must be <6>. See DMA client paragraph for more details.

can you update the example for 6 cells?

Also what happens to dts using 5 cells..

>  
>  Optional properties:
>  - dma-channels: Number of DMA channels supported by the controller.
> @@ -26,7 +26,7 @@ Example:
>  		interrupts = <122>;
>  		clocks = <&timer_clk>;
>  		resets = <&rcc 992>;
> -		#dma-cells = <5>;
> +		#dma-cells = <6>;
>  		dma-channels = <16>;
>  		dma-requests = <32>;
>  		st,ahb-addr-masks = <0x20000000>, <0x00000000>;
> @@ -35,8 +35,8 @@ Example:
>  * DMA client
>  
>  DMA clients connected to the STM32 MDMA controller must use the format
> -described in the dma.txt file, using a five-cell specifier for each channel:
> -a phandle to the MDMA controller plus the following five integer cells:
> +described in the dma.txt file, using a six-cell specifier for each channel:
> +a phandle to the MDMA controller plus the following six integer cells:
>  
>  1. The request line number
>  2. The priority level
> @@ -76,6 +76,10 @@ a phandle to the MDMA controller plus the following five integer cells:
>     if no HW ack signal is used by the MDMA client
>  5. A 32bit mask specifying the value to be written to acknowledge the request
>     if no HW ack signal is used by the MDMA client
> +6. A bitfield value specifying if the MDMA client wants to generate M2M
> +   transfer with HW trigger (1) or not (0). This bitfield should be only
> +   enabled for M2M transfer triggered by STM32 DMA client. The memory devices
> +   involved in this kind of transfer are SRAM and DDR.
>  
>  Example:
>  
> -- 
> 2.7.4

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod <vkoul@kernel.org>
To: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Dan Williams <dan.j.williams@intel.com>,
	devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/7] dt-bindings: stm32-mdma: Add DMA/MDMA chaining support bindings
Date: Sun, 7 Oct 2018 20:29:30 +0530	[thread overview]
Message-ID: <20181007145930.GA2372@vkoul-mobl> (raw)
In-Reply-To: <1538139715-24406-4-git-send-email-pierre-yves.mordret@st.com>

On 28-09-18, 15:01, Pierre-Yves MORDRET wrote:
> From: M'boumba Cedric Madianga <cedric.madianga@gmail.com>
> 
> This patch adds the description of the 2 properties needed to support M2M
> transfer triggered by STM32 DMA when his transfer is complete.
> 
> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
> ---
>   Version history:
>     v3:
>     v2:
>        * rework content
>     v1:
>        * Initial
> ---
> ---
>  Documentation/devicetree/bindings/dma/stm32-mdma.txt | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/stm32-mdma.txt b/Documentation/devicetree/bindings/dma/stm32-mdma.txt
> index d18772d..27c2812 100644
> --- a/Documentation/devicetree/bindings/dma/stm32-mdma.txt
> +++ b/Documentation/devicetree/bindings/dma/stm32-mdma.txt
> @@ -10,7 +10,7 @@ Required properties:
>  - interrupts: Should contain the MDMA interrupt.
>  - clocks: Should contain the input clock of the DMA instance.
>  - resets: Reference to a reset controller asserting the DMA controller.
> -- #dma-cells : Must be <5>. See DMA client paragraph for more details.
> +- #dma-cells : Must be <6>. See DMA client paragraph for more details.

can you update the example for 6 cells?

Also what happens to dts using 5 cells..

>  
>  Optional properties:
>  - dma-channels: Number of DMA channels supported by the controller.
> @@ -26,7 +26,7 @@ Example:
>  		interrupts = <122>;
>  		clocks = <&timer_clk>;
>  		resets = <&rcc 992>;
> -		#dma-cells = <5>;
> +		#dma-cells = <6>;
>  		dma-channels = <16>;
>  		dma-requests = <32>;
>  		st,ahb-addr-masks = <0x20000000>, <0x00000000>;
> @@ -35,8 +35,8 @@ Example:
>  * DMA client
>  
>  DMA clients connected to the STM32 MDMA controller must use the format
> -described in the dma.txt file, using a five-cell specifier for each channel:
> -a phandle to the MDMA controller plus the following five integer cells:
> +described in the dma.txt file, using a six-cell specifier for each channel:
> +a phandle to the MDMA controller plus the following six integer cells:
>  
>  1. The request line number
>  2. The priority level
> @@ -76,6 +76,10 @@ a phandle to the MDMA controller plus the following five integer cells:
>     if no HW ack signal is used by the MDMA client
>  5. A 32bit mask specifying the value to be written to acknowledge the request
>     if no HW ack signal is used by the MDMA client
> +6. A bitfield value specifying if the MDMA client wants to generate M2M
> +   transfer with HW trigger (1) or not (0). This bitfield should be only
> +   enabled for M2M transfer triggered by STM32 DMA client. The memory devices
> +   involved in this kind of transfer are SRAM and DDR.
>  
>  Example:
>  
> -- 
> 2.7.4

-- 
~Vinod

             reply	other threads:[~2018-10-07 14:59 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-07 14:59 Vinod Koul [this message]
2018-10-07 14:59 ` [PATCH v3 3/7] dt-bindings: stm32-mdma: Add DMA/MDMA chaining support bindings Vinod
2018-10-07 14:59 ` Vinod
  -- strict thread matches above, loose matches on Subject: below --
2018-10-19  9:21 [v3,4/7] dmaengine: stm32-dma: Add DMA/MDMA chaining support Pierre Yves MORDRET
2018-10-19  9:21 ` [PATCH v3 4/7] " Pierre Yves MORDRET
2018-10-19  9:21 ` Pierre Yves MORDRET
2018-10-19  9:21 ` Pierre Yves MORDRET
2018-10-16 14:44 [v3,4/7] " Vinod Koul
2018-10-16 14:44 ` [PATCH v3 4/7] " Vinod
2018-10-16 14:44 ` Vinod
2018-10-16  9:19 [v3,4/7] " Pierre Yves MORDRET
2018-10-16  9:19 ` [PATCH v3 4/7] " Pierre Yves MORDRET
2018-10-16  9:19 ` Pierre Yves MORDRET
2018-10-16  9:19 ` Pierre Yves MORDRET
2018-10-15 17:14 [v3,4/7] " Vinod Koul
2018-10-15 17:14 ` [PATCH v3 4/7] " Vinod
2018-10-15 17:14 ` Vinod
2018-10-12 14:46 [v3,2/7] dt-bindings: stm32-dmamux: Add one cell to support DMA/MDMA chain Rob Herring
2018-10-12 14:46 ` [PATCH v3 2/7] " Rob Herring
2018-10-12 14:46 ` Rob Herring
2018-10-12 14:42 [v3,1/7] dt-bindings: stm32-dma: Add DMA/MDMA chaining support bindings Rob Herring
2018-10-12 14:42 ` [PATCH v3 1/7] " Rob Herring
2018-10-12 14:42 ` Rob Herring
2018-10-09 13:46 [v3,1/7] " Pierre Yves MORDRET
2018-10-09 13:46 ` [PATCH v3 1/7] " Pierre Yves MORDRET
2018-10-09 13:46 ` Pierre Yves MORDRET
2018-10-09 13:46 ` Pierre Yves MORDRET
2018-10-09  8:57 [v3,1/7] " Vinod Koul
2018-10-09  8:57 ` [PATCH v3 1/7] " Vinod
2018-10-09  8:57 ` Vinod
2018-10-09  8:17 [v3,3/7] dt-bindings: stm32-mdma: " Pierre Yves MORDRET
2018-10-09  8:17 ` [PATCH v3 3/7] " Pierre Yves MORDRET
2018-10-09  8:17 ` Pierre Yves MORDRET
2018-10-09  8:17 ` Pierre Yves MORDRET
2018-10-09  7:22 [v3,2/7] dt-bindings: stm32-dmamux: Add one cell to support DMA/MDMA chain Pierre Yves MORDRET
2018-10-09  7:22 ` [PATCH v3 2/7] " Pierre Yves MORDRET
2018-10-09  7:22 ` Pierre Yves MORDRET
2018-10-09  7:22 ` Pierre Yves MORDRET
2018-10-09  7:18 [v3,1/7] dt-bindings: stm32-dma: Add DMA/MDMA chaining support bindings Pierre Yves MORDRET
2018-10-09  7:18 ` [PATCH v3 1/7] " Pierre Yves MORDRET
2018-10-09  7:18 ` Pierre Yves MORDRET
2018-10-09  7:18 ` Pierre Yves MORDRET
2018-10-07 14:58 [v3,2/7] dt-bindings: stm32-dmamux: Add one cell to support DMA/MDMA chain Vinod Koul
2018-10-07 14:58 ` [PATCH v3 2/7] " Vinod
2018-10-07 14:58 ` Vinod
2018-10-07 14:57 [v3,1/7] dt-bindings: stm32-dma: Add DMA/MDMA chaining support bindings Vinod Koul
2018-10-07 14:57 ` [PATCH v3 1/7] " Vinod
2018-10-07 14:57 ` Vinod
2018-09-28 13:01 [v3,7/7] dmaengine: stm32-mdma: enable descriptor_reuse Pierre Yves MORDRET
2018-09-28 13:01 ` [PATCH v3 7/7] " Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 [v3,6/7] dmaengine: stm32-dma: " Pierre Yves MORDRET
2018-09-28 13:01 ` [PATCH v3 6/7] " Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 [v3,5/7] dmaengine: stm32-mdma: Add DMA/MDMA chaining support Pierre Yves MORDRET
2018-09-28 13:01 ` [PATCH v3 5/7] " Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 [v3,3/7] dt-bindings: stm32-mdma: Add DMA/MDMA chaining support bindings Pierre Yves MORDRET
2018-09-28 13:01 ` [PATCH v3 3/7] " Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 [v3,2/7] dt-bindings: stm32-dmamux: Add one cell to support DMA/MDMA chain Pierre Yves MORDRET
2018-09-28 13:01 ` [PATCH v3 2/7] " Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 [v3,1/7] dt-bindings: stm32-dma: Add DMA/MDMA chaining support bindings Pierre Yves MORDRET
2018-09-28 13:01 ` [PATCH v3 1/7] " Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 [PATCH v3 0/7] Add-DMA-MDMA-chaining-support Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 ` Pierre-Yves MORDRET
2018-09-28 13:01 ` [v3,4/7] dmaengine: stm32-dma: Add DMA/MDMA chaining support Pierre Yves MORDRET
2018-09-28 13:01   ` [PATCH v3 4/7] " Pierre-Yves MORDRET
2018-09-28 13:01   ` Pierre-Yves MORDRET
2018-09-28 13:01   ` Pierre-Yves MORDRET
2018-10-07 16:00   ` [v3,4/7] " Vinod Koul
2018-10-07 16:00     ` [PATCH v3 4/7] " Vinod
2018-10-07 16:00     ` Vinod
2018-10-09  8:40     ` [v3,4/7] " Pierre Yves MORDRET
2018-10-09  8:40       ` [PATCH v3 4/7] " Pierre Yves MORDRET
2018-10-09  8:40       ` Pierre Yves MORDRET
2018-10-09  8:40       ` Pierre Yves MORDRET
2018-10-10  4:03       ` [v3,4/7] " Vinod Koul
2018-10-10  4:03         ` [PATCH v3 4/7] " Vinod
2018-10-10  4:03         ` Vinod
2018-10-10  7:02         ` [v3,4/7] " Pierre Yves MORDRET
2018-10-10  7:02           ` [PATCH v3 4/7] " Pierre Yves MORDRET
2018-10-10  7:02           ` Pierre Yves MORDRET
2018-10-10  7:02           ` Pierre Yves MORDRET
2018-10-12  9:03           ` Pierre Yves MORDRET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181007145930.GA2372@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=alexandre.torgue@st.com \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=pierre-yves.mordret@st.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.