From: aleksandr.aleksandrov@emlid.com (Aleksandr Aleksandrov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] arm64: dts: allwinner: new board - Emlid Neutis N5
Date: Fri, 12 Oct 2018 16:39:14 +0300 [thread overview]
Message-ID: <20181012133914.GA32670@imagebutcher> (raw)
In-Reply-To: <b47c5458-683e-3e96-0bbe-f9db84579c77@suse.de>
Hi Andreas,
Thanks for your feedback!
> > + *
> > + * Copyright (C) 2018 Aleksandr Aleksandrov <aleksandr.aleksandrov@emlid.com>
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "sun50i-h5-emlid-neutis-n5.dtsi"
> > +
> > +/ {
> > + model = "Emlid Neutis N5 Developer board";
> > + compatible = "emlid,neutis-n5-devboard",
> > + "emlid,neutis-n5",
>
> You are lacking bindings definitions for these new identifiers. The
> vendor prefix should be patch 1/3, the SoM/board compatibles 2/3 and
> this .dts[i] patch 3/3, so that only vendor prefixes and compatibles
> that are defined and don't result in checkpatch.pl warnings get used.
Patch 2/3:
commit 46dcb8632b36644cb20e6b35ede12ff0088a60eb
Author: Aleksandr Aleksandrov <aleksandr.aleksandrov@emlid.com>
Date: Fri Oct 12 16:22:28 2018 +0300
dt-bindings: arm: sunxi: emlid,neutis-n5(-devboard)
sunxi: add new compatibles for Emlid Neutis Dev board and SoM module
Signed-off-by: Aleksandr Aleksandrov <aleksandr.aleksandrov@emlid.com>
diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt b/Documentation/devicetree/bindings/arm/sunxi.txt
index e4beec3..a907e52 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.txt
+++ b/Documentation/devicetree/bindings/arm/sunxi.txt
@@ -19,3 +19,5 @@ using one of the following compatible strings:
allwinner,sun9i-a80
allwinner,sun50i-a64
nextthing,gr8
+ emlid,neutis-n5
+ emlid,neutis-n5-devboard
Is this right place for the neutis compatibles?
Aleksandr
WARNING: multiple messages have this Message-ID (diff)
From: Aleksandr Aleksandrov <aleksandr.aleksandrov@emlid.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
David Lechner <david@lechnology.com>,
Thierry Reding <treding@nvidia.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Johan Hovold <johan@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/2] arm64: dts: allwinner: new board - Emlid Neutis N5
Date: Fri, 12 Oct 2018 16:39:14 +0300 [thread overview]
Message-ID: <20181012133914.GA32670@imagebutcher> (raw)
In-Reply-To: <b47c5458-683e-3e96-0bbe-f9db84579c77@suse.de>
Hi Andreas,
Thanks for your feedback!
> > + *
> > + * Copyright (C) 2018 Aleksandr Aleksandrov <aleksandr.aleksandrov@emlid.com>
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "sun50i-h5-emlid-neutis-n5.dtsi"
> > +
> > +/ {
> > + model = "Emlid Neutis N5 Developer board";
> > + compatible = "emlid,neutis-n5-devboard",
> > + "emlid,neutis-n5",
>
> You are lacking bindings definitions for these new identifiers. The
> vendor prefix should be patch 1/3, the SoM/board compatibles 2/3 and
> this .dts[i] patch 3/3, so that only vendor prefixes and compatibles
> that are defined and don't result in checkpatch.pl warnings get used.
Patch 2/3:
commit 46dcb8632b36644cb20e6b35ede12ff0088a60eb
Author: Aleksandr Aleksandrov <aleksandr.aleksandrov@emlid.com>
Date: Fri Oct 12 16:22:28 2018 +0300
dt-bindings: arm: sunxi: emlid,neutis-n5(-devboard)
sunxi: add new compatibles for Emlid Neutis Dev board and SoM module
Signed-off-by: Aleksandr Aleksandrov <aleksandr.aleksandrov@emlid.com>
diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt b/Documentation/devicetree/bindings/arm/sunxi.txt
index e4beec3..a907e52 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.txt
+++ b/Documentation/devicetree/bindings/arm/sunxi.txt
@@ -19,3 +19,5 @@ using one of the following compatible strings:
allwinner,sun9i-a80
allwinner,sun50i-a64
nextthing,gr8
+ emlid,neutis-n5
+ emlid,neutis-n5-devboard
Is this right place for the neutis compatibles?
Aleksandr
next prev parent reply other threads:[~2018-10-12 13:39 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 13:25 [PATCH v3] Neutis N5 support Aleksandr Aleksandrov
2018-10-05 13:25 ` [PATCH v3] arm64: new board - Emlid Neutis N5 Aleksandr Aleksandrov
2018-10-05 14:48 ` Maxime Ripard
2018-10-08 15:20 ` [PATCH v3] Neutis N5 support Aleksandr Aleksandrov
2018-10-08 15:20 ` Aleksandr Aleksandrov
2018-10-08 15:20 ` Aleksandr Aleksandrov
2018-10-08 15:20 ` [PATCH v3] arm64: new board - Emlid Neutis N5 Aleksandr Aleksandrov
2018-10-08 15:20 ` Aleksandr Aleksandrov
2018-10-08 15:20 ` Aleksandr Aleksandrov
2018-10-10 14:49 ` Maxime Ripard
2018-10-10 14:49 ` Maxime Ripard
2018-10-11 12:01 ` aleksandr.aleksandrov
2018-10-11 13:20 ` Andreas Färber
2018-10-11 13:20 ` Andreas Färber
2018-10-11 16:40 ` Maxime Ripard
2018-10-11 16:40 ` Maxime Ripard
2018-10-12 9:35 ` Aleksandr Aleksandrov
2018-10-12 9:35 ` Aleksandr Aleksandrov
2018-10-12 9:57 ` Maxime Ripard
2018-10-12 9:57 ` Maxime Ripard
2018-10-12 10:23 ` [PATCH v4 0/2] Neutis N5 support Aleksandr Aleksandrov
2018-10-12 10:23 ` Aleksandr Aleksandrov
2018-10-12 10:23 ` Aleksandr Aleksandrov
2018-10-12 10:23 ` [PATCH v4 1/2] arm64: dts: allwinner: new board - Emlid Neutis N5 Aleksandr Aleksandrov
2018-10-12 10:23 ` Aleksandr Aleksandrov
2018-10-12 10:23 ` Aleksandr Aleksandrov
2018-10-12 12:19 ` Andreas Färber
2018-10-12 12:19 ` Andreas Färber
2018-10-12 13:39 ` Aleksandr Aleksandrov [this message]
2018-10-12 13:39 ` Aleksandr Aleksandrov
2018-10-12 20:23 ` Maxime Ripard
2018-10-12 20:23 ` Maxime Ripard
2018-10-13 2:26 ` Chen-Yu Tsai
2018-10-13 2:26 ` Chen-Yu Tsai
2018-10-15 11:49 ` [PATCH v5 0/2] Neutis N5 support Aleksandr Aleksandrov
2018-10-15 11:49 ` Aleksandr Aleksandrov
2018-10-15 11:49 ` Aleksandr Aleksandrov
2018-10-15 11:49 ` [PATCH v5 1/2] dt-bindings: vendor-prefix: new vendor - Emlid Aleksandr Aleksandrov
2018-10-15 11:49 ` Aleksandr Aleksandrov
2018-10-15 11:49 ` Aleksandr Aleksandrov
2018-10-15 11:49 ` [PATCH v5 2/2] arm64: dts: allwinner: new board - Emlid Neutis N5 Aleksandr Aleksandrov
2018-10-15 11:49 ` Aleksandr Aleksandrov
2018-10-15 11:49 ` Aleksandr Aleksandrov
2018-10-16 7:21 ` [PATCH v5 0/2] Neutis N5 support Maxime Ripard
2018-10-16 7:21 ` Maxime Ripard
2018-10-12 10:23 ` [PATCH v4 2/2] doc: devicetree: vendor-prefixes: new vendor - Emlid Aleksandr Aleksandrov
2018-10-12 10:23 ` Aleksandr Aleksandrov
2018-10-12 10:23 ` Aleksandr Aleksandrov
2018-10-12 11:39 ` Rob Herring
2018-10-12 11:39 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012133914.GA32670@imagebutcher \
--to=aleksandr.aleksandrov@emlid.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.