All of lore.kernel.org
 help / color / mirror / Atom feed
From: aleksandr.aleksandrov@emlid.com (Aleksandr Aleksandrov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] arm64: new board - Emlid Neutis N5
Date: Fri, 12 Oct 2018 12:35:23 +0300	[thread overview]
Message-ID: <20181012093523.GA29014@imagebutcher> (raw)
In-Reply-To: <2d09d6c0-0404-589d-2c34-da846cff4fb8@suse.de>

Hi,

> >>     ?+/ {
> >>     ?+ model = "Emlid Neutis N5 Developer board";
> >>     ?+ compatible = "emlid,emlid-neutis-n5-devboard",
> >>     ?+ "emlid,emlid-neutis-n5",
> >>
> >> Do you need the two emlid there? What comes before the comma is the
> >> vendor, while what is after is the model.
> > ?
> > I think emlid-neutis-n5 module could be useful in the future, no need
> > this now.
> 
> You misunderstand: The point would be to use, e.g., "emlid,neutis-n5"
> instead of "emlid,emlid-neutis-n5" with duplicate "emlid,emlid-". It is
> orthogonal to having multiple compatible strings.

Oh, I agree. No need to duplicate "emlid". Thank you!

> >> ?+&uart1 {
> >> ?+ pinctrl-names = "default";
> >> ?+ pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
> >> ?+ status = "okay";
> >> ?+};
> >>
> >> I guess this is for bluetooth? Have you tested serdev drivers?
> >>
> > Yes, bluetooth is connected over uart1.
> > You mean if I have tested bluetooth stack via serial device?
> 
> Not quite, we're missing a child node within uart1 for a serdev driver.
> Is there no such driver yet for your Bluetooth chipset, or did you not
> yet check?

Got it. I haven't checked a serdev driver.

Maxim, the SoM can't be run without a motherboard. According to your last message
I don't change dts files, right?

Aleksandr 

WARNING: multiple messages have this Message-ID (diff)
From: Aleksandr Aleksandrov <aleksandr.aleksandrov@emlid.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "Maxime Ripard" <maxime.ripard@bootlin.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"David Lechner" <david@lechnology.com>,
	"Thierry Reding" <treding@nvidia.com>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"Johan Hovold" <johan@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3] arm64: new board - Emlid Neutis N5
Date: Fri, 12 Oct 2018 12:35:23 +0300	[thread overview]
Message-ID: <20181012093523.GA29014@imagebutcher> (raw)
In-Reply-To: <2d09d6c0-0404-589d-2c34-da846cff4fb8@suse.de>

Hi,

> >>      +/ {
> >>      + model = "Emlid Neutis N5 Developer board";
> >>      + compatible = "emlid,emlid-neutis-n5-devboard",
> >>      + "emlid,emlid-neutis-n5",
> >>
> >> Do you need the two emlid there? What comes before the comma is the
> >> vendor, while what is after is the model.
> >  
> > I think emlid-neutis-n5 module could be useful in the future, no need
> > this now.
> 
> You misunderstand: The point would be to use, e.g., "emlid,neutis-n5"
> instead of "emlid,emlid-neutis-n5" with duplicate "emlid,emlid-". It is
> orthogonal to having multiple compatible strings.

Oh, I agree. No need to duplicate "emlid". Thank you!

> >>  +&uart1 {
> >>  + pinctrl-names = "default";
> >>  + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
> >>  + status = "okay";
> >>  +};
> >>
> >> I guess this is for bluetooth? Have you tested serdev drivers?
> >>
> > Yes, bluetooth is connected over uart1.
> > You mean if I have tested bluetooth stack via serial device?
> 
> Not quite, we're missing a child node within uart1 for a serdev driver.
> Is there no such driver yet for your Bluetooth chipset, or did you not
> yet check?

Got it. I haven't checked a serdev driver.

Maxim, the SoM can't be run without a motherboard. According to your last message
I don't change dts files, right?

Aleksandr 

  parent reply	other threads:[~2018-10-12  9:35 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 13:25 [PATCH v3] Neutis N5 support Aleksandr Aleksandrov
2018-10-05 13:25 ` [PATCH v3] arm64: new board - Emlid Neutis N5 Aleksandr Aleksandrov
2018-10-05 14:48   ` Maxime Ripard
2018-10-08 15:20   ` [PATCH v3] Neutis N5 support Aleksandr Aleksandrov
2018-10-08 15:20     ` Aleksandr Aleksandrov
2018-10-08 15:20     ` Aleksandr Aleksandrov
2018-10-08 15:20     ` [PATCH v3] arm64: new board - Emlid Neutis N5 Aleksandr Aleksandrov
2018-10-08 15:20       ` Aleksandr Aleksandrov
2018-10-08 15:20       ` Aleksandr Aleksandrov
2018-10-10 14:49       ` Maxime Ripard
2018-10-10 14:49         ` Maxime Ripard
2018-10-11 12:01         ` aleksandr.aleksandrov
2018-10-11 13:20           ` Andreas Färber
2018-10-11 13:20             ` Andreas Färber
2018-10-11 16:40             ` Maxime Ripard
2018-10-11 16:40               ` Maxime Ripard
2018-10-12  9:35             ` Aleksandr Aleksandrov [this message]
2018-10-12  9:35               ` Aleksandr Aleksandrov
2018-10-12  9:57               ` Maxime Ripard
2018-10-12  9:57                 ` Maxime Ripard
2018-10-12 10:23       ` [PATCH v4 0/2] Neutis N5 support Aleksandr Aleksandrov
2018-10-12 10:23         ` Aleksandr Aleksandrov
2018-10-12 10:23         ` Aleksandr Aleksandrov
2018-10-12 10:23         ` [PATCH v4 1/2] arm64: dts: allwinner: new board - Emlid Neutis N5 Aleksandr Aleksandrov
2018-10-12 10:23           ` Aleksandr Aleksandrov
2018-10-12 10:23           ` Aleksandr Aleksandrov
2018-10-12 12:19           ` Andreas Färber
2018-10-12 12:19             ` Andreas Färber
2018-10-12 13:39             ` Aleksandr Aleksandrov
2018-10-12 13:39               ` Aleksandr Aleksandrov
2018-10-12 20:23               ` Maxime Ripard
2018-10-12 20:23                 ` Maxime Ripard
2018-10-13  2:26                 ` Chen-Yu Tsai
2018-10-13  2:26                   ` Chen-Yu Tsai
2018-10-15 11:49           ` [PATCH v5 0/2] Neutis N5 support Aleksandr Aleksandrov
2018-10-15 11:49             ` Aleksandr Aleksandrov
2018-10-15 11:49             ` Aleksandr Aleksandrov
2018-10-15 11:49             ` [PATCH v5 1/2] dt-bindings: vendor-prefix: new vendor - Emlid Aleksandr Aleksandrov
2018-10-15 11:49               ` Aleksandr Aleksandrov
2018-10-15 11:49               ` Aleksandr Aleksandrov
2018-10-15 11:49             ` [PATCH v5 2/2] arm64: dts: allwinner: new board - Emlid Neutis N5 Aleksandr Aleksandrov
2018-10-15 11:49               ` Aleksandr Aleksandrov
2018-10-15 11:49               ` Aleksandr Aleksandrov
2018-10-16  7:21             ` [PATCH v5 0/2] Neutis N5 support Maxime Ripard
2018-10-16  7:21               ` Maxime Ripard
2018-10-12 10:23         ` [PATCH v4 2/2] doc: devicetree: vendor-prefixes: new vendor - Emlid Aleksandr Aleksandrov
2018-10-12 10:23           ` Aleksandr Aleksandrov
2018-10-12 10:23           ` Aleksandr Aleksandrov
2018-10-12 11:39           ` Rob Herring
2018-10-12 11:39             ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181012093523.GA29014@imagebutcher \
    --to=aleksandr.aleksandrov@emlid.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.