From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Daney <david.daney@cavium.com>,
Sergey Temerkhanov <s.temerkhanov@gmail.com>
Cc: Jan Glauber <jglauber@cavium.com>, Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] EDAC, thunderx: memory leak in thunderx_l2c_threaded_isr()
Date: Sat, 13 Oct 2018 10:28:43 +0000 [thread overview]
Message-ID: <20181013102843.GG16086@mwanda> (raw)
I found this memory leak with static analysis, but it looks like it
might be pretty bad because it affects the success path.
Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
It's also possible that I have misread the code. It seems like an
obvious fix but I haven't tested it.
drivers/edac/thunderx_edac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
index c009d94f40c5..34be60fe6892 100644
--- a/drivers/edac/thunderx_edac.c
+++ b/drivers/edac/thunderx_edac.c
@@ -1884,7 +1884,7 @@ static irqreturn_t thunderx_l2c_threaded_isr(int irq, void *irq_id)
default:
dev_err(&l2c->pdev->dev, "Unsupported device: %04x\n",
l2c->pdev->device);
- return IRQ_NONE;
+ goto err_free;
}
while (CIRC_CNT(l2c->ring_head, l2c->ring_tail,
@@ -1906,7 +1906,7 @@ static irqreturn_t thunderx_l2c_threaded_isr(int irq, void *irq_id)
l2c->ring_tail++;
}
- return IRQ_HANDLED;
+ ret = IRQ_HANDLED;
err_free:
kfree(other);
--
2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Daney <david.daney@cavium.com>,
Sergey Temerkhanov <s.temerkhanov@gmail.com>
Cc: Jan Glauber <jglauber@cavium.com>, Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: EDAC, thunderx: memory leak in thunderx_l2c_threaded_isr()
Date: Sat, 13 Oct 2018 13:28:43 +0300 [thread overview]
Message-ID: <20181013102843.GG16086@mwanda> (raw)
I found this memory leak with static analysis, but it looks like it
might be pretty bad because it affects the success path.
Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
It's also possible that I have misread the code. It seems like an
obvious fix but I haven't tested it.
drivers/edac/thunderx_edac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
index c009d94f40c5..34be60fe6892 100644
--- a/drivers/edac/thunderx_edac.c
+++ b/drivers/edac/thunderx_edac.c
@@ -1884,7 +1884,7 @@ static irqreturn_t thunderx_l2c_threaded_isr(int irq, void *irq_id)
default:
dev_err(&l2c->pdev->dev, "Unsupported device: %04x\n",
l2c->pdev->device);
- return IRQ_NONE;
+ goto err_free;
}
while (CIRC_CNT(l2c->ring_head, l2c->ring_tail,
@@ -1906,7 +1906,7 @@ static irqreturn_t thunderx_l2c_threaded_isr(int irq, void *irq_id)
l2c->ring_tail++;
}
- return IRQ_HANDLED;
+ ret = IRQ_HANDLED;
err_free:
kfree(other);
next reply other threads:[~2018-10-13 10:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 10:28 Dan Carpenter [this message]
2018-10-13 10:28 ` EDAC, thunderx: memory leak in thunderx_l2c_threaded_isr() Dan Carpenter
2018-10-13 12:28 ` [PATCH] " Borislav Petkov
2018-10-13 12:28 ` Borislav Petkov
2018-10-15 12:47 ` [PATCH] " Jan Glauber
2018-10-15 12:47 ` Jan Glauber
2018-10-15 13:01 ` [PATCH] " Borislav Petkov
2018-10-15 13:01 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181013102843.GG16086@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bp@alien8.de \
--cc=david.daney@cavium.com \
--cc=jglauber@cavium.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=s.temerkhanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.