All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Glauber <Jan.Glauber@cavium.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	Sergey Temerkhanov <s.temerkhanov@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] EDAC, thunderx: memory leak in thunderx_l2c_threaded_isr()
Date: Mon, 15 Oct 2018 12:47:24 +0000	[thread overview]
Message-ID: <20181015124713.GA8017@hc> (raw)
In-Reply-To: <20181013102843.GG16086@mwanda>

On Sat, Oct 13, 2018 at 02:28:04PM +0200, Borislav Petkov wrote:
> On Sat, Oct 13, 2018 at 01:28:43PM +0300, Dan Carpenter wrote:
> > I found this memory leak with static analysis, but it looks like it
> > might be pretty bad because it affects the success path.
> >
> > Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > It's also possible that I have misread the code.  It seems like an
> > obvious fix but I haven't tested it.
> >
> >  drivers/edac/thunderx_edac.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Applied, thanks.
> 
> Jan, David, as a further cleanup, you could consider moving that
> allocation out of the ISR...

[-David who left Cavium]

Hi Boris,

the allocations happen only in the threaded function handlers, not in
hard IRQ context, is that still an issue?

thanks,
Jan

WARNING: multiple messages have this Message-ID (diff)
From: Jan Glauber <Jan.Glauber@cavium.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	Sergey Temerkhanov <s.temerkhanov@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: EDAC, thunderx: memory leak in thunderx_l2c_threaded_isr()
Date: Mon, 15 Oct 2018 12:47:24 +0000	[thread overview]
Message-ID: <20181015124713.GA8017@hc> (raw)

On Sat, Oct 13, 2018 at 02:28:04PM +0200, Borislav Petkov wrote:
> On Sat, Oct 13, 2018 at 01:28:43PM +0300, Dan Carpenter wrote:
> > I found this memory leak with static analysis, but it looks like it
> > might be pretty bad because it affects the success path.
> >
> > Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > It's also possible that I have misread the code.  It seems like an
> > obvious fix but I haven't tested it.
> >
> >  drivers/edac/thunderx_edac.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Applied, thanks.
> 
> Jan, David, as a further cleanup, you could consider moving that
> allocation out of the ISR...

[-David who left Cavium]

Hi Boris,

the allocations happen only in the threaded function handlers, not in
hard IRQ context, is that still an issue?

thanks,
Jan

  parent reply	other threads:[~2018-10-15 12:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-13 10:28 [PATCH] EDAC, thunderx: memory leak in thunderx_l2c_threaded_isr() Dan Carpenter
2018-10-13 10:28 ` Dan Carpenter
2018-10-13 12:28 ` [PATCH] " Borislav Petkov
2018-10-13 12:28   ` Borislav Petkov
2018-10-15 12:47 ` Jan Glauber [this message]
2018-10-15 12:47   ` Jan Glauber
2018-10-15 13:01 ` [PATCH] " Borislav Petkov
2018-10-15 13:01   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181015124713.GA8017@hc \
    --to=jan.glauber@cavium.com \
    --cc=bp@alien8.de \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=s.temerkhanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.