From: gorcunov at gmail.com (Cyrill Gorcunov)
Subject: [PATCH] proc: fix proc-self-map-files selftest for arm
Date: Mon, 15 Oct 2018 20:21:40 +0300 [thread overview]
Message-ID: <20181015172140.GJ2401@uranus.lan> (raw)
In-Reply-To: <52504bd5-b4ed-518b-f748-c634172c6c68@linaro.org>
On Mon, Oct 15, 2018 at 01:55:14PM -0300, Rafael David Tinoco wrote:
> That is what I also had in mind, thus the patch. I just realized we had
> another issue on LKFT (our functional tests tool) for
> proc-self-map-files-001.c. Test 001 does pretty much the same as 002, but
> without the MAP_FIXED mmap flag.
>
> Is it okay to consolidate both tests into just 1, and focus in checking
> procfs numbers conversion only, rather than if mapping 0 is allowed or not ?
> Can I send a v2 with that in mind ?
As to me -- yes, I would move zero page testing to a separate memory testcase.
But since Alexey is the former author of the tests better wait for his opinion.
WARNING: multiple messages have this Message-ID (diff)
From: gorcunov@gmail.com (Cyrill Gorcunov)
Subject: [PATCH] proc: fix proc-self-map-files selftest for arm
Date: Mon, 15 Oct 2018 20:21:40 +0300 [thread overview]
Message-ID: <20181015172140.GJ2401@uranus.lan> (raw)
Message-ID: <20181015172140.Yk7V1040ohm0MlSBgeBK6T2HVKKJkfnfPtxK7eFifeM@z> (raw)
In-Reply-To: <52504bd5-b4ed-518b-f748-c634172c6c68@linaro.org>
On Mon, Oct 15, 2018@01:55:14PM -0300, Rafael David Tinoco wrote:
> That is what I also had in mind, thus the patch. I just realized we had
> another issue on LKFT (our functional tests tool) for
> proc-self-map-files-001.c. Test 001 does pretty much the same as 002, but
> without the MAP_FIXED mmap flag.
>
> Is it okay to consolidate both tests into just 1, and focus in checking
> procfs numbers conversion only, rather than if mapping 0 is allowed or not ?
> Can I send a v2 with that in mind ?
As to me -- yes, I would move zero page testing to a separate memory testcase.
But since Alexey is the former author of the tests better wait for his opinion.
WARNING: multiple messages have this Message-ID (diff)
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Rafael David Tinoco <rafael.tinoco@linaro.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
shuah@kernel.org
Subject: Re: [PATCH] proc: fix proc-self-map-files selftest for arm
Date: Mon, 15 Oct 2018 20:21:40 +0300 [thread overview]
Message-ID: <20181015172140.GJ2401@uranus.lan> (raw)
In-Reply-To: <52504bd5-b4ed-518b-f748-c634172c6c68@linaro.org>
On Mon, Oct 15, 2018 at 01:55:14PM -0300, Rafael David Tinoco wrote:
> That is what I also had in mind, thus the patch. I just realized we had
> another issue on LKFT (our functional tests tool) for
> proc-self-map-files-001.c. Test 001 does pretty much the same as 002, but
> without the MAP_FIXED mmap flag.
>
> Is it okay to consolidate both tests into just 1, and focus in checking
> procfs numbers conversion only, rather than if mapping 0 is allowed or not ?
> Can I send a v2 with that in mind ?
As to me -- yes, I would move zero page testing to a separate memory testcase.
But since Alexey is the former author of the tests better wait for his opinion.
next prev parent reply other threads:[~2018-10-15 17:21 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 18:43 [PATCH] proc: fix proc-self-map-files selftest for arm rafael.tinoco
2018-10-11 18:43 ` Rafael David Tinoco
2018-10-11 18:43 ` Rafael David Tinoco
2018-10-11 19:42 ` gorcunov
2018-10-11 19:42 ` Cyrill Gorcunov
2018-10-11 19:42 ` Cyrill Gorcunov
2018-10-11 20:56 ` adobriyan
2018-10-11 20:56 ` Alexey Dobriyan
2018-10-11 20:56 ` Alexey Dobriyan
2018-10-11 21:02 ` gorcunov
2018-10-11 21:02 ` Cyrill Gorcunov
2018-10-11 21:02 ` Cyrill Gorcunov
2018-10-11 21:30 ` adobriyan
2018-10-11 21:30 ` Alexey Dobriyan
2018-10-11 21:30 ` Alexey Dobriyan
2018-10-11 22:00 ` gorcunov
2018-10-11 22:00 ` Cyrill Gorcunov
2018-10-11 22:00 ` Cyrill Gorcunov
2018-10-15 16:55 ` rafael.tinoco
2018-10-15 16:55 ` Rafael David Tinoco
2018-10-15 16:55 ` Rafael David Tinoco
2018-10-15 17:21 ` gorcunov [this message]
2018-10-15 17:21 ` Cyrill Gorcunov
2018-10-15 17:21 ` Cyrill Gorcunov
2018-11-08 10:41 ` rafael.tinoco
2018-11-08 10:41 ` Rafael David Tinoco
2018-11-08 10:41 ` Rafael David Tinoco
2018-11-08 11:11 ` gorcunov
2018-11-08 11:11 ` Cyrill Gorcunov
2018-11-08 11:11 ` Cyrill Gorcunov
2018-11-09 11:30 ` [PATCH] proc: fix and merge proc-self-map-file tests rafael.tinoco
2018-11-09 11:30 ` Rafael David Tinoco
2018-11-09 11:30 ` Rafael David Tinoco
2018-11-09 11:41 ` gorcunov
2018-11-09 11:41 ` Cyrill Gorcunov
2018-11-09 11:41 ` Cyrill Gorcunov
2018-11-09 11:45 ` rafael.tinoco
2018-11-09 11:45 ` Rafael David Tinoco
2018-11-09 11:45 ` Rafael David Tinoco
2018-11-09 11:48 ` gorcunov
2018-11-09 11:48 ` Cyrill Gorcunov
2018-11-09 11:48 ` Cyrill Gorcunov
2018-11-09 12:01 ` rafael.tinoco
2018-11-09 12:01 ` Rafael David Tinoco
2018-11-09 12:01 ` Rafael David Tinoco
2018-11-09 18:04 ` gorcunov
2018-11-09 18:04 ` Cyrill Gorcunov
2018-11-09 18:04 ` Cyrill Gorcunov
2018-11-09 18:48 ` rafael.tinoco
2018-11-09 18:48 ` Rafael David Tinoco
2018-11-09 18:48 ` Rafael David Tinoco
2018-11-09 19:39 ` gorcunov
2018-11-09 19:39 ` Cyrill Gorcunov
2018-11-09 19:39 ` Cyrill Gorcunov
2018-11-10 17:47 ` adobriyan
2018-11-10 17:47 ` Alexey Dobriyan
2018-11-10 17:47 ` Alexey Dobriyan
2018-11-10 17:56 ` rafael.tinoco
2018-11-10 17:56 ` Rafael David Tinoco
2018-11-10 17:56 ` Rafael David Tinoco
2018-11-10 18:49 ` adobriyan
2018-11-10 18:49 ` Alexey Dobriyan
2018-11-10 18:49 ` Alexey Dobriyan
2018-11-11 2:50 ` rafael.tinoco
2018-11-11 2:50 ` Rafael David Tinoco
2018-11-11 2:50 ` Rafael David Tinoco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015172140.GJ2401@uranus.lan \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.