All of lore.kernel.org
 help / color / mirror / Atom feed
From: adobriyan at gmail.com (Alexey Dobriyan)
Subject: [PATCH] proc: fix and merge proc-self-map-file tests
Date: Sat, 10 Nov 2018 21:49:57 +0300	[thread overview]
Message-ID: <20181110184957.GB18252@avx2> (raw)
In-Reply-To: <1541872563.3175498.1572453416.153B57C9@webmail.messagingengine.com>

On Sat, Nov 10, 2018 at 03:56:03PM -0200, Rafael David Tinoco wrote:
> On Sat, Nov 10, 2018, at 3:47 PM, Alexey Dobriyan wrote:
> > On Fri, Nov 09, 2018 at 09:30:36AM -0200, Rafael David Tinoco wrote:
> > > Merge proc-self-map-files tests into one since this test should focus in
> > > testing readlink in /proc/self/map_files/* only, and not trying to test
> > > mapping virtual address 0.
> > > 
> > > Lowest virtual address for user space mapping in other architectures,
> > > like arm, is *at least* *(PAGE_SIZE * 2) and NULL hint does not
> > > guarantee that when MAP_FIXED flag, important to this test, is given.
> > > This patch also fixes this issue in remaining test.
> > 
> > > -	p = mmap(NULL, PAGE_SIZE, PROT_NONE, MAP_PRIVATE|MAP_FILE, fd, 0);
> > > +	p = mmap((void *) (2 * PAGE_SIZE), PAGE_SIZE, PROT_NONE,
> > 
> > I don't know ARM. Is this 2 page limitation a limitation of hardware or
> > kernel's?
> 
> Kernel:
> https://bugs.linaro.org/show_bug.cgi?id=3782#c7

Ahh. please test the path I've sent, I don't have arm install readily
available.

WARNING: multiple messages have this Message-ID (diff)
From: adobriyan@gmail.com (Alexey Dobriyan)
Subject: [PATCH] proc: fix and merge proc-self-map-file tests
Date: Sat, 10 Nov 2018 21:49:57 +0300	[thread overview]
Message-ID: <20181110184957.GB18252@avx2> (raw)
Message-ID: <20181110184957.BexqxPdclY9pvgdn96ar6yMTDqsFJLsJfAGybSCb6ao@z> (raw)
In-Reply-To: <1541872563.3175498.1572453416.153B57C9@webmail.messagingengine.com>

On Sat, Nov 10, 2018@03:56:03PM -0200, Rafael David Tinoco wrote:
> On Sat, Nov 10, 2018,@3:47 PM, Alexey Dobriyan wrote:
> > On Fri, Nov 09, 2018@09:30:36AM -0200, Rafael David Tinoco wrote:
> > > Merge proc-self-map-files tests into one since this test should focus in
> > > testing readlink in /proc/self/map_files/* only, and not trying to test
> > > mapping virtual address 0.
> > > 
> > > Lowest virtual address for user space mapping in other architectures,
> > > like arm, is *at least* *(PAGE_SIZE * 2) and NULL hint does not
> > > guarantee that when MAP_FIXED flag, important to this test, is given.
> > > This patch also fixes this issue in remaining test.
> > 
> > > -	p = mmap(NULL, PAGE_SIZE, PROT_NONE, MAP_PRIVATE|MAP_FILE, fd, 0);
> > > +	p = mmap((void *) (2 * PAGE_SIZE), PAGE_SIZE, PROT_NONE,
> > 
> > I don't know ARM. Is this 2 page limitation a limitation of hardware or
> > kernel's?
> 
> Kernel:
> https://bugs.linaro.org/show_bug.cgi?id=3782#c7

Ahh. please test the path I've sent, I don't have arm install readily
available.

WARNING: multiple messages have this Message-ID (diff)
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Rafael David Tinoco <rafael.tinoco@linaro.org>
Cc: gorcunov@gmail.com, akpm@linux-foundation.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, shuah@kernel.org
Subject: Re: [PATCH] proc: fix and merge proc-self-map-file tests
Date: Sat, 10 Nov 2018 21:49:57 +0300	[thread overview]
Message-ID: <20181110184957.GB18252@avx2> (raw)
In-Reply-To: <1541872563.3175498.1572453416.153B57C9@webmail.messagingengine.com>

On Sat, Nov 10, 2018 at 03:56:03PM -0200, Rafael David Tinoco wrote:
> On Sat, Nov 10, 2018, at 3:47 PM, Alexey Dobriyan wrote:
> > On Fri, Nov 09, 2018 at 09:30:36AM -0200, Rafael David Tinoco wrote:
> > > Merge proc-self-map-files tests into one since this test should focus in
> > > testing readlink in /proc/self/map_files/* only, and not trying to test
> > > mapping virtual address 0.
> > > 
> > > Lowest virtual address for user space mapping in other architectures,
> > > like arm, is *at least* *(PAGE_SIZE * 2) and NULL hint does not
> > > guarantee that when MAP_FIXED flag, important to this test, is given.
> > > This patch also fixes this issue in remaining test.
> > 
> > > -	p = mmap(NULL, PAGE_SIZE, PROT_NONE, MAP_PRIVATE|MAP_FILE, fd, 0);
> > > +	p = mmap((void *) (2 * PAGE_SIZE), PAGE_SIZE, PROT_NONE,
> > 
> > I don't know ARM. Is this 2 page limitation a limitation of hardware or
> > kernel's?
> 
> Kernel:
> https://bugs.linaro.org/show_bug.cgi?id=3782#c7

Ahh. please test the path I've sent, I don't have arm install readily
available.

  reply	other threads:[~2018-11-10 18:49 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11 18:43 [PATCH] proc: fix proc-self-map-files selftest for arm rafael.tinoco
2018-10-11 18:43 ` Rafael David Tinoco
2018-10-11 18:43 ` Rafael David Tinoco
2018-10-11 19:42 ` gorcunov
2018-10-11 19:42   ` Cyrill Gorcunov
2018-10-11 19:42   ` Cyrill Gorcunov
2018-10-11 20:56 ` adobriyan
2018-10-11 20:56   ` Alexey Dobriyan
2018-10-11 20:56   ` Alexey Dobriyan
2018-10-11 21:02   ` gorcunov
2018-10-11 21:02     ` Cyrill Gorcunov
2018-10-11 21:02     ` Cyrill Gorcunov
2018-10-11 21:30     ` adobriyan
2018-10-11 21:30       ` Alexey Dobriyan
2018-10-11 21:30       ` Alexey Dobriyan
2018-10-11 22:00       ` gorcunov
2018-10-11 22:00         ` Cyrill Gorcunov
2018-10-11 22:00         ` Cyrill Gorcunov
2018-10-15 16:55         ` rafael.tinoco
2018-10-15 16:55           ` Rafael David Tinoco
2018-10-15 16:55           ` Rafael David Tinoco
2018-10-15 17:21           ` gorcunov
2018-10-15 17:21             ` Cyrill Gorcunov
2018-10-15 17:21             ` Cyrill Gorcunov
2018-11-08 10:41             ` rafael.tinoco
2018-11-08 10:41               ` Rafael David Tinoco
2018-11-08 10:41               ` Rafael David Tinoco
2018-11-08 11:11               ` gorcunov
2018-11-08 11:11                 ` Cyrill Gorcunov
2018-11-08 11:11                 ` Cyrill Gorcunov
2018-11-09 11:30                 ` [PATCH] proc: fix and merge proc-self-map-file tests rafael.tinoco
2018-11-09 11:30                   ` Rafael David Tinoco
2018-11-09 11:30                   ` Rafael David Tinoco
2018-11-09 11:41                   ` gorcunov
2018-11-09 11:41                     ` Cyrill Gorcunov
2018-11-09 11:41                     ` Cyrill Gorcunov
2018-11-09 11:45                     ` rafael.tinoco
2018-11-09 11:45                       ` Rafael David Tinoco
2018-11-09 11:45                       ` Rafael David Tinoco
2018-11-09 11:48                       ` gorcunov
2018-11-09 11:48                         ` Cyrill Gorcunov
2018-11-09 11:48                         ` Cyrill Gorcunov
2018-11-09 12:01                         ` rafael.tinoco
2018-11-09 12:01                           ` Rafael David Tinoco
2018-11-09 12:01                           ` Rafael David Tinoco
2018-11-09 18:04                           ` gorcunov
2018-11-09 18:04                             ` Cyrill Gorcunov
2018-11-09 18:04                             ` Cyrill Gorcunov
2018-11-09 18:48                             ` rafael.tinoco
2018-11-09 18:48                               ` Rafael David Tinoco
2018-11-09 18:48                               ` Rafael David Tinoco
2018-11-09 19:39                               ` gorcunov
2018-11-09 19:39                                 ` Cyrill Gorcunov
2018-11-09 19:39                                 ` Cyrill Gorcunov
2018-11-10 17:47                   ` adobriyan
2018-11-10 17:47                     ` Alexey Dobriyan
2018-11-10 17:47                     ` Alexey Dobriyan
2018-11-10 17:56                     ` rafael.tinoco
2018-11-10 17:56                       ` Rafael David Tinoco
2018-11-10 17:56                       ` Rafael David Tinoco
2018-11-10 18:49                       ` adobriyan [this message]
2018-11-10 18:49                         ` Alexey Dobriyan
2018-11-10 18:49                         ` Alexey Dobriyan
2018-11-11  2:50                         ` rafael.tinoco
2018-11-11  2:50                           ` Rafael David Tinoco
2018-11-11  2:50                           ` Rafael David Tinoco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181110184957.GB18252@avx2 \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.